blender
/
blender
134
398
Fork 580
Code Issues 6.3k Pull Requests 756 Projects 19 Wiki Activity

VSE: improved handle tweaking #109522

Open
Richard Antalik wants to merge 53 commits from iss/blender:tweak-experiment into main
pull from: iss/blender:tweak-experiment
merge into: blender:main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
Conversation 75 Commits 53 Files Changed 26 +831 -208
Richard Antalik commented 2023-06-29 17:53:17 +02:00
Member
Copy Link

This commit changes how users can interact with handles:

Unselected handles are not drawn anymore by default, but this can be
changed in overlays. Handles are bit thinner. If handle can't be
selected, because strip is too small, it is not drawn.

When hovering over strip handle a cursor is changed to represent a
handle shape. It is possible to select 2 handles at once if strips are
adjoined. When tweak event happens, previous handle selection is lost,
so only handles/strips that are clicked on are moved. After tweaking,
handles are deselected. This behavior can be disabled in preferences:
Editing > Video Sequencer > Tweak Handles.

Moving strips with G key works same way as before.

This commit changes how users can interact with handles: Unselected handles are not drawn anymore by default, but this can be changed in overlays. Handles are bit thinner. If handle can't be selected, because strip is too small, it is not drawn. When hovering over strip handle a cursor is changed to represent a handle shape. It is possible to select 2 handles at once if strips are adjoined. When tweak event happens, previous handle selection is lost, so only handles/strips that are clicked on are moved. After tweaking, handles are deselected. This behavior can be disabled in preferences: Editing > Video Sequencer > Tweak Handles. Moving strips with G key works same way as before.
Richard Antalik added 2 commits 2023-06-29 17:53:25 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
3ad1686fdf Add handle cursors, tweak select fallback condition.
Richard Antalik commented 2023-06-29 17:55:02 +02:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2023-06-29 17:55:05 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
Richard Antalik added 1 commit 2023-06-30 15:32:33 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
258b624711 implement double handle selection
Richard Antalik commented 2023-06-30 15:32:59 +02:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2023-06-30 15:33:02 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
Richard Antalik added 2 commits 2023-07-13 04:54:40 +02:00
buildbot/vexp-code-patch-coordinator Build done. Details
268622f22e Fix incorrect operation with high DPI screens.
Richard Antalik commented 2023-07-13 04:54:43 +02:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2023-07-13 04:54:46 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
tintwotin commented 2023-07-14 23:55:25 +02:00
First-time contributor
Copy Link

Tried this build. As mentioned in Harley's patch, indicating with the mouse cursor what will happen is a great way to inform users what will happen when they click at that spot.

As this patch currently is, can't the selected handle to the left be seen at all:
image

Since a 3D object, do not have both an outline on the object and a selected vertex in the 3D View(it is either or), consider removing the strip outline, when the handle of a strip is selected. That'll make it much easier to see what is selected.

Now you're using a bracket shape mouse cursor, have I previously made a patch which adds bracket shaped handles: https://archive.blender.org/developer/differential/0010/0010297/index.html
image

The trouble with the handles is that the handle will cover the waveform, so it becomes difficult to make an exact edit based on the waveform: https://archive.blender.org/developer/maniphest/0090/0090824/index.html

When Billray was working for BF, we talked about rounded strips, so it would become more clear where the in and out points are - and having thin rounded handles following the outline.

Another design could be to have handles which are not in the full height of the strip and have rounded corners inwards(indicating direction).

Consider a hot zone in the center of a strip and a new mouse cursor in order to execute the Slip operator.

Consider making an e/w icon variation of then e/w/n/s icon for when handles are transformed, since they can't be moved up or down.

Tried this build. As mentioned in Harley's patch, indicating with the mouse cursor what will happen is a great way to inform users what will happen when they click at that spot. As this patch currently is, can't the selected handle to the left be seen at all: ![image](/attachments/b80eb3f9-6054-4c1c-b60f-96af62c0e353) Since a 3D object, do not have both an outline on the object and a selected vertex in the 3D View(it is either or), consider removing the strip outline, when the handle of a strip is selected. That'll make it much easier to see what is selected. Now you're using a bracket shape mouse cursor, have I previously made a patch which adds bracket shaped handles: https://archive.blender.org/developer/differential/0010/0010297/index.html ![image](/attachments/5dfee019-8579-4125-823f-37087ae1652f) The trouble with the handles is that the handle will cover the waveform, so it becomes difficult to make an exact edit based on the waveform: https://archive.blender.org/developer/maniphest/0090/0090824/index.html When Billray was working for BF, we talked about rounded strips, so it would become more clear where the in and out points are - and having thin rounded handles following the outline. Another design could be to have handles which are not in the full height of the strip and have rounded corners inwards(indicating direction). Consider a hot zone in the center of a strip and a new mouse cursor in order to execute the Slip operator. Consider making an e/w icon variation of then e/w/n/s icon for when handles are transformed, since they can't be moved up or down.
brackets (1).gif
166 KiB
image.png
2.0 KiB
Richard Antalik added 2 commits 2023-09-21 23:43:01 +02:00
Richard Antalik requested review from Francesco Siddi 2023-09-21 23:43:33 +02:00
Richard Antalik commented 2023-09-21 23:43:43 +02:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2023-09-21 23:43:47 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
Francesco Siddi commented 2023-09-22 00:05:20 +02:00
Member
Copy Link

Thanks for the update on this. A couple of suggestions:

  • Please make sure that the feature works when using right-click-select
  • Do not switch cursor to the 4 arrows when transforming the edges of a clip
Thanks for the update on this. A couple of suggestions: * Please make sure that the feature works when using right-click-select * Do not switch cursor to the 4 arrows when transforming the edges of a clip
👍 1
Richard Antalik added 1 commit 2023-09-22 00:07:43 +02:00
Richard Antalik added 1 commit 2023-09-22 00:10:00 +02:00
Richard Antalik added 3 commits 2023-11-18 01:35:50 +01:00
Richard Antalik added 2 commits 2023-11-20 05:54:17 +01:00
buildbot/vexp-code-patch-coordinator Build done. Details
4c71bd35ec Fix Box selec not working
Richard Antalik commented 2023-11-20 06:03:24 +01:00
Author
Member
Copy Link

@fsiddi Chat is down so will respond here - will kick the bot, just wanted to do some fixes. There is still minor discrepancy on how transform works when you use right and left mouse button. LMB in RCS works as expected, all other modes won't deselect neighboring handle when moving only one of them. Will fix that.

With modified keymap, this feature can be optional as we wanted, but there will be some weird items that are basically blocked by select and frame change operator. It is bit more readable now, but still worth documenting

@blender-bot package

@fsiddi Chat is down so will respond here - will kick the bot, just wanted to do some fixes. There is still minor discrepancy on how transform works when you use right and left mouse button. LMB in RCS works as expected, all other modes won't deselect neighboring handle when moving only one of them. Will fix that. With modified keymap, this feature can be optional as we wanted, but there will be some weird items that are basically blocked by select and frame change operator. It is bit more readable now, but still worth documenting @blender-bot package
Blender Bot commented 2023-11-20 06:03:27 +01:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
tintwotin commented 2023-11-21 09:13:52 +01:00
First-time contributor
Copy Link

As noted above, when selecting/transforming two adjoined handles, the selected handle on one of the sides is not visible(looks like the outline).
https://projects.blender.org/blender/blender/attachments/b80eb3f9-6054-4c1c-b60f-96af62c0e353 Both selected handles should be visible.

As the mouse cursor should illustrate what happens when the user is clicking, when two adjoined handles are selected, the mouse cursor should not be changed to single side transform, since this in not what will happen:
trim_cursor_adjoined.gif

During a transform operation, the mouse cursor is changed from the handle cursor to n/s/e/w cursor. Imo, it should stay as handle cursor.

The little arrow on the single sided handle cursor seems redundant, and even misleading, as if you only can move the handle one direction?

There could also be a hot zone in the middle of a strip for the Slip operation and the mouse cursor could look like this: [ ]

As noted above, when selecting/transforming two adjoined handles, the selected handle on one of the sides is not visible(looks like the outline). https://projects.blender.org/blender/blender/attachments/b80eb3f9-6054-4c1c-b60f-96af62c0e353 Both selected handles should be visible. As the mouse cursor should illustrate what happens when the user is clicking, when two adjoined handles are selected, the mouse cursor should not be changed to single side transform, since this in not what will happen: ![trim_cursor_adjoined.gif](/attachments/3b573775-a6d3-433a-8b7c-af2d953bfb21) During a transform operation, the mouse cursor is changed from the handle cursor to n/s/e/w cursor. Imo, it should stay as handle cursor. The little arrow on the single sided handle cursor seems redundant, and even misleading, as if you only can move the handle one direction? There could also be a hot zone in the middle of a strip for the Slip operation and the mouse cursor could look like this: [ ]
trim_cursor_adjoined.gif
20 KiB
Richard Antalik added 2 commits 2023-12-01 17:38:33 +01:00
Richard Antalik added 1 commit 2023-12-01 18:37:09 +01:00
Richard Antalik changed title from WIP: VSE handle drawing/tweaking experiment to VSE handle drawing/tweaking experiment 2023-12-01 18:41:12 +01:00
Richard Antalik commented 2023-12-01 19:26:29 +01:00
Author
Member
Copy Link

Seems, that handle size is sometimes drawn as 5px, sometimes as 4px. Will rebase this patch and check how this can be resolved. In meanwhile, will just increase handle width so I don't mix fixes in this patch.

Seems, that handle size is sometimes drawn as 5px, sometimes as 4px. Will rebase this patch and check how this can be resolved. In meanwhile, will just increase handle width so I don't mix fixes in this patch.
Richard Antalik added 1 commit 2023-12-01 19:28:46 +01:00
Richard Antalik commented 2023-12-01 19:32:52 +01:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2023-12-01 19:32:55 +01:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
tintwotin commented 2023-12-01 20:19:27 +01:00
First-time contributor
Copy Link

Seems, that handle size is sometimes drawn as 5px, sometimes as 4px. Will rebase this patch and check how this can be resolved. In meanwhile, will just increase handle width so I don't mix fixes in this patch.

The multiple challenges of thin handles were already addressed here:
https://archive.blender.org/developer/differential/0010/0010297/index.html

This imprecise drawing of the line width, make thin handles disappear and blend in with the outline. A solution to this in the above link was to either select outlines or handles, and never both. When you think about it, there is no reason for having both selected. And not having the outline selected when a handle is selected makes the handle stand out.

Another problem is the two adjoined handles may look like one, to solve this problem, a separating line was introduced, and with bracket shapes added, made it very clear in what direction the handle went (and what strip the handle belonged to).

In addition to these challenges, when zoomed out in the timeline, the handles become very small and potentially invisible(especially when they're thin to begin with) - has this been dealt with in this patch?

Since there are no replies to any of my comments above, I wonder if the addressed problems are not considered problems, or what is going on here?

> Seems, that handle size is sometimes drawn as 5px, sometimes as 4px. Will rebase this patch and check how this can be resolved. In meanwhile, will just increase handle width so I don't mix fixes in this patch. The multiple challenges of thin handles were already addressed here: https://archive.blender.org/developer/differential/0010/0010297/index.html This imprecise drawing of the line width, make thin handles disappear and blend in with the outline. A solution to this in the above link was to either select outlines or handles, and never both. When you think about it, there is no reason for having both selected. And not having the outline selected when a handle is selected makes the handle stand out. Another problem is the two adjoined handles may look like one, to solve this problem, a separating line was introduced, and with bracket shapes added, made it very clear in what direction the handle went (and what strip the handle belonged to). In addition to these challenges, when zoomed out in the timeline, the handles become very small and potentially invisible(especially when they're thin to begin with) - has this been dealt with in this patch? Since there are no replies to any of my comments above, I wonder if the addressed problems are not considered problems, or what is going on here?
Richard Antalik commented 2023-12-02 19:25:11 +01:00
Author
Member
Copy Link

Seems, that handle size is sometimes drawn as 5px, sometimes as 4px. Will rebase this patch and check how this can be resolved. In meanwhile, will just increase handle width so I don't mix fixes in this patch.

The multiple challenges of thin handles were already addressed here:
https://archive.blender.org/developer/differential/0010/0010297/index.html

This imprecise drawing of the line width, make thin handles disappear and blend in with the outline. A solution to this in the above link was to either select outlines or handles, and never both. When you think about it, there is no reason for having both selected. And not having the outline selected when a handle is selected makes the handle stand out.

Makes sense, will try that.

Another problem is the two adjoined handles may look like one, to solve this problem, a separating line was introduced, and with bracket shapes added, made it very clear in what direction the handle went (and what strip the handle belonged to).

I think, that having black outline visible when handle is selected may be necessary, since both strips share that pixel as start/end.

In addition to these challenges, when zoomed out in the timeline, the handles become very small and potentially invisible(especially when they're thin to begin with) - has this been dealt with in this patch?

Don't think, that this is an issue really. Currently it is not possible to select handles when they are too small and I did not change it here.

Since there are no replies to any of my comments above, I wonder if the addressed problems are not considered problems, or what is going on here?

This started with simple goal - to draw cursor when hovering over handle + to make them slimmer. More changes I would rather separate unless they are necessary for functionality.

> > Seems, that handle size is sometimes drawn as 5px, sometimes as 4px. Will rebase this patch and check how this can be resolved. In meanwhile, will just increase handle width so I don't mix fixes in this patch. > > The multiple challenges of thin handles were already addressed here: > https://archive.blender.org/developer/differential/0010/0010297/index.html > > This imprecise drawing of the line width, make thin handles disappear and blend in with the outline. A solution to this in the above link was to either select outlines or handles, and never both. When you think about it, there is no reason for having both selected. And not having the outline selected when a handle is selected makes the handle stand out. Makes sense, will try that. > Another problem is the two adjoined handles may look like one, to solve this problem, a separating line was introduced, and with bracket shapes added, made it very clear in what direction the handle went (and what strip the handle belonged to). I think, that having black outline visible when handle is selected may be necessary, since both strips share that pixel as start/end. > In addition to these challenges, when zoomed out in the timeline, the handles become very small and potentially invisible(especially when they're thin to begin with) - has this been dealt with in this patch? Don't think, that this is an issue really. Currently it is not possible to select handles when they are too small and I did not change it here. > Since there are no replies to any of my comments above, I wonder if the addressed problems are not considered problems, or what is going on here? This started with simple goal - to draw cursor when hovering over handle + to make them slimmer. More changes I would rather separate unless they are necessary for functionality.
Francesco Siddi commented 2023-12-09 21:22:38 +01:00
Member
Copy Link

When releasing (only after dragging), deselect the handle and leave the strip selected. This allows us to still select individual and multiple handles, but allows us to quickly transform a whole strip once is has been resized.

When releasing (only after dragging), deselect the handle and leave the strip selected. This allows us to still select individual and multiple handles, but allows us to quickly transform a whole strip once is has been resized.
Richard Antalik commented 2023-12-09 21:45:04 +01:00
Author
Member
Copy Link

I can do that, but with current setup, handles would be deselected even if you press G key, which I don't think is desirable. The only way transform operator can discriminate between 2 behaviors is whether this tweaking method is enabled in preferences.

Maybe I can hack in some form of signalling in SpaceSeq::runtime, but that would be based on mouse cursor position and unreliable.
Though looking at TransInfo, there is is_launch_event_drag field, so will check that out. Would definitely simplify things...

I can do that, but with current setup, handles would be deselected even if you press G key, which I don't think is desirable. The only way transform operator can discriminate between 2 behaviors is whether this tweaking method is enabled in preferences. Maybe I can hack in some form of signalling in `SpaceSeq::runtime`, but that would be based on mouse cursor position and unreliable. Though looking at `TransInfo`, there is `is_launch_event_drag` field, so will check that out. Would definitely simplify things...
Richard Antalik added 2 commits 2023-12-10 19:52:05 +01:00
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
6a12c8b1fe Deselect handles after tweaking
Richard Antalik commented 2023-12-10 19:52:29 +01:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2023-12-10 19:52:33 +01:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
Richard Antalik commented 2024-01-11 14:55:39 +01:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-01-11 14:55:42 +01:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
Richard Antalik added 1 commit 2024-01-11 18:27:58 +01:00
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
012726217b Fix unused variables, only change cursor when dragging with mouse.
Richard Antalik commented 2024-01-11 18:28:00 +01:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-01-11 18:28:04 +01:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
Richard Antalik added 1 commit 2024-01-11 18:43:31 +01:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
a707721135 Merge branch 'main' into tweak-experiment
Richard Antalik commented 2024-01-11 18:44:01 +01:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-01-11 18:44:05 +01:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
tintwotin commented 2024-01-12 05:21:32 +01:00
First-time contributor
Copy Link

The mouse cursor, when moving the cursor over a narrow strip, it feels like the click point in the cursor is jumping back/forth(left/right) because the click point is actually changing position, and this feels wrong. The click point in left/center/right handle cursor should be in the same place. So, I would say in the left/right mouse cursor, the vertical bar and the click point should be in the center and the tiny arrow should be removed. This way will the horizontal line in the left/right handle cursor change side and the vertical line will stay in the same place.

Also, it feels like the hot zones are too big in a strip with a considerable size you will not get the grab strip(not handle option):
mouse_cursor.gif

In the center area, the n/s/e/w cursor could be used? (Also then pressing "S" for slide)?

When handles are selected and pressing "G" only e/w cursor should be used, bc they can't be moved up/down.

When transforming adjoined handles, they look asymmetrical(outline when drag is imprecise?):
image
Have you tried removing outlines when handles are selected? As suggested above?
IMO, there is no need to both have an outline and a handle selected.
In the 3D View, you do not have both have a vertex and the object selected.

Previously you could not transform effect strips with fixed length like cross, you can do that now. I guess that til is a bug?
cross_transform.gif

Was there a limit before so you could not drag like this, but only to the allowed point? Looks wonky.
limit_transform.gif

The mouse cursor, when moving the cursor over a narrow strip, it feels like the click point in the cursor is jumping back/forth(left/right) because the click point is actually changing position, and this feels wrong. The click point in left/center/right handle cursor should be in the same place. So, I would say in the left/right mouse cursor, the vertical bar and the click point should be in the center and the tiny arrow should be removed. This way will the horizontal line in the left/right handle cursor change side and the vertical line will stay in the same place. Also, it feels like the hot zones are too big in a strip with a considerable size you will not get the grab strip(not handle option): ![mouse_cursor.gif](/attachments/dfd98e08-1d11-46ac-bdba-a4dff471c2cf) In the center area, the n/s/e/w cursor could be used? (Also then pressing "S" for slide)? When handles are selected and pressing "G" only e/w cursor should be used, bc they can't be moved up/down. When transforming adjoined handles, they look asymmetrical(outline when drag is imprecise?): ![image](/attachments/2d82ceaa-3358-479f-bd18-93a3771b126f) Have you tried removing outlines when handles are selected? As suggested above? IMO, there is no need to both have an outline and a handle selected. In the 3D View, you do not have both have a vertex and the object selected. Previously you could not transform effect strips with fixed length like cross, you can do that now. I guess that til is a bug? ![cross_transform.gif](/attachments/7c5d303a-bbe7-4dd3-abd5-52f181bc7fd3) Was there a limit before so you could not drag like this, but only to the allowed point? Looks wonky. ![limit_transform.gif](/attachments/17bd0e8a-489d-4cfb-9013-d3a0b5bb33d3)
image.png
14 KiB
mouse_cursor.gif
30 KiB
limit_transform.gif
134 KiB
cross_transform.gif
23 KiB
Richard Antalik commented 2024-01-14 20:02:42 +01:00
Author
Member
Copy Link

The mouse cursor, when moving the cursor over a narrow strip, it feels like the click point in the cursor is jumping back/forth(left/right) because the click point is actually changing position, and this feels wrong. The click point in left/center/right handle cursor should be in the same place. So, I would say in the left/right mouse cursor, the vertical bar and the click point should be in the center and the tiny arrow should be removed. This way will the horizontal line in the left/right handle cursor change side and the vertical line will stay in the same place.

I don't know. Personally I feel lost when using cursors without arrows. I would like to gather more feedback on this point, but I wouldn't mind either variant.

Also, it feels like the hot zones are too big in a strip with a considerable size you will not get the grab strip(not handle option):
mouse_cursor.gif

That seems to be correct, will fix

In the center area, the n/s/e/w cursor could be used? (Also then pressing "S" for slide)?

I mean it could be used, but it is for different purpose. The handle cursor only indicates what you are clicking on, NSEW cursor indicates what you can do or what will happen after clicking. This patch is pretty much pre-selection indicator, but with cursor instead element highlighting.

When transforming adjoined handles, they look asymmetrical(outline when drag is imprecise?):
image
Have you tried removing outlines when handles are selected? As suggested above?
IMO, there is no need to both have an outline and a handle selected.
In the 3D View, you do not have both have a vertex and the object selected.

I have played with this briefly, but wasn't able to fix it. Maybe this is some pixel alignment issue with view coords, not sure.

Previously you could not transform effect strips with fixed length like cross, you can do that now. I guess that til is a bug?
cross_transform.gif

Yep, tat's a bug

Was there a limit before so you could not drag like this, but only to the allowed point? Looks wonky.
limit_transform.gif

Nope, there wasn't such limit. Not impossible to implement, there already is limit for strip length.

> The mouse cursor, when moving the cursor over a narrow strip, it feels like the click point in the cursor is jumping back/forth(left/right) because the click point is actually changing position, and this feels wrong. The click point in left/center/right handle cursor should be in the same place. So, I would say in the left/right mouse cursor, the vertical bar and the click point should be in the center and the tiny arrow should be removed. This way will the horizontal line in the left/right handle cursor change side and the vertical line will stay in the same place. I don't know. Personally I feel lost when using cursors without arrows. I would like to gather more feedback on this point, but I wouldn't mind either variant. > Also, it feels like the hot zones are too big in a strip with a considerable size you will not get the grab strip(not handle option): > ![mouse_cursor.gif](/attachments/dfd98e08-1d11-46ac-bdba-a4dff471c2cf) That seems to be correct, will fix > In the center area, the n/s/e/w cursor could be used? (Also then pressing "S" for slide)? I mean it could be used, but it is for different purpose. The handle cursor only indicates what you are clicking on, NSEW cursor indicates what you can do or what will happen after clicking. This patch is pretty much pre-selection indicator, but with cursor instead element highlighting. > When transforming adjoined handles, they look asymmetrical(outline when drag is imprecise?): > ![image](/attachments/2d82ceaa-3358-479f-bd18-93a3771b126f) > Have you tried removing outlines when handles are selected? As suggested above? > IMO, there is no need to both have an outline and a handle selected. > In the 3D View, you do not have both have a vertex and the object selected. I have played with this briefly, but wasn't able to fix it. Maybe this is some pixel alignment issue with view coords, not sure. > Previously you could not transform effect strips with fixed length like cross, you can do that now. I guess that til is a bug? > ![cross_transform.gif](/attachments/7c5d303a-bbe7-4dd3-abd5-52f181bc7fd3) Yep, tat's a bug > Was there a limit before so you could not drag like this, but only to the allowed point? Looks wonky. > ![limit_transform.gif](/attachments/17bd0e8a-489d-4cfb-9013-d3a0b5bb33d3) Nope, there wasn't such limit. Not impossible to implement, there already is limit for strip length.
tintwotin commented 2024-01-27 12:58:03 +01:00
First-time contributor
Copy Link

The mouse cursor, when moving the cursor over a narrow strip, it feels like the click point in the cursor is jumping back/forth(left/right) because the click point is actually changing position, and this feels wrong. The click point in left/center/right handle cursor should be in the same place. So, I would say in the left/right mouse cursor, the vertical bar and the click point should be in the center and the tiny arrow should be removed. This way will the horizontal line in the left/right handle cursor change side and the vertical line will stay in the same place.

I don't know. Personally I feel lost when using cursors without arrows. I would like to gather more feedback on this point, but I wouldn't mind either variant.

If you want to keep the arrows, then maybe try to keep the selection point the same place in the mouse cursor icon. In other words, keep the point the arrows are pointing at the very same place in all VSE selection/trimming icons.

In the center area, the n/s/e/w cursor could be used? (Also then pressing "S" for slide)?

I mean it could be used, but it is for different purpose. The handle cursor only indicates what you are clicking on, NSEW cursor indicates what you can do or what will happen after clicking. This patch is pretty much pre-selection indicator, but with cursor instead element highlighting.

IMO, have the elements highlighting still a place, especially if the unselected handle indicators are removed(they should be visible, when hover). On the nsew, another wording would be, that it is simply wrong to use it after a handle has been selected, because in that case is it impossible to move ns. And the EW icon will be an indication of what will happen if you click and drag at that point.

When transforming adjoined handles, they look asymmetrical(outline when drag is imprecise?):
image
Have you tried removing outlines when handles are selected? As suggested above?
IMO, there is no need to both have an outline and a handle selected.
In the 3D View, you do not have both have a vertex and the object selected.

I have played with this briefly, but wasn't able to fix it. Maybe this is some pixel alignment issue with view coords, not sure.

In my attempt, mentioned above, I kept a black line between the strips in all states, so the strips will not be "fighting" over the center pixel, and make things asymmetrical.

> > The mouse cursor, when moving the cursor over a narrow strip, it feels like the click point in the cursor is jumping back/forth(left/right) because the click point is actually changing position, and this feels wrong. The click point in left/center/right handle cursor should be in the same place. So, I would say in the left/right mouse cursor, the vertical bar and the click point should be in the center and the tiny arrow should be removed. This way will the horizontal line in the left/right handle cursor change side and the vertical line will stay in the same place. > > I don't know. Personally I feel lost when using cursors without arrows. I would like to gather more feedback on this point, but I wouldn't mind either variant. If you want to keep the arrows, then maybe try to keep the selection point the same place in the mouse cursor icon. In other words, keep the point the arrows are pointing at the very same place in all VSE selection/trimming icons. > > In the center area, the n/s/e/w cursor could be used? (Also then pressing "S" for slide)? > > I mean it could be used, but it is for different purpose. The handle cursor only indicates what you are clicking on, NSEW cursor indicates what you can do or what will happen after clicking. This patch is pretty much pre-selection indicator, but with cursor instead element highlighting. IMO, have the elements highlighting still a place, especially if the unselected handle indicators are removed(they should be visible, when hover). On the nsew, another wording would be, that it is simply wrong to use it after a handle has been selected, because in that case is it impossible to move ns. And the EW icon will be an indication of what will happen if you click and drag at that point. > > > When transforming adjoined handles, they look asymmetrical(outline when drag is imprecise?): > > ![image](/attachments/2d82ceaa-3358-479f-bd18-93a3771b126f) > > Have you tried removing outlines when handles are selected? As suggested above? > > IMO, there is no need to both have an outline and a handle selected. > > In the 3D View, you do not have both have a vertex and the object selected. > > I have played with this briefly, but wasn't able to fix it. Maybe this is some pixel alignment issue with view coords, not sure. In my attempt, mentioned above, I kept a black line between the strips in all states, so the strips will not be "fighting" over the center pixel, and make things asymmetrical.
Richard Antalik added 5 commits 2024-02-27 20:51:19 +01:00
e7830a92c9 Fix: Crash when multiview movie right view is missing. 
Ultimately this was due to missing nullptr check before trying to
process the image, but this should have been caught when loading
ImBufAnims. If any is missing, cancel multiview loading and load
movie as if it was single view only.
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
ed369943f8 Refine selection a bit
Richard Antalik commented 2024-02-27 20:52:44 +01:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-02-27 20:52:46 +01:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
Richard Antalik added 2 commits 2024-02-28 15:34:28 +01:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
4c43aece4c make format
Richard Antalik commented 2024-02-28 15:47:11 +01:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-02-28 15:47:17 +01:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
Francesco Siddi commented 2024-02-28 17:08:57 +01:00
Member
Copy Link

Good progress. A couple of notes:

  • when two clips are adjacent, make sure their handles can be selected individually as well. This this means having three zones, left center and right of the cut, showing three different icons.
  • make sure handles can be drawn as an overlay
  • rename the Preferences>Editing>Video Sequencer>Simplified Handle Tweaking to "Tweak Handles", and make sure that when disabled it actually works
Good progress. A couple of notes: - when two clips are adjacent, make sure their handles can be selected individually as well. This this means having three zones, left center and right of the cut, showing three different icons. - make sure handles can be drawn as an overlay - rename the Preferences>Editing>Video Sequencer>Simplified Handle Tweaking to "Tweak Handles", and make sure that when disabled it actually works
Richard Antalik added 4 commits 2024-03-06 17:17:10 +01:00
Richard Antalik added 1 commit 2024-03-06 19:13:24 +01:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
620fb4e836 Add handle overlay option
Richard Antalik commented 2024-03-06 19:14:24 +01:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-03-06 19:14:28 +01:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
Richard Antalik added 1 commit 2024-03-06 20:44:27 +01:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
9e95bc585a Fix incorrect selection of both handles
Richard Antalik commented 2024-03-06 20:46:36 +01:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-03-06 20:46:39 +01:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
Richard Antalik commented 2024-03-06 20:50:29 +01:00
Author
Member
Copy Link

@fsiddi Updated the patch with suggestions. Not sure if you want handles as standalone overlay, or whether this should be updated when you enable/disable Tweak Handles option. Right now it is standalone overlay option.

@fsiddi Updated the patch with suggestions. Not sure if you want handles as standalone overlay, or whether this should be updated when you enable/disable Tweak Handles option. Right now it is standalone overlay option.
tintwotin commented 2024-03-06 21:05:23 +01:00
First-time contributor
Copy Link

It's better, but there is still an issue, when strips get narrow:
mouse_c.gif

It doesn't feel very clear and solid what will happen if you click at a specific point this way. Imo, some hover highlighting of the handle area is needed to make it more predictable and easy to read what is being clicked. The click area of the handles could light up like these buttons(I mean, it is not a new concept in Blender that things you can click lights up when hovering over them):

It's better, but there is still an issue, when strips get narrow: ![mouse_c.gif](/attachments/29f0cb34-5200-492d-8da5-c2e55c8fed5f) It doesn't feel very clear and solid what will happen if you click at a specific point this way. Imo, some hover highlighting of the handle area is needed to make it more predictable and easy to read what is being clicked. The click area of the handles could light up like these buttons(I mean, it is not a new concept in Blender that things you can click lights up when hovering over them):
mouse_c.gif
12 KiB
hover.gif
39 KiB
hover.gif
Richard Antalik commented 2024-03-07 20:57:33 +01:00
Author
Member
Copy Link

@tintwotin Thanks for noticing that, will fix. I think the idea behind cursor is to emulate gizmo. Some gizmos use highlighting as well so this could be done with handles.

@tintwotin Thanks for noticing that, will fix. I think the idea behind cursor is to emulate gizmo. Some gizmos use highlighting as well so this could be done with handles.
Richard Antalik added 1 commit 2024-03-07 20:58:17 +01:00
Richard Antalik added 1 commit 2024-03-07 21:13:24 +01:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
dd7c5df122 Fix handle transform text
Richard Antalik commented 2024-03-07 21:19:06 +01:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-03-07 21:19:10 +01:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
Francesco Siddi commented 2024-03-08 10:18:37 +01:00
Member
Copy Link

Looks good to me. Get some code review and merge!

Looks good to me. Get some code review and merge!
tintwotin commented 2024-03-08 10:34:46 +01:00
First-time contributor
Copy Link

I would recommend doing a test-build and get community feedback on it, since this is a major change in how it feels to work in the VSE. As mentioned, without handle hover highlighting, it feels very random in what area you need to click to select a handle, especially when the strips are narrow. Did Hjalti test it?

I would recommend doing a test-build and get community feedback on it, since this is a major change in how it feels to work in the VSE. As mentioned, without handle hover highlighting, it feels very random in what area you need to click to select a handle, especially when the strips are narrow. Did Hjalti test it?
Francesco Siddi commented 2024-03-08 11:53:22 +01:00
Member
Copy Link

Should definitely make a test build and make a feedback thread on devtalk. The hover effect is something done in properties editor, but not in other parts of Blender, I rather stay aligned with that for the time being. Hjalti is not a fan of this feature, so I don't think he will use it. As a matter of fact, it's possible to configure Blender to its original behavior and completely ignore this.

Should definitely make a test build and make a feedback thread on devtalk. The hover effect is something done in properties editor, but not in other parts of Blender, I rather stay aligned with that for the time being. Hjalti is not a fan of this feature, so I don't think he will use it. As a matter of fact, it's possible to configure Blender to its original behavior and completely ignore this.
Richard Antalik commented 2024-03-08 17:07:59 +01:00
Author
Member
Copy Link

Will have to go over this patch again myself, as the code is not great. Will make feedback thread.

I had to edit some footage today, so I used this patch.
Some workflows are worse off:

  • Interferes with blade tool (should be fixed)
  • Interferes with scrubbing area (should be fixed)
  • Previously handles of shorter strips could be selected due to width of cursor
    • This seems to affect also when tweaking option is off (should be fixed)

Some better

  • No longer translating only handle when I forget to deselect it
  • Visual feedback for selection

Also noticed, that handles are drawn on too small strips, will have to fix that too, since now it is guesswork to know at which zoom level the handle can be selected.

I rarely use adjoined selection (in this edit 0 times eh :), so I would say it's downside for me, since it interferes with handle selection when strips are next to each other, but can imagine some users loving it.

Overall I would like to have option to just disable adjoined selection behavior and perhaps make the cursor somehow slimmer.

Will have to go over this patch again myself, as the code is not great. Will make feedback thread. I had to edit some footage today, so I used this patch. Some workflows are worse off: - Interferes with blade tool (should be fixed) - Interferes with scrubbing area (should be fixed) - Previously handles of shorter strips could be selected due to width of cursor - This seems to affect also when tweaking option is off (should be fixed) Some better - No longer translating only handle when I forget to deselect it - Visual feedback for selection Also noticed, that handles are drawn on too small strips, will have to fix that too, since now it is guesswork to know at which zoom level the handle can be selected. I rarely use adjoined selection (in this edit 0 times eh :), so I would say it's downside for me, since it interferes with handle selection when strips are next to each other, but can imagine some users loving it. Overall I would like to have option to just disable adjoined selection behavior and perhaps make the cursor somehow slimmer.
Richard Antalik force-pushed tweak-experiment from 08b3db9e95 to 3ffc3e7f2f 2024-03-18 20:44:07 +01:00 Compare
Richard Antalik added 1 commit 2024-03-18 22:18:26 +01:00
Richard Antalik added 1 commit 2024-03-19 22:39:43 +01:00
Richard Antalik changed title from VSE handle drawing/tweaking experiment to VSE: improved handle tweaking 2024-03-19 22:56:37 +01:00
Richard Antalik added 1 commit 2024-03-20 18:03:03 +01:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
7eac65ad69 Fix incorrect validation of existing selection
Richard Antalik requested review from Sergey Sharybin 2024-03-20 18:05:08 +01:00
Richard Antalik commented 2024-03-20 18:09:05 +01:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-03-20 18:09:08 +01:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
Richard Antalik added 3 commits 2024-03-22 19:55:25 +01:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
2af5f36b43 Draw larger handles when this feature is disabled.
Richard Antalik commented 2024-03-22 19:56:29 +01:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-03-22 19:56:32 +01:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
Sergey Sharybin commented 2024-04-15 17:46:25 +02:00
Owner
Copy Link

Had some issues applying the patch, so was testing builds from https://builder.blender.org/download/patch/PR109522/

There is something very wrong with the keymap and overall behavior:

  • Hovering over the handles does not change cursor shape on macOS
  • Handles are not deselected after tweak
  • I could not get the selection of two adjacent handles to work
  • Frame scrubbing is forced to only happen when dragging on the timecode (previously when RMB selection scrubbing was possible in any empty place of the editor)
  • Selection hot zones seems strange as well: quite often clicking on a handle of adjacent strips selects handle of an adjacent strip, not the strip on which click happened
Had some issues applying the patch, so was testing builds from https://builder.blender.org/download/patch/PR109522/ There is something very wrong with the keymap and overall behavior: - Hovering over the handles does not change cursor shape on macOS - Handles are not deselected after tweak - I could not get the selection of two adjacent handles to work - Frame scrubbing is forced to only happen when dragging on the timecode (previously when RMB selection scrubbing was possible in any empty place of the editor) - Selection hot zones seems strange as well: quite often clicking on a handle of adjacent strips selects handle of an adjacent strip, not the strip on which click happened
Richard Antalik commented 2024-04-15 21:59:50 +02:00
Author
Member
Copy Link

Will update the patch. Not sure if I tested this on Mac last time I updated patch, but there isn't anything too OS specific, maybe DPI scale...
I can reproduce issue with RMB scrubbing, it works here for about 50% of time, will fix this.
Other issues I was not able to reproduce. Will also doublecheck on Mac.

Will update the patch. Not sure if I tested this on Mac last time I updated patch, but there isn't anything too OS specific, maybe DPI scale... I can reproduce issue with RMB scrubbing, it works here for about 50% of time, will fix this. Other issues I was not able to reproduce. Will also doublecheck on Mac.
Richard Antalik added 1 commit 2024-04-15 22:55:31 +02:00
Richard Antalik added 1 commit 2024-04-16 00:35:40 +02:00
Sergey Sharybin commented 2024-04-16 14:01:52 +02:00
Owner
Copy Link

Thanks for the update, it seems to have helped with some of the points from my previous comment, but not all of them.

For example, frame scrubbing is still not possible outside of the timecode header with RMB selection.
Also, the hot-zones feels smaller to what they are for area edge sliding, or node edge resizing.

Thanks for the update, it seems to have helped with some of the points from my previous comment, but not all of them. For example, frame scrubbing is still not possible outside of the timecode header with RMB selection. Also, the hot-zones feels smaller to what they are for area edge sliding, or node edge resizing.
Richard Antalik commented 2024-04-16 22:56:28 +02:00
Author
Member
Copy Link

Indeed, checking now on mac, and this still needs some work.

Indeed, checking now on mac, and this still needs some work.
Richard Antalik added 1 commit 2024-04-17 22:41:27 +02:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
8d7cd738eb Fix scrubbing not working, incorrect effect strip length, ensure effects can not be resized.
Richard Antalik commented 2024-04-17 22:44:18 +02:00
Author
Member
Copy Link

@Sergey The issues you have mentioned should be fixed.

@Sergey The issues you have mentioned should be fixed.
Francesco Siddi commented 2024-04-24 14:01:57 +02:00
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-04-24 14:02:00 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
Sergey Sharybin reviewed 2024-04-24 15:29:25 +02:00
source/blender/blenloader/intern/versioning_userdef.cc Outdated
@ -946,2 +946,4 @@
}
if (!USER_VERSION_ATLEAST(402, 19)) {
userdef->sequencer_editor_flag |= USER_SEQ_ED_SIMPLE_TWEAKING;
Sergey Sharybin commented 2024-04-24 15:25:38 +02:00
Owner
Copy Link

userdef_default.cc needs to have the sequencer_editor_flag flag set as well. Otherwise blender --factory-startup does not have the new intended behavior.

`userdef_default.cc` needs to have the `sequencer_editor_flag ` flag set as well. Otherwise `blender --factory-startup` does not have the new intended behavior.
iss marked this conversation as resolved
source/blender/editors/animation/anim_ops.cc
@ -230,6 +246,9 @@ static int change_frame_invoke(bContext *C, wmOperator *op, const wmEvent *event
if (CTX_wm_space_seq(C) != nullptr && region->regiontype == RGN_TYPE_PREVIEW) {
return OPERATOR_CANCELLED;
}
if (sequencer_skip_for_handle_tweak(C, event)) {
Sergey Sharybin commented 2024-04-24 15:26:59 +02:00
Owner
Copy Link

Generic animation system operator should not worry about sequencer.

The way such dependencies were commonly used is via order of operators in the keymap. If sequencer tweaking needs to take priority, it should be in the list first, and the rest of operators should not be adjusting to the behavior of other operators.

Generic animation system operator should not worry about sequencer. The way such dependencies were commonly used is via order of operators in the keymap. If sequencer tweaking needs to take priority, it should be in the list first, and the rest of operators should not be adjusting to the behavior of other operators.
Richard Antalik commented 2024-04-25 03:25:18 +02:00
Author
Member
Copy Link

The issue here is, that we want left click to tweak and also scrub. Only other way to achieve this would be to passthrough from sequencer select operator. But to achieve that, it would need to check if it was invoked by left or right click. I guess I could add hidden operator property which would distinguish how it was invoked. Either way it is hacky.

The issue here is, that we want left click to tweak and also scrub. Only other way to achieve this would be to passthrough from sequencer select operator. But to achieve that, it would need to check if it was invoked by left or right click. I guess I could add hidden operator property which would distinguish how it was invoked. Either way it is hacky.
Sergey Sharybin commented 2024-04-26 10:38:48 +02:00
Owner
Copy Link

Why can't the handle tweak event always return PASS_THROUGH when it is invoked outside of any handle's hot area?

Why can't the handle tweak event always return `PASS_THROUGH` when it is invoked outside of any handle's hot area?
Richard Antalik commented 2024-04-29 05:34:59 +02:00
Author
Member
Copy Link

Because it is select operator and if I am not mistaken in RCS it is not modal. At least it isn't when invoked with left click.

Because it is select operator and if I am not mistaken in RCS it is not modal. At least it isn't when invoked with left click.
source/blender/editors/include/ED_sequencer.hh Outdated
@ -46,3 +49,3 @@
void ED_sequencer_special_preview_set(bContext *C, const int mval[2]);
void ED_sequencer_special_preview_clear();
bool sequencer_retiming_mode_is_active(const bContext *C);
bool sequencer_retiming_mode_is_active(const Scene *scene);
Sergey Sharybin commented 2024-04-24 15:29:19 +02:00
Owner
Copy Link

Why is the sequencer_retiming_mode_is_active changing with this PR?

Why is the `sequencer_retiming_mode_is_active` changing with this PR?
Richard Antalik commented 2024-04-25 03:33:13 +02:00
Author
Member
Copy Link

I would guess that at some point I tried to use it from place with no access to bContext, but then changed this again.

Will revert this change.

I would guess that at some point I tried to use it from place with no access to `bContext`, but then changed this again. Will revert this change.
iss marked this conversation as resolved
Francesco Siddi commented 2024-04-24 17:25:21 +02:00
Member
Copy Link

Some feedback to finalize this patch from the UX standpoint:

  • Enable Tweak Handles preference by default
  • Remove handles overlay option from VSE
  • Draw handles overlay only when Tweak Handles is off
  • With RCS: when multiple strips are selected, tweaking the handles should transform all selected strips, not only one (works with LCS)
  • With RCS: shift click drag to tweak handles currently does not work
Some feedback to finalize this patch from the UX standpoint: - Enable Tweak Handles preference by default - Remove handles overlay option from VSE - Draw handles overlay only when Tweak Handles is off - With RCS: when multiple strips are selected, tweaking the handles should transform all selected strips, not only one (works with LCS) - With RCS: shift click drag to tweak handles currently does not work
Richard Antalik commented 2024-04-25 02:17:57 +02:00
Author
Member
Copy Link

@fsiddi

Enable Tweak Handles preference by default

Tweak handles is enabled by default. It could be, that you have your own startup file, AFAIK these are not changed by versioning. Eeh not sure, perhaps adding this to userdef_default.c would solve the issue for you.

With RCS: when multiple strips are selected, tweaking the handles should transform all selected strips, not only one (works with LCS)

In RCS, when dragging with left click, only 1 element moves, when dragging with right click, whole selection moves. I have a feeling, that we have discussed this, but could be mistaken. Will change this to work same way with both buttons.

With RCS: shift click drag to tweak handles currently does not work

shift click drag is not a thing? What is that supposed to do?

@fsiddi > Enable Tweak Handles preference by default Tweak handles is enabled by default. It could be, that you have your own startup file, AFAIK these are not changed by versioning. Eeh not sure, perhaps adding this to `userdef_default.c` would solve the issue for you. > With RCS: when multiple strips are selected, tweaking the handles should transform all selected strips, not only one (works with LCS) In RCS, when dragging with left click, only 1 element moves, when dragging with right click, whole selection moves. I have a feeling, that we have discussed this, but could be mistaken. Will change this to work same way with both buttons. > With RCS: shift click drag to tweak handles currently does not work shift click drag is not a thing? What is that supposed to do?
Richard Antalik added 3 commits 2024-04-25 04:09:42 +02:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
41b482f5ff Make right click tweak in RCS not deselect all strips if RC event happened on strip that is already selected
Richard Antalik commented 2024-04-25 04:10:08 +02:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-04-25 04:10:11 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
Francesco Siddi commented 2024-04-25 19:14:56 +02:00
Member
Copy Link

In RCS, when dragging with left click, only 1 element moves, when dragging with right click, whole selection moves. I have a feeling, that we have discussed this, but could be mistaken. Will change this to work same way with both buttons.

Yes, please.

With RCS: shift click drag to tweak handles currently does not work

shift click drag is not a thing? What is that supposed to do?

Nothing, you are right. Was expecting precision tweak, but that happens only after you click.

> In RCS, when dragging with left click, only 1 element moves, when dragging with right click, whole selection moves. I have a feeling, that we have discussed this, but could be mistaken. Will change this to work same way with both buttons. > Yes, please. > > With RCS: shift click drag to tweak handles currently does not work > > shift click drag is not a thing? What is that supposed to do? Nothing, you are right. Was expecting precision tweak, but that happens only after you click.
Richard Antalik commented 2024-04-25 19:35:19 +02:00
Author
Member
Copy Link

@fsiddi Right so I did that. You can test the new build.

In RCS, when dragging with left click, only 1 element moves, when dragging with right click, whole selection moves. I have a feeling, that we have discussed this, but could be mistaken. Will change this to work same way with both buttons.

Yes, please.

Ok I did that, so you can test the new build.

@fsiddi Right so I did that. You can test the new build. > > > In RCS, when dragging with left click, only 1 element moves, when dragging with right click, whole selection moves. I have a feeling, that we have discussed this, but could be mistaken. Will change this to work same way with both buttons. > > > > Yes, please. Ok I did that, so you can test the new build.
Francesco Siddi commented 2024-04-28 10:30:39 +02:00
Member
Copy Link

Some final visual adjustments to the cursor. Notice the updated position. This might still not be perfect as I could not test the changes directly in the code.

Regular Current Expected
c_01.png c_02.png c_03.png

Also, a suggestion on the design itself.

Current Proposed
c_04.png c_05.png)
Some final visual adjustments to the cursor. Notice the updated position. This might still not be perfect as I could not test the changes directly in the code. | Regular | Current | Expected | | -------- | ------- | --- | | ![c_01.png](/attachments/76968a53-3b7c-44aa-90f6-df0d4d4c6249) | ![c_02.png](/attachments/ffb2ecbb-375f-481e-b9ac-631c5ba38ab9) | ![c_03.png](/attachments/dee2c1e9-bec7-4664-bb64-9b66fdd55d1c) | Also, a suggestion on the design itself. | Current | Proposed | | -- | -- | | ![c_04.png](/attachments/31d0ea18-3033-44fd-a6d1-584f30218cbc) | ![c_05.png](/attachments/8d093654-14e3-45c0-bd96-dc46f25bca59)) |
c_01.png
10 KiB
c_02.png
9.5 KiB
c_04.png
6.5 KiB
c_05.png
4.2 KiB
c_03.png
10 KiB
👍 1
Richard Antalik commented 2024-04-29 05:25:00 +02:00
Author
Member
Copy Link

Some final visual adjustments to the cursor. Notice the updated position. This might still not be perfect as I could not test the changes directly in the code.

Regular Current Expected
c_01.png c_02.png c_03.png

I assume this means, that you want cursor to be centered? I had build like that for feedback, but was likely broken when I checked devtalk thread now... Anyway, it's simple change so will do that, even though I don't like it that way - The triangle is supposed to be mini cursor, which is aligned with mouse position. Perhaps it could be removed, or those triangles could be drawn on both sides.

Also, a suggestion on the design itself.

Current Proposed
c_04.png c_05.png)

Currently only 16x16 pure black/white/transparent are supported by these cursor definitions. I could look at other type of cursors that are used for transformation, those seem to support at least grayscale, but not sure if these can be used in this case.

> Some final visual adjustments to the cursor. Notice the updated position. This might still not be perfect as I could not test the changes directly in the code. > > | Regular | Current | Expected | > | -------- | ------- | --- | > | ![c_01.png](/attachments/76968a53-3b7c-44aa-90f6-df0d4d4c6249) | ![c_02.png](/attachments/ffb2ecbb-375f-481e-b9ac-631c5ba38ab9) | ![c_03.png](/attachments/dee2c1e9-bec7-4664-bb64-9b66fdd55d1c) | I assume this means, that you want cursor to be centered? I had build like that for feedback, but was likely broken when I checked devtalk thread now... Anyway, it's simple change so will do that, even though I don't like it that way - The triangle is supposed to be mini cursor, which is aligned with mouse position. Perhaps it could be removed, or those triangles could be drawn on both sides. > Also, a suggestion on the design itself. > > | Current | Proposed | > | -- | -- | > | ![c_04.png](/attachments/31d0ea18-3033-44fd-a6d1-584f30218cbc) | ![c_05.png](/attachments/8d093654-14e3-45c0-bd96-dc46f25bca59)) | > Currently only 16x16 pure black/white/transparent are supported by these cursor definitions. I could look at other type of cursors that are used for transformation, those seem to support at least grayscale, but not sure if these can be used in this case.
Richard Antalik added 1 commit 2024-04-29 05:42:06 +02:00
buildbot/vexp-code-patch-lint Build done. Details
buildbot/vexp-code-patch-darwin-x86_64 Build done. Details
buildbot/vexp-code-patch-darwin-arm64 Build done. Details
buildbot/vexp-code-patch-linux-x86_64 Build done. Details
buildbot/vexp-code-patch-windows-amd64 Build done. Details
buildbot/vexp-code-patch-coordinator Build done. Details
bb317978e2 Make cursors centered
Richard Antalik commented 2024-04-29 06:20:54 +02:00
Author
Member
Copy Link

@blender-bot package

@blender-bot package
Blender Bot commented 2024-04-29 06:20:57 +02:00
Member
Copy Link

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.
Pablo Vazquez commented 2024-04-30 16:52:36 +02:00
Member
Copy Link

@iss Could this be updated to the latest main please? It'd make it easier to review as I'm having issues which I'm not sure are part of this PR or already fixed in main.

(for example, I can't select time-locked strips)

@iss Could this be updated to the latest `main` please? It'd make it easier to review as I'm having issues which I'm not sure are part of this PR or already fixed in main. (for example, I can't select time-locked strips)
Richard Antalik added 1 commit 2024-05-01 06:36:36 +02:00
Richard Antalik commented 2024-05-01 06:37:37 +02:00
Author
Member
Copy Link

@pablovazquez Updated PR. Can reproduce no selection with locked strips. Will fix.

@pablovazquez Updated PR. Can reproduce no selection with locked strips. Will fix.
❤️ 1
Richard Antalik force-pushed tweak-experiment from 7322bbf4b2 to 88dccb8a19 2024-05-01 06:41:56 +02:00 Compare
Sergey Sharybin commented 2024-05-01 11:14:04 +02:00
Owner
Copy Link

It would help to move all the non-functional changes refactors to main, to help understanding what's going on here, and whether the added complexity is really inevitable.

For example, changes like Sequence *SEQ_select_active_get(Scene *scene); -> Sequence *SEQ_select_active_get(const Scene *scene);, selected_strips_from_context -> ED_sequencer_selected_strips_from_context, bool retiming_keys_are_visible(const bContext *C) -> bool retiming_keys_are_visible(const SpaceSeq *sseq).

It would help to move all the non-functional changes refactors to main, to help understanding what's going on here, and whether the added complexity is really inevitable. For example, changes like `Sequence *SEQ_select_active_get(Scene *scene);` -> `Sequence *SEQ_select_active_get(const Scene *scene);`, `selected_strips_from_context` -> `ED_sequencer_selected_strips_from_context`, `bool retiming_keys_are_visible(const bContext *C)` -> `bool retiming_keys_are_visible(const SpaceSeq *sseq)`.
Richard Antalik commented 2024-05-02 12:52:11 +02:00
Author
Member
Copy Link

It would help to move all the non-functional changes refactors to main, to help understanding what's going on here, and whether the added complexity is really inevitable.

I can do that, the commit would make little sense out of context of this PR. So I will reference this PR in commit message.

> It would help to move all the non-functional changes refactors to main, to help understanding what's going on here, and whether the added complexity is really inevitable. I can do that, the commit would make little sense out of context of this PR. So I will reference this PR in commit message.
Sergey Sharybin commented 2024-05-02 16:28:38 +02:00
Owner
Copy Link

@iss Sounds good!

Also, if there are some other non-functional-changes/cleanup possible to extract from this PR which wasn't so obvious on an initial read, feel free to to the same :)

@iss Sounds good! Also, if there are some other non-functional-changes/cleanup possible to extract from this PR which wasn't so obvious on an initial read, feel free to to the same :)
This pull request has changes conflicting with the target branch.
  • source/blender/blenkernel/BKE_blender_version.h
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u tweak-experiment:iss-tweak-experiment
git checkout iss-tweak-experiment
Sign in to join this conversation.
Reviewers
No reviewers
Francesco Siddi
Sergey Sharybin
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#109522
No description provided.
Delete Branch "iss/blender:tweak-experiment"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?