VSE handle drawing/tweaking experiment #109522

Richard Antalik · 2023-06-29T17:53:17+02:00

Richard Antalik commented

2023-06-29 17:53:17 +02:00

This is based on idea provided by @fsiddi and #107950. Goal is to simplify UI make handle moving more intuitive.

Changes:

Only draw selected handles
Make handles much thinner
Draw cursor when you hover over handle, but this cursor represents which handle is being selected or tweaked

Then there was idea to make tweak action more context aware - so if you have selection and drag right handle with mouse, just drag right handles of selected strips. Same with dragging strip - if there are handles selected on some strips, ignore(deselect) them. The seq_slide operator itself should work as it does now when activated with G key.

TODO:

Ensure fallback tool is not affected.

This is based on idea provided by @fsiddi and #107950. Goal is to simplify UI make handle moving more intuitive. Changes: - Only draw selected handles - Make handles much thinner - Draw cursor when you hover over handle, but this cursor represents which handle is being selected or tweaked Then there was idea to make tweak action more context aware - so if you have selection and drag right handle with mouse, just drag right handles of selected strips. Same with dragging strip - if there are handles selected on some strips, ignore(deselect) them. The seq_slide operator itself should work as it does now when activated with G key. TODO: - Ensure fallback tool is not affected.

Richard Antalik added 2 commits 2023-06-29 17:53:25 +02:00

5ded0bed37 testing stuff

buildbot/vexp-code-patch-coordinator Build done. Details

3ad1686fdf Add handle cursors, tweak select fallback condition.

Richard Antalik commented

2023-06-29 17:55:02 +02:00

@blender-bot package

Blender Bot commented

2023-06-29 17:55:05 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.

Richard Antalik added 1 commit 2023-06-30 15:32:33 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

258b624711 implement double handle selection

Richard Antalik commented

2023-06-30 15:32:59 +02:00

@blender-bot package

Blender Bot commented

2023-06-30 15:33:02 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.

Richard Antalik added 2 commits 2023-07-13 04:54:40 +02:00

83294a7cba Merge branch 'tweak-experiment' of https://projects.blender.org/iss/blender into tweak-experiment

buildbot/vexp-code-patch-coordinator Build done. Details

268622f22e Fix incorrect operation with high DPI screens.

Richard Antalik commented

2023-07-13 04:54:43 +02:00

@blender-bot package

Blender Bot commented

2023-07-13 04:54:46 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.

tintwotin commented

2023-07-14 23:55:25 +02:00

First-time contributor

Tried this build. As mentioned in Harley's patch, indicating with the mouse cursor what will happen is a great way to inform users what will happen when they click at that spot.

As this patch currently is, can't the selected handle to the left be seen at all:

Since a 3D object, do not have both an outline on the object and a selected vertex in the 3D View(it is either or), consider removing the strip outline, when the handle of a strip is selected. That'll make it much easier to see what is selected.

Now you're using a bracket shape mouse cursor, have I previously made a patch which adds bracket shaped handles: https://archive.blender.org/developer/differential/0010/0010297/index.html

The trouble with the handles is that the handle will cover the waveform, so it becomes difficult to make an exact edit based on the waveform: https://archive.blender.org/developer/maniphest/0090/0090824/index.html

When Billray was working for BF, we talked about rounded strips, so it would become more clear where the in and out points are - and having thin rounded handles following the outline.

Another design could be to have handles which are not in the full height of the strip and have rounded corners inwards(indicating direction).

Consider a hot zone in the center of a strip and a new mouse cursor in order to execute the Slip operator.

Consider making an e/w icon variation of then e/w/n/s icon for when handles are transformed, since they can't be moved up or down.

Tried this build. As mentioned in Harley's patch, indicating with the mouse cursor what will happen is a great way to inform users what will happen when they click at that spot. As this patch currently is, can't the selected handle to the left be seen at all: ![image](/attachments/b80eb3f9-6054-4c1c-b60f-96af62c0e353) Since a 3D object, do not have both an outline on the object and a selected vertex in the 3D View(it is either or), consider removing the strip outline, when the handle of a strip is selected. That'll make it much easier to see what is selected. Now you're using a bracket shape mouse cursor, have I previously made a patch which adds bracket shaped handles: https://archive.blender.org/developer/differential/0010/0010297/index.html ![image](/attachments/5dfee019-8579-4125-823f-37087ae1652f) The trouble with the handles is that the handle will cover the waveform, so it becomes difficult to make an exact edit based on the waveform: https://archive.blender.org/developer/maniphest/0090/0090824/index.html When Billray was working for BF, we talked about rounded strips, so it would become more clear where the in and out points are - and having thin rounded handles following the outline. Another design could be to have handles which are not in the full height of the strip and have rounded corners inwards(indicating direction). Consider a hot zone in the center of a strip and a new mouse cursor in order to execute the Slip operator. Consider making an e/w icon variation of then e/w/n/s icon for when handles are transformed, since they can't be moved up or down.

brackets (1).gif

166 KiB

image.png

2.0 KiB

Richard Antalik added 2 commits 2023-09-21 23:43:01 +02:00

5c1a7128c7 Merge branch 'main' into tweak-experiment

buildbot/vexp-code-patch-coordinator Build done. Details

49feb63766 Make nicer cursors, use default cursor if strip is too small

Richard Antalik requested review from Francesco Siddi 2023-09-21 23:43:33 +02:00

Richard Antalik commented

2023-09-21 23:43:43 +02:00

@blender-bot package

Blender Bot commented

2023-09-21 23:43:47 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.

Francesco Siddi commented

2023-09-22 00:05:20 +02:00

Thanks for the update on this. A couple of suggestions:

Please make sure that the feature works when using right-click-select
Do not switch cursor to the 4 arrows when transforming the edges of a clip

Thanks for the update on this. A couple of suggestions: * Please make sure that the feature works when using right-click-select * Do not switch cursor to the 4 arrows when transforming the edges of a clip

👍 1

Richard Antalik added 1 commit 2023-09-22 00:07:43 +02:00

d23c3b8fdf fix compile error

Richard Antalik added 1 commit 2023-09-22 00:10:00 +02:00

cb0d7feeba Fix build warning. Result of merge conflict

Richard Antalik added 3 commits 2023-11-18 01:35:50 +01:00

919daf85b3 Merge branch 'main' into tweak-experiment

689e373d07 Split timeline and preview tool keymaps

6da0c573e2 Change RCS tweak tool keymap, add `handles_only` prop to select OP, make `anim.change_frame` passthrough when clicking on handles

Richard Antalik added 2 commits 2023-11-20 05:54:17 +01:00

4fad3ea60b Merge branch 'main' into tweak-experiment

buildbot/vexp-code-patch-coordinator Build done. Details

4c71bd35ec Fix Box selec not working

Richard Antalik commented

2023-11-20 06:03:24 +01:00

@fsiddi Chat is down so will respond here - will kick the bot, just wanted to do some fixes. There is still minor discrepancy on how transform works when you use right and left mouse button. LMB in RCS works as expected, all other modes won't deselect neighboring handle when moving only one of them. Will fix that.

With modified keymap, this feature can be optional as we wanted, but there will be some weird items that are basically blocked by select and frame change operator. It is bit more readable now, but still worth documenting

@blender-bot package

@fsiddi Chat is down so will respond here - will kick the bot, just wanted to do some fixes. There is still minor discrepancy on how transform works when you use right and left mouse button. LMB in RCS works as expected, all other modes won't deselect neighboring handle when moving only one of them. Will fix that. With modified keymap, this feature can be optional as we wanted, but there will be some weird items that are basically blocked by select and frame change operator. It is bit more readable now, but still worth documenting @blender-bot package

Blender Bot commented

2023-11-20 06:03:27 +01:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.

tintwotin commented

2023-11-21 09:13:52 +01:00

First-time contributor

As noted above, when selecting/transforming two adjoined handles, the selected handle on one of the sides is not visible(looks like the outline).
https://projects.blender.org/blender/blender/attachments/b80eb3f9-6054-4c1c-b60f-96af62c0e353 Both selected handles should be visible.

As the mouse cursor should illustrate what happens when the user is clicking, when two adjoined handles are selected, the mouse cursor should not be changed to single side transform, since this in not what will happen:

During a transform operation, the mouse cursor is changed from the handle cursor to n/s/e/w cursor. Imo, it should stay as handle cursor.

The little arrow on the single sided handle cursor seems redundant, and even misleading, as if you only can move the handle one direction?

There could also be a hot zone in the middle of a strip for the Slip operation and the mouse cursor could look like this: [ ]

As noted above, when selecting/transforming two adjoined handles, the selected handle on one of the sides is not visible(looks like the outline). https://projects.blender.org/blender/blender/attachments/b80eb3f9-6054-4c1c-b60f-96af62c0e353 Both selected handles should be visible. As the mouse cursor should illustrate what happens when the user is clicking, when two adjoined handles are selected, the mouse cursor should not be changed to single side transform, since this in not what will happen: ![trim_cursor_adjoined.gif](/attachments/3b573775-a6d3-433a-8b7c-af2d953bfb21) During a transform operation, the mouse cursor is changed from the handle cursor to n/s/e/w cursor. Imo, it should stay as handle cursor. The little arrow on the single sided handle cursor seems redundant, and even misleading, as if you only can move the handle one direction? There could also be a hot zone in the middle of a strip for the Slip operation and the mouse cursor could look like this: [ ]

trim_cursor_adjoined.gif

20 KiB

Richard Antalik added 2 commits 2023-12-01 17:38:33 +01:00

f011f1f1af Merge branch 'main' into tweak-experiment

9cf0dc9f67 Draw handle cursor when transforming

Richard Antalik added 1 commit 2023-12-01 18:37:09 +01:00

6617193696 Add this feature to preferences

Richard Antalik changed title from ~~WIP: VSE handle drawing/tweaking experiment~~ to VSE handle drawing/tweaking experiment

2023-12-01 18:41:12 +01:00

Richard Antalik commented

2023-12-01 19:26:29 +01:00

Seems, that handle size is sometimes drawn as 5px, sometimes as 4px. Will rebase this patch and check how this can be resolved. In meanwhile, will just increase handle width so I don't mix fixes in this patch.

Richard Antalik added 1 commit 2023-12-01 19:28:46 +01:00

buildbot/vexp-code-patch-coordinator Build done. Details

a74c28d31d Increase handle size by 1px due to imprecision in drawing

Richard Antalik commented

2023-12-01 19:32:52 +01:00

@blender-bot package

Blender Bot commented

2023-12-01 19:32:55 +01:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR109522) when ready.

tintwotin commented

2023-12-01 20:19:27 +01:00

First-time contributor

Seems, that handle size is sometimes drawn as 5px, sometimes as 4px. Will rebase this patch and check how this can be resolved. In meanwhile, will just increase handle width so I don't mix fixes in this patch.

The multiple challenges of thin handles were already addressed here:
https://archive.blender.org/developer/differential/0010/0010297/index.html

This imprecise drawing of the line width, make thin handles disappear and blend in with the outline. A solution to this in the above link was to either select outlines or handles, and never both. When you think about it, there is no reason for having both selected. And not having the outline selected when a handle is selected makes the handle stand out.

Another problem is the two adjoined handles may look like one, to solve this problem, a separating line was introduced, and with bracket shapes added, made it very clear in what direction the handle went (and what strip the handle belonged to).

In addition to these challenges, when zoomed out in the timeline, the handles become very small and potentially invisible(especially when they're thin to begin with) - has this been dealt with in this patch?

Since there are no replies to any of my comments above, I wonder if the addressed problems are not considered problems, or what is going on here?

> Seems, that handle size is sometimes drawn as 5px, sometimes as 4px. Will rebase this patch and check how this can be resolved. In meanwhile, will just increase handle width so I don't mix fixes in this patch. The multiple challenges of thin handles were already addressed here: https://archive.blender.org/developer/differential/0010/0010297/index.html This imprecise drawing of the line width, make thin handles disappear and blend in with the outline. A solution to this in the above link was to either select outlines or handles, and never both. When you think about it, there is no reason for having both selected. And not having the outline selected when a handle is selected makes the handle stand out. Another problem is the two adjoined handles may look like one, to solve this problem, a separating line was introduced, and with bracket shapes added, made it very clear in what direction the handle went (and what strip the handle belonged to). In addition to these challenges, when zoomed out in the timeline, the handles become very small and potentially invisible(especially when they're thin to begin with) - has this been dealt with in this patch? Since there are no replies to any of my comments above, I wonder if the addressed problems are not considered problems, or what is going on here?

Richard Antalik commented

2023-12-02 19:25:11 +01:00

Seems, that handle size is sometimes drawn as 5px, sometimes as 4px. Will rebase this patch and check how this can be resolved. In meanwhile, will just increase handle width so I don't mix fixes in this patch.

The multiple challenges of thin handles were already addressed here:
https://archive.blender.org/developer/differential/0010/0010297/index.html

This imprecise drawing of the line width, make thin handles disappear and blend in with the outline. A solution to this in the above link was to either select outlines or handles, and never both. When you think about it, there is no reason for having both selected. And not having the outline selected when a handle is selected makes the handle stand out.

Makes sense, will try that.

Another problem is the two adjoined handles may look like one, to solve this problem, a separating line was introduced, and with bracket shapes added, made it very clear in what direction the handle went (and what strip the handle belonged to).

I think, that having black outline visible when handle is selected may be necessary, since both strips share that pixel as start/end.

In addition to these challenges, when zoomed out in the timeline, the handles become very small and potentially invisible(especially when they're thin to begin with) - has this been dealt with in this patch?

Don't think, that this is an issue really. Currently it is not possible to select handles when they are too small and I did not change it here.

Since there are no replies to any of my comments above, I wonder if the addressed problems are not considered problems, or what is going on here?

This started with simple goal - to draw cursor when hovering over handle + to make them slimmer. More changes I would rather separate unless they are necessary for functionality.

> > Seems, that handle size is sometimes drawn as 5px, sometimes as 4px. Will rebase this patch and check how this can be resolved. In meanwhile, will just increase handle width so I don't mix fixes in this patch. > > The multiple challenges of thin handles were already addressed here: > https://archive.blender.org/developer/differential/0010/0010297/index.html > > This imprecise drawing of the line width, make thin handles disappear and blend in with the outline. A solution to this in the above link was to either select outlines or handles, and never both. When you think about it, there is no reason for having both selected. And not having the outline selected when a handle is selected makes the handle stand out. Makes sense, will try that. > Another problem is the two adjoined handles may look like one, to solve this problem, a separating line was introduced, and with bracket shapes added, made it very clear in what direction the handle went (and what strip the handle belonged to). I think, that having black outline visible when handle is selected may be necessary, since both strips share that pixel as start/end. > In addition to these challenges, when zoomed out in the timeline, the handles become very small and potentially invisible(especially when they're thin to begin with) - has this been dealt with in this patch? Don't think, that this is an issue really. Currently it is not possible to select handles when they are too small and I did not change it here. > Since there are no replies to any of my comments above, I wonder if the addressed problems are not considered problems, or what is going on here? This started with simple goal - to draw cursor when hovering over handle + to make them slimmer. More changes I would rather separate unless they are necessary for functionality.

buildbot/vexp-code-patch-coordinator Build done.

Details

This pull request has changes conflicting with the target branch.

source/blender/blenloader/intern/versioning_userdef.cc
source/blender/editors/space_sequencer/sequencer_select.cc
source/blender/editors/space_sequencer/sequencer_timeline_draw.cc

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u tweak-experiment:iss-tweak-experiment

git checkout iss-tweak-experiment

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

VSE handle drawing/tweaking experiment #109522

Checkout