Fix #109886: Win32 AutoFocus Between Main Windows #109946

Harley Acheson · 2023-07-11T01:18:13+02:00

Harley Acheson commented

2023-07-11 01:18:13 +02:00

Allow auto-focusing between multiple parent (main) windows when they
are immediately adjacent.

Issue #109886 describes a lack of auto-focus between main windows when they are full-screen on multiple adjacent monitors.

But this issue isn't really related to windows being full-screen or when on multiple monitors. It is most easily replicated like this:

Start Blender and resize its window until it is smaller than half the width of your monitor.
From the top menus select Window / New Main Window
Move the two windows until they are next to each other.

If they are closer than about 20 pixels they won't auto-focus.

We allow auto-focusing between multiple main (parent) windows as long as they don't overlap. Unfortunately our test for overlapping is a bit sus. Since Vista the Windows API call GetWindowRect now includes the area occupied by the drop shadow that is beyond the window bounds. Because we are using a rectangle larger than the window the two windows can be quite far apart and test as overlapping.

This PR just uses a different Windows API call that returns the actual window bounds instead.

Allow auto-focusing between multiple parent (main) windows when they are immediately adjacent. --- Issue #109886 describes a lack of auto-focus between main windows when they are full-screen on multiple adjacent monitors. But this issue isn't really related to windows being full-screen or when on multiple monitors. It is most easily replicated like this: * Start Blender and resize its window until it is _smaller than half the width of your monitor_. * From the top menus select **Window / New Main Window** * Move the two windows until they are next to each other. If they are closer than about 20 pixels they won't auto-focus. We allow auto-focusing between multiple main (parent) windows as long as they don't overlap. Unfortunately our test for overlapping is a bit sus. Since Vista the Windows API call GetWindowRect now includes the area occupied by the **drop shadow** that is beyond the window bounds. Because we are using a rectangle larger than the window the two windows can be quite far apart and test as overlapping. This PR just uses a different Windows API call that returns the actual window bounds instead.

❤️ 1

Harley Acheson added 1 commit 2023-07-11 01:18:25 +02:00

Fix #109886 : Win32 AutoFocus Between Main Windows bdc44e4bee

Allow auto-focusing between multiple parent (main) windows when they
are immediately adjacent.

Harley Acheson added this to the Platforms, Builds Tests & Devices project 2023-07-11 01:19:28 +02:00

Harley Acheson requested review from Ray molenkamp 2023-07-11 01:19:35 +02:00

Ray molenkamp commented

2023-07-11 06:23:46 +02:00

I can't test this as i'm single monitor only, but can you validate monitors with different DPI's work as expected?

https://stackoverflow.com/questions/49002910/why-does-dwmgetwindowattribute-with-dwmwa-extended-frame-bounds-behave-unexpecte

seems to imply some dpi magic may be at play, depending on if we opted in to be dpi aware or not.

I can't test this as i'm single monitor only, but can you validate monitors with different DPI's work as expected? https://stackoverflow.com/questions/49002910/why-does-dwmgetwindowattribute-with-dwmwa-extended-frame-bounds-behave-unexpecte seems to imply some dpi magic may be at play, depending on if we opted in to be dpi aware or not.

Harley Acheson commented

2023-07-11 17:32:23 +02:00

@LazyDodo - can you validate monitors with different DPI's work as expected?

They do. I was also expecting some DPI nonsense, so put two of my monitors in different scales (100% and 125%) and tested two main windows in various locations. They worked as expected when entirely on each monitor and in all variations of having some or all of each on each monitor.

I think the warnings about DPI are related to similar warnings about the function not working correctly if the window is not visible and/or not shown at least once, which doesn't apply here. So it doesn't (like many of their functions) have the ability to guess the size of non-client areas before the window is drawn. I have read (although not confirmed) that this function is used by PrintScreen since Vista to capture windows without the shadow space.

> @LazyDodo - can you validate monitors with different DPI's work as expected? They do. I was also expecting some DPI nonsense, so put two of my monitors in different scales (100% and 125%) and tested two main windows in various locations. They worked as expected when entirely on each monitor and in all variations of having some or all of each on each monitor. I think the warnings about DPI are related to similar warnings about the function not working correctly if the window is not visible and/or not shown at least once, which doesn't apply here. So it doesn't (like many of their functions) have the ability to guess the size of non-client areas before the window is drawn. I have read (although not confirmed) that this function is used by PrintScreen since Vista to capture windows without the shadow space.

Ray molenkamp approved these changes 2023-07-11 19:31:35 +02:00

Ray molenkamp left a comment

allright then!