Fix #109928: issues adding rigid bodies via just the world collection #109961

Philipp Oeser · 2023-07-11T10:59:09+02:00

Philipp Oeser commented

2023-07-11 10:59:09 +02:00

Selecting a rigid body world collection is supposed to set up rigid
bodies for all of its mesh members (if they are not rigid bodies
already), expected result would be just the same as if Object > Rigid Body > Add ... was used.

Doing it via just the world collection had the following issues though:

calculating mass would crash on such a freshly created rigid body
objects (be1b32e4e4 falsely assumed ob->rigidbody_object is always
present on evaluated objects -- without tagging for depsgraph updates
this is not the case though)
rigid body simulation would not work even on these freshly created
rigid body objects

Now tag bmain relations and object transforms for update to make both of
these work (following code in BKE_rigidbody_add_object that is used
when adding these through Object > Rigid Body > Add ...)

Selecting a rigid body world collection is supposed to set up rigid bodies for all of its mesh members (if they are not rigid bodies already), expected result would be just the same as if `Object` > `Rigid Body` > `Add ...` was used. Doing it via just the world collection had the following issues though: - calculating mass would crash on such a freshly created rigid body objects (be1b32e4e49e falsely assumed `ob->rigidbody_object` is always present on evaluated objects -- without tagging for depsgraph updates this is not the case though) - rigid body simulation would not work even on these freshly created rigid body objects Now tag bmain relations and object transforms for update to make both of these work (following code in `BKE_rigidbody_add_object` that is used when adding these through `Object` > `Rigid Body` > `Add ...`)

Philipp Oeser added 1 commit 2023-07-11 10:59:21 +02:00

31baa8d856 Fix #109928 : issues adding rigid bodies via just the world collection

Selecting a rigid body world collection is supposed to set up rigid
bodies for all of its mesh members (if they are not rigid bodies
already), expected result would be just the same as if `Object` > `Rigid
Body` > `Add ...` was used.

Doing it via just the world collection had the following issues though:
- calculating mass would crash on such a freshly created rigid body
objects (be1b32e4e4 falsely assumed `ob->rigidbody_object` is always
present on evaluated objects -- without tagging for depsgraph updates
this is not the case though)
- rigid body simulation would not work even on these freshly created
rigid body objects

Now tag bmain relations and object transforms for update to make both of
these work (following code in `BKE_rigidbody_add_object` that is used
when adding these through `Object` > `Rigid Body` > `Add ...`)

Philipp Oeser added this to the Nodes & Physics project 2023-07-11 10:59:29 +02:00

Philipp Oeser added the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix #109928: issues adding rigid bodies via just the world collection #109961