Cycles: Cleanup: Move SVM execution state into a helper struct #110443

Lukas Stockner · 2023-07-25T04:00:08+02:00

Lukas Stockner commented

2023-07-25 04:00:08 +02:00

This packs the SVM stack, current node offset and closure weight into one struct, and just passes that to each SVM node implementation.

This way we don't have to pass the offset back and forth all over the place, and adding additional state (e.g. for layering in the future) becomes easier.

This packs the SVM stack, current node offset and closure weight into one struct, and just passes that to each SVM node implementation. This way we don't have to pass the offset back and forth all over the place, and adding additional state (e.g. for layering in the future) becomes easier.

Lukas Stockner added 1 commit 2023-07-25 04:00:21 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

2931602812 Cycles: Cleanup: Move SVM execution state into a helper struct

This way we don't have to pass the offset all over the place, and
adding additional state (e.g. for layering in the future) becomes
easier.

Lukas Stockner added this to the Render & Cycles project 2023-07-25 04:00:27 +02:00

Lukas Stockner added the

Module

Render & Cycles

label 2023-07-25 04:00:33 +02:00

Lukas Stockner requested review from Brecht Van Lommel 2023-07-25 04:00:38 +02:00

Lukas Stockner referenced this pull request

2023-07-25 04:06:20 +02:00

WIP: Cycles: Implement BSDF layering #110444

Brecht Van Lommel commented

2023-07-25 20:09:15 +02:00

This seems reasonable, though perhaps there might be a performance impact from this. In theory it should be fine as compiler should not need to pass around more state or do more pointer indirections than before.

@blender-bot package

This seems reasonable, though perhaps there might be a performance impact from this. In theory it should be fine as compiler should not need to pass around more state or do more pointer indirections than before. @blender-bot package

Blender Bot commented

2023-07-25 20:09:18 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR110443) when ready.

Brecht Van Lommel approved these changes 2023-07-25 20:09:42 +02:00

Brecht Van Lommel left a comment

Accepting assuming the build passes.

Thomas Dinges commented

2024-02-09 23:26:11 +01:00

Wondering what happened with this patch? @LukasStockner Is this this valid, or have there been performance concerns?

buildbot/vexp-code-patch-coordinator Build done.

Details

This pull request has changes conflicting with the target branch.

intern/cycles/kernel/svm/camera.h
intern/cycles/kernel/svm/closure.h
intern/cycles/kernel/svm/displace.h
intern/cycles/kernel/svm/gamma.h
intern/cycles/kernel/svm/invert.h
intern/cycles/kernel/svm/musgrave.h
intern/cycles/kernel/svm/noisetex.h
intern/cycles/kernel/svm/normal.h
intern/cycles/kernel/svm/sepcomb_color.h
intern/cycles/kernel/svm/sepcomb_hsv.h

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u svm-state:LukasStockner-svm-state

git checkout LukasStockner-svm-state

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Cycles: Cleanup: Move SVM execution state into a helper struct #110443

Checkout