GPv3: Select frames by column #110523
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#110523
Loading…
Reference in New Issue
No description provided.
Delete Branch "amelief/blender:gpv3-keyframes-column-select"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Implementation of column-based operators : "Columns on selected keys", "Column on current frame", and "Columns on selected markers" for grease pencil frames in the dopesheet.
@ -74,0 +77,4 @@
BLI_assert((ked != nullptr));
CfraElem *ce;
ce = static_cast<CfraElem *>(MEM_callocN(sizeof(CfraElem), "CfraElem"));
MEM_cnew<CfraElem>(__func__)
?b37e486918
to3ead10ead2
3ead10ead2
to185ca1db85
First review pass.
@ -70,6 +70,28 @@ bool layer_has_any_frame_selected(const bke::greasepencil::Layer *layer)
return false;
}
static void frame_to_cfraelem(KeyframeEditData *ked, const int frame_number)
maybe
append_selected_frame_to_key_edit_data
?@ -72,1 +72,4 @@
static void frame_to_cfraelem(KeyframeEditData *ked,
const int frame_number,
const GreasePencilFrame &frame)
The assert can be removed. Already checked by the caller.
@ -73,0 +75,4 @@
const GreasePencilFrame &frame)
{
BLI_assert((ked != nullptr));
CfraElem *ce;
CfraElem *ce = MEM_cnew<CfraElem>(__func__);
@ -73,0 +81,4 @@
ce->cfra = float(frame_number);
ce->sel = frame.is_selected();
BLI_addtail(&(ked->list), ce);
}
maybe
create_keyframe_edit_data_selected_frames_list
? Long but at least more descriptive 😅Yes. I don't think this function is gonna be used anywhere else anyways. 😅
@ -73,0 +83,4 @@
BLI_addtail(&(ked->list), ce);
}
void make_cfralist_selected_frames(KeyframeEditData *ked, const bke::greasepencil::Layer *layer)
Remove double
()
.@ -1081,3 +1081,3 @@
for (ale = static_cast<bAnimListElem *>(anim_data.first); ale; ale = ale->next) {
ED_gpencil_layer_make_cfra_list(static_cast<bGPDlayer *>(ale->data), &ked.list, true);
if (U.experimental.use_grease_pencil_version3) {
I think we should be checking the object type here instead of using the experimental flag.
Two more comments.
@ -73,0 +86,4 @@
BLI_assert(ked != nullptr);
for (const auto &[frame_number, frame] : layer->frames().items()) {
if (frame.is_selected()) {
Is this check needed now that above you set
ce->sel = frame.is_selected();
?Yes, because in this function we want to build the list of frame that are selected. So we only want to call the function above for frames that are indeed selected.
Now that I think of it,
append_selected_frame_to_key_edit_data
should be calledappend_frame_to_key_edit_data
, because this one does not care if the frame is selected or not.@ -1084,0 +1091,4 @@
break;
default:
/* Invalid channel type. */
BLI_assert(0);
Use
BLI_assert_unreachable();
.Looks good 👍
83aa04b07d
toe7efeea9da