EEVEE Next: Volumes: Lighting integration improvements #110809

Miguel Pozo · 2023-08-04T19:23:18+02:00

Miguel Pozo commented

2023-08-04 19:23:18 +02:00

Add the features missing from #107176

Irradiance integration.
Self-shadows.
Receive shadows from shadow maps.

Shadow tagging works by iterating all the froxels in a compute shader and tagging the exact same position that will be sampled by the volume scatter shader.
Froxels that are fully transmissive, have no scattering, or are behind opaque geometry, are skipped.

It also adds a LoD bias parameter for shadow tagging, driven by the volumetric tile size.
This works for punctual shadows, but directional lights would need a way to support re-direction between levels at sampling time, which is out of the scope of this PR.

Add the features missing from #107176 * Irradiance integration. * Self-shadows. * Receive shadows from shadow maps. Shadow tagging works by iterating all the froxels in a compute shader and tagging the exact same position that will be sampled by the volume scatter shader. Froxels that are fully transmissive, have no scattering, or are behind opaque geometry, are skipped. It also adds a LoD bias parameter for shadow tagging, driven by the volumetric tile size. This works for punctual shadows, but directional lights would need a way to support re-direction between levels at sampling time, which is out of the scope of this PR.

❤️ 1

Miguel Pozo added 4 commits 2023-08-04 19:23:26 +02:00

b4d4c0a905 Irradiance

cdb5567674 Volume self-shadows

4fe196b9ff Volume receive shadows

7ad97d8222 Disable shadow tagging for unlit froxels

Miguel Pozo added the

Module

EEVEE & Viewport

label 2023-08-04 19:23:37 +02:00

Miguel Pozo added this to the EEVEE & Viewport project 2023-08-04 19:23:43 +02:00

Miguel Pozo requested review from Clément Foucault 2023-08-04 19:23:52 +02:00

Miguel Pozo referenced this pull request

2023-08-04 19:25:42 +02:00

EEVEE Next: Volumes: Lighting integration improvements #110653

Clément Foucault requested changes 2023-08-16 18:01:35 +02:00

source/blender/draw/engines/eevee_next/shaders/eevee_lightprobe_eval_lib.glsl Outdated

						
				@ -6,6 +6,7 @@

				 * - irradiance_atlas_tx

				 */

				#pragma BLENDER_REQUIRE(gpu_shader_codegen_lib.glsl)

Clément Foucault commented

2023-08-16 17:56:26 +02:00

Not sure what this has to do with the patch.

Miguel Pozo commented

2023-08-21 16:38:18 +02:00

It's simply that gpu_shader_codegen_lib is required by eevee_lightprobe_eval_lib, since it needs the Closure structs declared.
I think it's best if files handle their own dependencies, unless there's a good reason not to do so.
If that's the case the import could be moved to eevee_volume_scatter_comp.

It's simply that `gpu_shader_codegen_lib` is required by `eevee_lightprobe_eval_lib`, since it needs the Closure structs declared. I think it's best if files handle their own dependencies, unless there's a good reason not to do so. If that's the case the import could be moved to `eevee_volume_scatter_comp`.

Clément Foucault commented

2023-08-21 16:50:55 +02:00

Ok fine then.

fclem marked this conversation as resolved

source/blender/draw/engines/eevee_next/shaders/eevee_shadow_lib.glsl Outdated

						
				@ -82,6 +82,10 @@ mat4x4 shadow_load_normal_matrix(LightData light)

				 * match the surface. */

				float shadow_slope_bias_get(vec2 atlas_size, LightData light, vec3 lNg, vec3 lP, vec2 uv, uint lod)

				{

				  if (lNg == vec3(0)) {

Clément Foucault commented

2023-08-16 17:55:05 +02:00

Prefer a define. Also avoid these vector comparison. They are not portable. Use is_equal instead.

Prefer a define. Also avoid these vector comparison. They are not portable. Use `is_equal` instead.

pragma37 marked this conversation as resolved

source/blender/draw/engines/eevee_next/shaders/eevee_volume_lib.glsl Outdated

						
				@ -122,3 +116,3 @@

				#if 0 && defined(VOLUME_SHADOW)

				  vec4 l_vector = vec4(L * l_dist, l_dist);

				#  if 0

Clément Foucault commented

2023-08-16 17:58:51 +02:00

Always add comment on #if 0 block to state why it is commented.

Always add comment on `#if 0` block to state why it is commented.

pragma37 marked this conversation as resolved

source/blender/draw/engines/eevee_next/shaders/eevee_volume_lib.glsl Outdated

						
				@ -142,2 +136,3 @@

				  L = l_vector.xyz / volumes_info_buf.shadow_steps;

				  if (ld.type == LIGHT_SUN) {

				  if (ld.type <= LIGHT_SUN_ORTHO) {