Fix #109201: Consistent mapping boundaries of brush textures #110896

Sergey Sharybin · 2023-08-07T15:58:22+02:00

Sergey Sharybin commented

2023-08-07 15:58:22 +02:00

This fix makes it so the circular brush is fitted into the square
texture. This seems to be the most straightforward way to resolve
confusion of the inter-dependencies between different brush and
texture options.

This fix makes it so the circular brush is fitted into the square texture. This seems to be the most straightforward way to resolve confusion of the inter-dependencies between different brush and texture options.

Sergey Sharybin added the

Module

Sculpt, Paint & Texture

label 2023-08-07 15:58:22 +02:00

Sergey Sharybin added 1 commit 2023-08-07 15:58:32 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

945098ebd6 Fix #109201 : Consistent mapping boundaries of brush textures

This fix makes it so the circular brush is fitted into the square
texture. This seems to be the most straightforward way to resolve
confusion of the inter-dependencies between different brush and
texture options.

Sergey Sharybin commented

2023-08-07 15:58:40 +02:00

@blender-bot package

Blender Bot commented

2023-08-07 15:58:42 +02:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR110896) when ready.

Sergey Sharybin requested review from Daniel Bystedt 2023-08-07 15:59:01 +02:00

Sergey Sharybin requested review from Julien Kaspar 2023-08-07 15:59:01 +02:00

Sergey Sharybin commented

2023-08-07 16:00:50 +02:00

The way to solve the problem is based on what Julien mentioned to me here at the studio. We did a quick test already, and it seemed to behave as expected to him.

However, please give it a whirl after the builds are up to verify it is indeed at the state we want things to be for 4.0.

P.S. The Solution section in the bug report might need to be updated, as no defaults are to be changed.

The way to solve the problem is based on what Julien mentioned to me here at the studio. We did a quick test already, and it seemed to behave as expected to him. However, please give it a whirl after the builds are up to verify it is indeed at the state we want things to be for 4.0. P.S. The Solution section in the bug report might need to be updated, as no defaults are to be changed.

👍 2

Julien Kaspar commented

2023-08-07 18:17:13 +02:00

I've tested it with all brushes that support the tip roundness setting (Clay Strips & Paint). Overall this seems to fix the core issue.

There are some strange issues at the boundary of the brush falloff where the texture scale is jumping and the geometry is not properly updating the deformation/painting.

I've used a simple texture mask (white square with grey margin) to test how well the square is mapped into the surfaces.

The Clay Strips brush has some artefacts when the tip roundness is high:

The paint brush on the other hand has issues with a low tip roundness:

I've tested it with all brushes that support the tip roundness setting (Clay Strips & Paint). Overall this seems to fix the core issue. There are some strange issues at the boundary of the brush falloff where the texture scale is jumping and the geometry is not properly updating the deformation/painting. I've used a simple texture mask (white square with grey margin) to test how well the square is mapped into the surfaces. The Clay Strips brush has some artefacts when the tip roundness is high: ![image](/attachments/66003c5f-447b-4bb0-8db4-30aa0e440be2) The paint brush on the other hand has issues with a low tip roundness: ![image](/attachments/b2d3ef59-5a87-4474-8be3-d5e33e1a78d9)

image.png

534 KiB

image.png

458 KiB

Daniel Bystedt commented

2023-08-08 00:53:21 +02:00

Thanks a lot for the change with the mapping of textures, @Sergey. It work a lot better now :-)

A later, important goal would be to have the tip roundness option on most brushes in sculpt mode - especially sculpt draw, but also the draw brush in texture mode. The goal is to be able to "stamp" an entire square texture with anchored stroke.

Jumping texture mapping with clay tubes and tip roundness = 1

I found the similair issue that @JulienKaspar highlighted above. Mapping kind of jumps with the following settings. It seems to be Tip roundness with the clay strips brush that is causing the issue

tip roundness = > 0
mapping = Area plane
stroke method = Anchored

This does not seem to be happening with the sculpt mode paint brush, so it seems to be related to the clay strips brush somehow.

Fixing this issue would be all for me to accept this patch

See attached video Jumping mapping with high tip roundness

Randomly found bug with multires + clay anchor overdraw

On "overscale" anchored stroke and then rescale, artefacts are created. This seems to only happen when using the multires modifier. This only seem to happen with clay or clay tubes + multires. Not with draw + multires for example. I have replicated this issue in Blender 3.6 so it has nothing to do with this patch

See attached video Clay tubes multires overdraw bug

I cannot replicate @JulienKaspar s issue with "The paint brush on the other hand has issues with a low tip roundness:" During my tests the paint brush works as excpected.

Thanks a lot for the change with the mapping of textures, @Sergey. It work a lot better now :-) A later, important goal would be to have the tip roundness option on most brushes in sculpt mode - especially sculpt `draw`, but also the `draw brush` in `texture mode`. The goal is to be able to "stamp" an entire square texture with anchored stroke. __________________ **Jumping texture mapping with clay tubes and tip roundness = 1** I found the similair issue that @JulienKaspar highlighted above. Mapping kind of jumps with the following settings. It seems to be `Tip roundness` with the `clay strips` brush that is causing the issue tip roundness = > 0 mapping = Area plane stroke method = Anchored This does not seem to be happening with the `sculpt mode paint` brush, so it seems to be related to the `clay strips` brush somehow. **Fixing this issue would be all for me to accept this patch** See attached video `Jumping mapping with high tip roundness` __________________ **Randomly found bug with multires + clay anchor overdraw** On "overscale" anchored stroke and then rescale, artefacts are created. This seems to only happen when using the multires modifier. This only seem to happen with `clay` or `clay tubes` + `multires`. Not with draw + multires for example. I have replicated this issue in Blender 3.6 so it has nothing to do with this patch See attached video `Clay tubes multires overdraw bug` __________________ I cannot replicate @JulienKaspar s issue with "The paint brush on the other hand has issues with a low tip roundness:" During my tests the paint brush works as excpected.

Jumping mapping with high tip roundnes.mp4

5.0 MiB

Clay tubes multires overdraw bug.mp4

5.3 MiB

Daniel Bystedt changed title from ~~Fix #109201: Consistent mapping boundaries of brush textures~~ to WIP: Fix #109201: Consistent mapping boundaries of brush textures

2023-08-08 00:54:18 +02:00

Daniel Bystedt commented

2023-08-08 01:00:34 +02:00

Uploading a lightweight blend file with some brushes with textures in case you find it useful

test sergei sculpt stroke mapping.blend

700 KiB

Sergey Sharybin commented

2023-08-08 15:51:00 +02:00

@DanielBystedt Thanks for testing! I've started looking into the issue from both you and Julien, and came to realization that it is not specific to this patch. The same issue happens in the current Blender 4.0. I did not have time to verify your brush in 3.6, but the repro case from Julien gives artifacts in 3.6 as well.

Juluen submitted an isolated report about his case #110921. I think yours is most likely caused by the same root cause, but maybe worth cross-referencing your findings from this PR in that issue.

Since the issue is not introduced by this PR, and this PR does fix another bug, I would suggest landing it.
And then look into the artifacts as a separate and dedicated investigation. Just to keep a stream of fixes flowing more smoothly to the main branch.

How do you feel about it?

@DanielBystedt Thanks for testing! I've started looking into the issue from both you and Julien, and came to realization that it is not specific to this patch. The same issue happens in the current Blender 4.0. I did not have time to verify your brush in 3.6, but the repro case from Julien gives artifacts in 3.6 as well. Juluen submitted an isolated report about his case #110921. I think yours is most likely caused by the same root cause, but maybe worth cross-referencing your findings from this PR in that issue. Since the issue is not introduced by this PR, and this PR does fix another bug, I would suggest landing it. And then look into the artifacts as a separate and dedicated investigation. Just to keep a stream of fixes flowing more smoothly to the main branch. How do you feel about it?

👍 1

Julien Kaspar approved these changes 2023-08-08 16:13:09 +02:00

Daniel Bystedt commented

2023-08-08 22:55:57 +02:00

@DanielBystedt Thanks for testing! I've started looking into the issue from both you and Julien, and came to realization that it is not specific to this patch. The same issue happens in the current Blender 4.0. I did not have time to verify your brush in 3.6, but the repro case from Julien gives artifacts in 3.6 as well.

Juluen submitted an isolated report about his case #110921. I think yours is most likely caused by the same root cause, but maybe worth cross-referencing your findings from this PR in that issue.

Since the issue is not introduced by this PR, and this PR does fix another bug, I would suggest landing it.
And then look into the artifacts as a separate and dedicated investigation. Just to keep a stream of fixes flowing more smoothly to the main branch.

How do you feel about it?

Thanks for clarifying @Sergey. I'd be more than happy to accept this pull request :-)

> @DanielBystedt Thanks for testing! I've started looking into the issue from both you and Julien, and came to realization that it is not specific to this patch. The same issue happens in the current Blender 4.0. I did not have time to verify your brush in 3.6, but the repro case from Julien gives artifacts in 3.6 as well. > > Juluen submitted an isolated report about his case #110921. I think yours is most likely caused by the same root cause, but maybe worth cross-referencing your findings from this PR in that issue. > > Since the issue is not introduced by this PR, and this PR does fix another bug, I would suggest landing it. > And then look into the artifacts as a separate and dedicated investigation. Just to keep a stream of fixes flowing more smoothly to the main branch. > > > How do you feel about it? Thanks for clarifying @Sergey. I'd be more than happy to accept this pull request :-)

Daniel Bystedt approved these changes 2023-08-08 22:56:21 +02:00

Sergey Sharybin changed title from ~~WIP: Fix #109201: Consistent mapping boundaries of brush textures~~ to Fix #109201: Consistent mapping boundaries of brush textures

2023-08-09 11:39:34 +02:00

Sergey Sharybin merged commit 8141ee90f4 into main

2023-08-09 11:40:05 +02:00

Sergey Sharybin deleted branch fix_109201

2023-08-09 11:40:06 +02:00

Sergey Sharybin referenced this issue from a commit

2023-08-09 11:40:07 +02:00

Fix #109201: Consistent mapping boundaries of brush textures

Almaz-Shinbay referenced this issue from a commit

2023-08-10 18:10:38 +02:00

Fix #109201: Consistent mapping boundaries of brush textures

Philipp Oeser referenced this issue from a commit