Animation: Add channel type options to the Bake Action operator #110903

Colin Basnett · 2023-08-07T21:09:58+02:00

Colin Basnett commented

2023-08-07 21:09:58 +02:00

This allows the user a fine degree of control as to which types of f-curve data will be written to the baked action (i.e., location, rotation, scale & b-bone channels).

Recovered from: https://archive.blender.org/developer/D16481

I have also added the ability to bake custom properties as well, but this is in a separate branch (https://projects.blender.org/cmbasnett/bdk-blender/src/branch/anim-bake-custom-props). When this gets approved, the custom props can be added as well.

This allows the user a fine degree of control as to which types of f-curve data will be written to the baked action (i.e., location, rotation, scale & b-bone channels). ![image](/attachments/3df99405-a712-4319-8cd2-129825847cef) Recovered from: https://archive.blender.org/developer/D16481 I have also added the ability to bake custom properties as well, but this is in a separate branch (https://projects.blender.org/cmbasnett/bdk-blender/src/branch/anim-bake-custom-props). When this gets approved, the custom props can be added as well.

image.png

50 KiB

❤️ 2

Colin Basnett added the

Module

Animation & Rigging

label 2023-08-07 21:09:58 +02:00

Colin Basnett added 1 commit 2023-08-07 21:10:09 +02:00

c8dc0c6a6d Animation: Add channel type options to the Bake Action operator

This allows the user a fine degree of control as to which types of
f-curve data will be written to the baked action (i.e., location,
rotation, scale & b-bone channels).

Brad Clark commented

2023-08-11 07:53:31 +02:00

@ChrisLend just tagging you here since channel level baking is on our meeting discussion list.

Colin Basnett requested review from Sybren A. Stüvel 2023-08-16 08:38:40 +02:00

Colin Basnett requested review from Nathan Vegdahl 2023-08-16 08:39:50 +02:00

Nathan Vegdahl reviewed 2023-08-21 17:54:05 +02:00

Nathan Vegdahl left a comment

What's the rationale for having separate options for location, rotation, and scale vs just having a single "transforms" option?

More generally: short term, this design of just adding more options seems fine. But long-term I feel like we're going to run up against reasonable limits with that, while still not being flexible enough to actually accommodate all reasonable use cases. I'm not sure what the long-term design should look like, but this is just to say that I don't think we should try to accommodate all use cases with this, just the most common ones. Because a fully accommodating design will probably need to be quite different. Maybe based on keying sets, or something like that.

What's the rationale for having separate options for location, rotation, and scale vs just having a single "transforms" option? More generally: short term, this design of just adding more options seems fine. But long-term I feel like we're going to run up against reasonable limits with that, while still not being flexible enough to actually accommodate all reasonable use cases. I'm not sure what the long-term design should look like, but this is just to say that I don't think we should try to accommodate *all* use cases with this, just the most common ones. Because a fully accommodating design will probably need to be quite different. Maybe based on keying sets, or something like that.

scripts/modules/bpy_extras/anim_utils.py

						
				@ -310,0 +325,4 @@

				                keyframes.add_paths(path_axis_angle, 4)

				                keyframes.add_paths(path_euler, 3)

				            if do_scale:

				                keyframes.add_paths(path_scale, 3)

Nathan Vegdahl commented

2023-08-21 17:42:29 +02:00

It looks like all of these keyframes.add_paths(...) in the conditionals are already run unconditionally on lines 314-319. Were those lines meant to be removed?

It looks like all of these `keyframes.add_paths(...)` in the conditionals are already run unconditionally on lines 314-319. Were those lines meant to be removed?

Brad Clark commented

2023-09-06 17:15:32 +02:00

yeah that is good, I would guess it came from people requesting it from cmbasnett but often If I don't have scale keys I don't want scale keys as a result of the bake and especially if I have additive layers...so having transform bake everything all the time with no control is a pain.

This is the bridge to get the custom attribute bake in so that we can use layers and rigify without 1k questions and endless NLA sucks, nothing works, comments on all parts of the internet and installing random addons 🙂
all baking to Nathan Vegdahl point needs a redo/upgrade anyway with then new system but that new stuff doesn't exist and having another release with non-usable baking for a core tool everyone uses to me is why I want his code to land and we can refine the options and control once the new layer system is ready.

yeah that is good, I would guess it came from people requesting it from cmbasnett but often If I don't have scale keys I don't want scale keys as a result of the bake and especially if I have additive layers...so having transform bake everything all the time with no control is a pain. This is the bridge to get the custom attribute bake in so that we can use layers and rigify without 1k questions and endless NLA sucks, nothing works, comments on all parts of the internet and installing random addons 🙂 all baking to Nathan Vegdahl point needs a redo/upgrade anyway with then new system but that new stuff doesn't exist and having another release with non-usable baking for a core tool everyone uses to me is why I want his code to land and we can refine the options and control once the new layer system is ready.

Nate Rupsis commented

2023-09-07 19:01:13 +02:00

Helping land this PR for @BClark & @cmbasnett here: #111997

Helping land this PR for @BClark & @cmbasnett here: https://projects.blender.org/blender/blender/pulls/111997

Nate Rupsis closed this pull request

2023-09-07 19:01:15 +02:00

Nathan Vegdahl referenced this pull request

2023-09-08 11:23:29 +02:00

Anim: Add channel type options to the Bake Action operator #111997