blender-v3.6-release backports #110973

Philipp Oeser · 2023-08-09T18:38:55+02:00

Philipp Oeser commented

2023-08-09 18:38:55 +02:00

No response

_No response_

Philipp Oeser added 10 commits 2023-08-09 18:39:08 +02:00

fbcaf7bf6f Fix (unreported) minor bug in RNA/Liboverride apply code.

The wrong RNA pointers were passed (passing the root ones instead of the
ones actually owning the rna-path-resolved property).

This was likely a harmless mistake, since it only affected RNA
collections of IDs, afaik we currently don't have many (if any) of these
in non-ID RNA structures. The children collections and objects in a
Collection data-block RNA structure e.g. were not affected.

But the potential consequence of that bug would have been missing
automatic detection of some needed liboverride resyncs.

d121ed4755 Fix #110627 : crash on start with Wayland

Older versions of Wayland would crash on startup because of the
requested zwp_pointer_gestures_v1 version.

Resolve by supporting older versions.

acd207794e Fix #110041 : gizmo stuck in place when playing back animation

The new notifier triggers `WM_gizmomap_tag_refresh` in
`view3d_main_region_listener` which makes sure that gizmos
are updated when playback ends.

7180271d56 Fix #110615 : missing GL dev packages in install_linux_packages.py

The build fails without these.

Pull Request: #110609

84734cfe94 Fix #110333 : Sound strip length not correct when opening old file

Commit `c9be925f7d` fixed files for studio, that were saved in incorrect
state. This also attempted to fix unaffected files.
In affected files `seq->startofs` did overflow. Sound strips are not
expected to have negative `startofs` and therefore fix in `c9be925f7d`
can be limited to broken files by checking `startofs` value.

d5bd58db88 Fix #110205 : Separate images not working correctly.

Strip was removed from `seqbase` prior to calling
`SEQ_edit_remove_flagged_sequences()` which resulted in strip not being
actually removed, and it could be seen in timeline while being active.

ffcc828ced Fix #109460 : vertex weight slider not working correctly

#109460 was caused by the introduction of implicit sharing for custom
data layers (7eee378eccc8f87e17). Due to implicit sharing, the vertex
weight layer is now shared between the original and evaluated object in
object/weight paint mode, but not in edit mode because of bmesh. For
that reason, the original data has to be copied to be able to edit it, which
causes its pointer to change. `uiDefButF` can't deal with the situation when
the pointer changes on every redraw.

The solution is to just use an intermediate variable that is passed to the
`uiBut` and to update the vertex weight only when the intermediate value has
changed.

Pull Request: #109665

ec016f7c1b Fix #110821 : Tracker resizing with S+S also resizes search area

Regression caused by 03f17c42d0

In that commit it was assumed that the hotkey modifier `S` had no
influence if we were already resizing.

But this is not the case in tracking. The second `S` has influence and
should not be filtered.

The solution is to add a conditional only to Trackers transformation.

This commit also fixed the canceling of this transformation which did
not revert the search area to its original value.

c426d5b084 Fix (unreported) missing handling of ViewLayer IDProperties in foreach_id code.

Yet another 'obviously' missing bit in foreach_id processing found and fixed.

buildbot/vexp-code-patch-coordinator Build done. Details

455683c838 Fix (unreported) collection 'readfile' expand incorrect assertion.

Naming is bad and confusing, but the 'expander' code path from readfile
can also be used outside of the reading context (see e.g.
`BKE_blendfile_write_partial` code). So code cannot assume that it is
exclusively working on data freshly read from file.

This should be renamed - but should also be probably replaced by
proper usage of the more generic 'foreach_id' code anyway, see #105134.

Found while investigating #109588.

Philipp Oeser commented

2023-08-09 18:39:27 +02:00

@blender-bot build

Philipp Oeser commented

2023-08-09 19:39:24 +02:00

Assume windows compiler wasnt happy about ffcc828ced, will try again without that commit

Assume windows compiler wasnt happy about ffcc828ced3b4256bd4414b8427558d9c37f2214, will try again without that commit

Philipp Oeser added 1 commit 2023-08-09 19:44:43 +02:00

buildbot/vexp-code-patch-coordinator Build done. Details

4b10cbe012 Revert "Fix #109460 : vertex weight slider not working correctly"

This reverts commit ffcc828ced.
Seems Windows buildbot wasnt happy about this (it cherry-picked and built fine on linux)

Philipp Oeser commented

2023-08-09 19:45:20 +02:00

@blender-bot build

Philipp Oeser merged commit 4a3c3a5924 into blender-v3.6-release

2023-08-09 20:12:32 +02:00

Philipp Oeser referenced this issue from a commit

2023-08-09 20:12:33 +02:00

Revert "Fix #109460: vertex weight slider not working correctly"

Philipp Oeser deleted branch blender-v3.6-release

2023-08-09 20:12:34 +02:00

Sign in to join this conversation.

No reviewers

No Label

Asset Browser Project Overview

Development Management

Pipeline, Assets & IO

Interest

Platforms, Builds & Tests

Sculpt, Paint & Texture

Milestone 1: Basic, Local Asset Browser

Development Management

Pipeline, Assets & IO

Module

Platforms, Builds & Tests

Sculpt, Paint & Texture

Needs Info from Developers

Status

Needs Information from User

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#110973

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

blender-v3.6-release backports #110973