UI: Increase Color Picker Size #111153

Harley Acheson · 2023-08-16T00:14:30+02:00

Harley Acheson commented

2023-08-16 00:14:30 +02:00

Increase the Color Picker Size by 33%

The color picker is just a bit too small. This increases the size of it by 33%, in each linear direction so we get a 78% increase in total surface area. Before and after with default startup and Resolution Scale set to 1.0:

Note that we used to be more constrained with this size, because the popup was always rooted to the launching button. This was addressed in #106122 so that it can reposition if needed. Therefore it can be any size now

Note too that this is an alternative to #106135, or possibly a precursor to. It can at least be a convenience in place for now.

Increase the Color Picker Size by 33% --- The color picker is just a bit too small. This increases the size of it by 33%, in each linear direction so we get a 78% increase in total surface area. Before and after with default startup and Resolution Scale set to 1.0: ![image](/attachments/17965feb-0e63-4250-81fa-ba096d2948b5) Note that we used to be more constrained with this size, because the popup was always rooted to the launching button. This was addressed in #106122 so that it can reposition if needed. Therefore it can be any size now Note too that this is an alternative to #106135, or possibly a precursor to. It can at least be a convenience in place for now.

image.png

9.6 KiB

image.png

89 KiB

image.png

116 KiB

👍 2

Harley Acheson added 1 commit 2023-08-16 00:14:39 +02:00

6e86286a75 UI: Increase Color Picker Size

Increase the Color Picker Size by 50%

Harley Acheson added this to the User Interface project 2023-08-16 00:15:04 +02:00

Harley Acheson requested review from Pablo Vazquez 2023-08-16 00:15:11 +02:00

Harley Acheson referenced this pull request

2023-08-16 01:22:20 +02:00

WIP UI: Adjustable Color Picker Size #106135

Pablo Vazquez commented

2023-08-16 01:27:25 +02:00

+1

Feels a bit large at first but I think it is an improvement. It also gives us some room for possibly having more controls in the future, like a color-picker type switch or palettes.

Reference how it looks on a clean build by default on macOS (14" MacBook)

+1 Feels a bit large at first but I think it is an improvement. It also gives us some room for possibly having more controls in the future, like a color-picker type switch or palettes. Reference how it looks on a clean build by default on macOS (14" MacBook) ![image](/attachments/35b7a6b0-9cf3-435c-b522-5025d0edd1cc)

image.png

2.4 MiB

Pablo Vazquez approved these changes 2023-08-16 01:27:36 +02:00

Harley Acheson commented

2023-08-16 01:31:23 +02:00

@pablovazquez - Feels a bit large at first but I think it is an improvement.

It can really be any size at all. If you think it feels a bit big we can always dial it down a bit. In current code it is 150, while in the this PR is 225, chosen completely arbitrarily. We could make it 200, or any other size if you prefer.

> @pablovazquez - Feels a bit large at first but I think it is an improvement. It can really be any size at all. If you think it feels a bit big we can always dial it down a bit. In current code it is 150, while in the this PR is 225, chosen completely arbitrarily. We could make it 200, or any other size if you prefer.

Pablo Vazquez commented

2023-08-16 01:34:53 +02:00

It can really be any size at all. If you think it feels a bit big we can always dial it down a bit. In current code it is 150, while in the this PR is 225, chosen completely arbitrarily. We could make it 200, or any other size if you prefer.

It might be a good compromise. We don't want to make it too large that it gets on the way on small screen sizes. I'll test it tomorrow at the office.

> It can really be any size at all. If you think it feels a bit big we can always dial it down a bit. In current code it is 150, while in the this PR is 225, chosen completely arbitrarily. We could make it 200, or any other size if you prefer. It might be a good compromise. We don't want to make it too large that it gets on the way on small screen sizes. I'll test it tomorrow at the office.

Pablo Vazquez commented

2023-08-16 19:24:21 +02:00

Tested locally. I think 200 is a good compromise until we can get them to be resizable.
The widget is much larger but not too large for small screens, and sliders don't feel too wide like they do at 225.

Left: 225
Middle: 200
Right: main (150)

@Harley if you could please update the patch for PICKER_TOTAL_W to be 200.0f * UI_SCALE_FAC it can be committed without further review. Thanks!

Tested locally. I think 200 is a good compromise until we can get them to be resizable. The widget is much larger but not too large for small screens, and sliders don't feel too wide like they do at 225. Left: 225 Middle: 200 Right: `main` (150) ![image](/attachments/86007c16-b538-48c3-9788-6259738015f9) @Harley if you could please update the patch for `PICKER_TOTAL_W` to be `200.0f * UI_SCALE_FAC` it can be committed without further review. Thanks!

image.png

139 KiB

Harley Acheson commented

2023-08-16 21:54:11 +02:00