UI: Add save button to theme selection UI #111506

Closed

Ludvik Koutny wants to merge 1 commits from Rawalanche/blender:themes-save-button into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Ludvik Koutny commented

2023-08-25 10:27:35 +02:00

Contributor

A new save button is added to the theme selector in User Preferences.

The current process of saving theme modifications in Blender is quite embarrassing. User is required to use a button for adding new theme, and then type in the exact same name of already existing theme. This is poorly discoverable, annoying to use, and error prone.

The new save button asks for confirmation before overwriting the theme:

And doesn't allow overwriting of any of the stock themes:

Small caveat:
When trying to overwrite stock theme, the confirmation dialog will first pop up, and only then the status bar warning appears. Ideally, when trying to overwrite stock theme, the status bar warning would show immediately and the popup would never appear, but that would be at the cost of adding thick chunk of duplicate code into invoke function or having to extract filepath gathering into its own function. Both of these solutions seemed a bit unnecessary.

A new save button is added to the theme selector in User Preferences. ![image](/attachments/77f78500-10c1-48ea-9149-cde02b22c0ed) ----- The current process of saving theme modifications in Blender is quite embarrassing. User is required to use a button for adding new theme, and then type in the exact same name of already existing theme. This is poorly discoverable, annoying to use, and error prone. The new save button asks for confirmation before overwriting the theme: ![image](/attachments/a05991b4-5e86-4746-adbb-f767acad8445) And doesn't allow overwriting of any of the stock themes: ![image](/attachments/52b54cee-72ad-4e08-8faf-085d4bf5b2f4) Small caveat: When trying to overwrite stock theme, the confirmation dialog will first pop up, and only then the status bar warning appears. Ideally, when trying to overwrite stock theme, the status bar warning would show immediately and the popup would never appear, but that would be at the cost of adding thick chunk of duplicate code into invoke function or having to extract filepath gathering into its own function. Both of these solutions seemed a bit unnecessary.

3.4 KiB

5.9 KiB

6.3 KiB

Ludvik Koutny added 1 commit 2023-08-25 10:27:42 +02:00

79689d149e UI: Add save button to theme selection UI

Leon Schittek added this to the User Interface project 2023-08-25 13:13:37 +02:00

Ludvik Koutny added the

label 2023-09-01 11:14:05 +02:00

Julian Eisel commented

2023-09-14 18:03:09 +02:00

Member

I think the confirmation popup makes sense, but the popup looks quite off to me (as in, unusual). I guess this can use one of our existing confirmation popup dialogs, like WM_operator_confirm_message().
Maybe @Harley has some more thoughts (or hints) with regards to his patches for confirmation popups.

I think the confirmation popup makes sense, but the popup looks quite off to me (as in, unusual). I guess this can use one of our existing confirmation popup dialogs, like `WM_operator_confirm_message()`. Maybe @Harley has some more thoughts (or hints) with regards to his patches for confirmation popups.

Harley Acheson requested review from Harley Acheson 2024-03-12 16:38:47 +01:00

Harley Acheson referenced this pull request

2024-03-15 00:43:42 +01:00

UI: Button to Save Custom Themes #119491

Harley Acheson commented

2024-04-03 22:12:55 +02:00

Member

Closing as this functionality was added with #119491.

But thank you very much for working on this as it served to inform the solution put into place.

Closing as this functionality was added with #119491. But thank you very much for working on this as it served to inform the solution put into place.

Harley Acheson closed this pull request

2024-04-03 22:12:59 +02:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#111506

No description provided.