UI: Button to Save Custom Themes #119491

Harley Acheson · 2024-03-15T00:43:42+01:00

Harley Acheson commented

2024-03-15 00:43:42 +01:00

Add a new "Save" to the Themes list in Preferences to save (overwrite)
custom themes. The operator has a poll function to disable for built-in
themes. Shows a confirmation when overwriting.

Offered as an alternative to #111506

New themes can be easily created in Blender: Edit / Preferences / Themes, Presets, "+" button. This prompts for a name and then creates a new theme with the current settings in your profile.

However...

How do you update that theme file after you make changes? Very unintuitively, you click on that "+" again, enter the name of your theme (exactly), then click "OK". In a nutshell you create a new theme with the same name and therefore overwrite the old file with the new settings.

This PR allows you to just click a "Save" button.

Disabled for built-in themes:

Enabled for custom themes:

Confirmation:

Not exactly sure what order these buttons should be in.

Add a new "Save" to the Themes list in Preferences to save (overwrite) custom themes. The operator has a poll function to disable for built-in themes. Shows a confirmation when overwriting. --- Offered as an alternative to #111506 New themes can be easily created in Blender: Edit / Preferences / Themes, Presets, "+" button. This prompts for a name and then creates a new theme with the current settings in your profile. However... How do you update that theme file after you make changes? Very unintuitively, you click on that "+" again, enter the name of your theme (exactly), then click "OK". In a nutshell you create a _new_ theme with the _same name_ and therefore overwrite the old file with the new settings. This PR allows you to just click a "Save" button. Disabled for built-in themes: ![image](/attachments/421e15d7-879c-4b72-974d-69cf631eef39) Enabled for custom themes: ![image](/attachments/2c81b080-1099-4970-acff-bb6f76a92ed8) Confirmation: ![image](/attachments/0b696a99-fc4a-4083-bcc1-f6bbff91807b) Not exactly sure what order these buttons should be in.

image.png

24 KiB

image.png

20 KiB

image.png

24 KiB

image.png

20 KiB

👍 3 ❤️ 8

Harley Acheson added 1 commit 2024-03-15 00:43:53 +01:00

84863f8429 UI: Button to Save Custom Themes

Add a new "Save" to the Themes list in Preferences to save (overwrite)
custom themes. The operator has a poll function to disable for built-in
themes. Shows a confirmation when overwriting.

Harley Acheson added this to the User Interface project 2024-03-15 00:44:30 +01:00

Harley Acheson commented

2024-03-15 00:46:50 +01:00

@Rawalanche

Do you mind taking a look at this?

@Rawalanche Do you mind taking a look at this?

Ludvik Koutny commented

2024-03-15 09:04:42 +01:00

@Rawalanche

Do you mind taking a look at this?

Yes, perfect. I wanted to finish mine, but unfortunately I had to get back to my daily job and then didn't notice Julian's comment. I am thankful you took it over.

> @Rawalanche > > Do you mind taking a look at this? Yes, perfect. I wanted to finish mine, but unfortunately I had to get back to my daily job and then didn't notice Julian's comment. I am thankful you took it over.

Harley Acheson commented

2024-03-15 19:20:01 +01:00

@Rawalanche - I wanted to finish mine...

No worries at all. I had wanted to look at this issue after changing the confirmations.

Not asking you to test this PR if you don't have time. But mostly wanting to make sure I was addressing the issues correctly and am not misunderstanding anything about the problem or your solution.

I am assuming this current lack of a "save" also applies to the keymap editor?

@Rawalanche - I wanted to finish mine... No worries at all. I had wanted to look at this issue after changing the confirmations. Not asking you to test this PR if you don't have time. But mostly wanting to make sure I was addressing the issues correctly and am not misunderstanding anything about the problem or your solution. I am assuming this current lack of a "save" also applies to the keymap editor?

👍 1

Ludvik Koutny commented

2024-03-16 19:23:57 +01:00

@Rawalanche - I wanted to finish mine...

No worries at all. I had wanted to look at this issue after changing the confirmations.

Not asking you to test this PR if you don't have time. But mostly wanting to make sure I was addressing the issues correctly and am not misunderstanding anything about the problem or your solution.

I am assuming this current lack of a "save" also applies to the keymap editor?

I haven't built blender for a few months, before SVN deprecation even, but luckily this is Python only, so I can try to just edit the python files in the release to check it out.

As for the keymap editor, yes, the exactly same problem. Only way to save modified keymap is to use add keymap button and type the exact same name, so save button would be appropriate there as well.

I think there may be few other places where preset management exist and save button is missing, but I can't think of any from the top of my mind.

> @Rawalanche - I wanted to finish mine... > > No worries at all. I had wanted to look at this issue after changing the confirmations. > > Not asking you to test this PR if you don't have time. But mostly wanting to make sure I was addressing the issues correctly and am not misunderstanding anything about the problem or your solution. > > I am assuming this current lack of a "save" also applies to the keymap editor? > I haven't built blender for a few months, before SVN deprecation even, but luckily this is Python only, so I can try to just edit the python files in the release to check it out. As for the keymap editor, yes, the exactly same problem. Only way to save modified keymap is to use add keymap button and type the exact same name, so save button would be appropriate there as well. I think there may be few other places where preset management exist and save button is missing, but I can't think of any from the top of my mind.

Harley Acheson requested review from Pablo Vazquez 2024-03-18 22:29:34 +01:00

Harley Acheson merged commit ee38a7b723 into main

2024-03-27 01:12:01 +01:00

Harley Acheson referenced this issue from a commit

2024-03-27 01:12:01 +01:00

UI: Button to Save Custom Themes

Harley Acheson deleted branch SaveThemeButton

2024-03-27 01:12:03 +01:00

Harley Acheson referenced this pull request

2024-04-03 22:12:56 +02:00

UI: Add save button to theme selection UI #111506

Sign in to join this conversation.