Animation: Shear operator for Graph Editor #111735

Christoph Lendenfeld · 2023-08-31T12:30:43+02:00

2023-08-31 12:30:43 +02:00

This is a combination of two PRs from Ares Deveaux: #106521: Animation: shear left slider and #106522: Animation: shear right slider

This adds a new operator that allows shearing keys based on the position of the segment ends.
By pressing D while the operator is in modal you can switch if the operator takes the left or the right segment end as a reference.

This is a combination of two PRs from Ares Deveaux: [#106521: Animation: shear left slider](https://projects.blender.org/blender/blender/pulls/106521) and [#106522: Animation: shear right slider](https://projects.blender.org/blender/blender/pulls/106522) This adds a new operator that allows shearing keys based on the position of the segment ends. By pressing `D` while the operator is in modal you can switch if the operator takes the left or the right segment end as a reference. <video src="/attachments/d8ba0705-f0cc-40d6-bc15-65ad335333b2" title="Shear Demo" controls></video>

shear_keys 2023-08-31 14-57-57.mp4

1.1 MiB

Christoph Lendenfeld added the

Module

Animation & Rigging

label 2023-08-31 12:30:43 +02:00

Christoph Lendenfeld added 15 commits 2023-08-31 12:30:57 +02:00

6b7c8c5df6 added functions

6b6ea352f2 added a missing space in the description

9c9110cc14 Fixed some formating

2df0da0412 simplified the function a bit

5a62dcd02c By mistake I deleted the solution to not devide by 0, so I put it back

174ddcbeb5 fixed minor change on a description

7f9b1d33e7 use bidirectional slider

5ea5535ca1 simple fix to the "RNA_def_float_factor" in the operator

6b507563d8 Changed the name to "Shear from Left"

40ec7dd8ec Merge branch 'main' into shear_slider

234f008697 resolve merge issues

0b90672ee9 rename to shear keys

90b254861a add enum to shear from left or right

770c36a1bc add D key for switching direction while in modal

f7e43cf826 add hotkey tip in workspace status text

Christoph Lendenfeld requested review from Nathan Vegdahl 2023-08-31 12:32:36 +02:00

Nathan Vegdahl requested changes 2023-08-31 15:35:49 +02:00

Nathan Vegdahl left a comment

The code looks good to me. Just some nits about naming and word usage.

source/blender/editors/animation/keyframes_general.cc Outdated

						
				@ -829,0 +853,4 @@

				      normalized_x = (right_key->vec[1][0] - fcu->bezt[i].vec[1][0]) / key_x_range;

				    }

				    const float lineal = key_y_range * normalized_x;

Nathan Vegdahl commented

2023-08-31 15:26:36 +02:00

Is lineal a typo? Or just a term I'm not familiar with?

Is `lineal` a typo? Or just a term I'm not familiar with?

Christoph Lendenfeld commented

2023-08-31 16:01:30 +02:00

I just kept what ares had. In german this means ruler, but I am not sure that was the original intent

changed to y_delta

I just kept what ares had. In german this means ruler, but I am not sure that was the original intent changed to `y_delta`

source/blender/editors/space_graph/graph_slider_ops.cc Outdated

						
				@ -1293,0 +1448,4 @@

				                       -FLT_MAX,

				                       FLT_MAX,

				                       "Curve Bend",

				                       "Control the bend of the curve",

Nathan Vegdahl commented

2023-08-31 15:35:21 +02:00

Shear is a linear operation, so talking about curves and bending feels misleading to me. When I first read this I honestly thought, "Wait, is there a third parameter that adds curvature on top of the shear?"

Maybe just call this parameter "Shear", and document it as "The amount of shear". I realize that's kind of stupid and redundant, and doesn't really explain things further to people who don't know what shear is. But I don't know if there's a succinct way to explain shear with just words. And it's relatively easy for people to look up if they don't know what it is, which will then provide pictures that do explain it succinctly.

Shear is a linear operation, so talking about curves and bending feels misleading to me. When I first read this I honestly thought, "Wait, is there a third parameter that adds curvature on top of the shear?" Maybe just call this parameter "Shear", and document it as "The amount of shear". I realize that's kind of stupid and redundant, and doesn't really explain things further to people who don't know what shear is. But I don't know if there's a succinct way to explain shear with just words. And it's relatively easy for people to look up if they don't know what it is, which will then provide pictures that do explain it succinctly.

Christoph Lendenfeld commented

2023-08-31 16:00:15 +02:00

good catch. This slipped by me and seems like a copy paste issue. The blend to ease operator has the same description