Fixed_incorrected_translation #112039

Gangneron · 2023-09-06T17:07:26+02:00

Gangneron commented

2023-09-06 17:07:26 +02:00

First-time contributor

I have fixed incorrect translation for Czech, Thai, Kyrgyz and Abkhaz. Tis patch fixed in settings.py and laguages files
correction proposal:
Czech = Čeština instead of Český
Thai = ไทย instead of ภาษาไทย
Kyrgyz = Кыргызча instead of Кыргыз тили
Abkhaz = Аԥсшәа instead of Аԥсуа бызшәа

I have fixed incorrect translation for Czech, Thai, Kyrgyz and Abkhaz. Tis patch fixed in settings.py and laguages files correction proposal: Czech = Čeština instead of Český Thai = ไทย instead of ภาษาไทย Kyrgyz = Кыргызча instead of Кыргыз тили Abkhaz = Аԥсшәа instead of Аԥсуа бызшәа

Gangneron added 2 commits 2023-09-06 17:07:34 +02:00

04c4b4eef3 Fixed incorrect translation

I have fixed incorrect translation for Czech, Thai, Kyrgyz and Abkhaz.
correction proposal:
Czech = Čeština instead of Český
Thai = ไทย instead of ภาษาไทย
Kyrgyz = Кыргызча instead of Кыргыз тили
Abkhaz = Аԥсшәа instead of Аԥсуа бызшәа

0b688aba97 Téléverser les fichiers vers "locale"

Fixed incorrect translation

I have fixed incorrect translation for Czech, Thai, Kyrgyz and Abkhaz. This path fixed in languages file
correction proposal:
Czech = Čeština instead of Český
Thai = ไทย instead of ภาษาไทย
Kyrgyz = Кыргызча instead of Кыргыз тили
Abkhaz = Аԥсшәа instead of Аԥсуа бызшәа

Gangneron changed title from ~~Fixed_incorrected_translation~~ to WIP: Fixed_incorrected_translation

2023-09-06 17:08:33 +02:00

Gangneron changed title from ~~WIP: Fixed_incorrected_translation~~ to Fixed_incorrected_translation

2023-09-06 17:44:01 +02:00

Gangneron requested review from Demeter Dzadik 2023-09-06 17:45:28 +02:00

Gangneron requested review from Chris Blackbourn 2023-09-06 17:45:29 +02:00

Demeter Dzadik commented

2023-09-07 11:44:43 +02:00

Hi, I don't think you meant to add me as a reviewer, I don't work in this area.

Demeter Dzadik refused to review 2023-09-07 11:44:50 +02:00

Gangneron requested review from Bastien Montagne 2023-09-10 10:12:23 +02:00

Bastien Montagne removed review request for Chris Blackbourn 2023-09-11 11:13:47 +02:00

Bastien Montagne requested changes 2023-09-11 11:15:16 +02:00

Bastien Montagne left a comment

Thanks for the patch, but I think something went wrong (likely your 'end of lines' settings are not following the usual UNIX convention?)

Also tagging @pioverfour since he has already been doing some fixes in that regard (the Czech one e.g. has already been corrected in main).

Thanks for the patch, but I think something went wrong (likely your 'end of lines' settings are not following the usual UNIX convention?) Also tagging @pioverfour since he has already been doing some fixes in that regard (the Czech one e.g. has already been corrected in main).

Damien Picard commented

2023-09-11 13:27:50 +02:00

Hi, thanks again but there are still issues.

Firstly, you keep opening new PRs for the same thing, but you do not have to do that, one is enough. Every time you open a new PR, all previous conversation is lost, which is counter-productive and gets frustrating. AFAICT, #109173, #109200, #109759, #112040, and this PR all try to do the same thing, and all suffer from the same issues.

Let me ask you some questions once again:

Have you read the page about contributing on the wiki?
Have you looked into using git? I’m still under the impression that you upload your changes directly through Gitea, which does not work in this case because of the line-ending issue.

Now, you explained that you don’t know if these changes are correct because you don’t speak the languages, but you believe it doesn’t hurt and may attract attention on the issue. I replied that I don’t think this is the right approach, and I’d rather get confirmation from speakers of the affected languages. Again, I made a mistake with Estonian, there could be other mistakes.

So I don’t think we should proceed with this change at this time, but I’m not the one who gets to decide which approach we should take because I’m not going to be merging the code. So I guess it’s really @mont29 ’s call!

Hi, thanks again but there are still issues. Firstly, you keep opening new PRs for the same thing, but you do not have to do that, one is enough. Every time you open a new PR, all previous conversation is lost, which is counter-productive and gets frustrating. AFAICT, #109173, #109200, #109759, #112040, and this PR all try to do the same thing, and all suffer from the same issues. Let me ask you some questions once again: - Have you read the [page about contributing](https://wiki.blender.org/wiki/Process/Contributing_Code) on the wiki? - Have you looked into [using git](https://wiki.blender.org/w/index.php?title=Tools/Git)? I’m still under the impression that you upload your changes directly through Gitea, which does not work in this case because of the line-ending issue. Now, you explained that you don’t know if these changes are correct because you don’t speak the languages, but you believe it doesn’t hurt and may attract attention on the issue. I replied that I don’t think this is the right approach, and I’d rather get confirmation from speakers of the affected languages. Again, I made a mistake with Estonian, there could be other mistakes. So I don’t think we should proceed with this change at this time, but I’m not the one who gets to decide which approach we should take because I’m not going to be merging the code. So I guess it’s really @mont29 ’s call!

Bastien Montagne commented

2023-09-11 14:23:47 +02:00

I would indeed not accept changes if there is not 100% insurance that they are valid - history of this issue has already proven well enough that it is (surprisingly) not trivial to find the proper name of a language in its original form...

Gangneron commented

2023-09-11 18:33:18 +02:00

First-time contributor

I have already tried using git but without success. I had tried to modify files then upload them to no avail... Another thing, I already have the doc several times and I refer to the documentation each time I need it. However, I still haven't found a method, whether online or graphical, to remove bad versions. I'm ready to hear what you have to say. I have already succeeded once or twice in having clean files but I never succeed twice in a row. Maybe you have to completely delete a line to modify a word?
Anyway thanks in advance

I have already tried using git but without success. I had tried to modify files then upload them to no avail... Another thing, I already have the doc several times and I refer to the documentation each time I need it. However, I still haven't found a method, whether online or graphical, to remove bad versions. I'm ready to hear what you have to say. I have already succeeded once or twice in having clean files but I never succeed twice in a row. Maybe you have to completely delete a line to modify a word? Anyway thanks in advance

Gangneron commented

2023-09-11 18:36:30 +02:00

First-time contributor

I am going to ask a question regarding the translations in order to verify for Thai, Kyrgyz and Abkhaz. I will ask if the translations are indeed the ones we are proposing

Damien Picard commented

2023-09-11 18:46:39 +02:00

I have already tried using git but without success.

Ok, I understand as git is quite a complex tool to use. For a simple fix such as this one, it’s not strictly needed, but you will really need to learn the basics if you want to contribute more advanced stuff in the future.

However, I still haven't found a method, whether online or graphical, to remove bad versions.

As far as I know, the only ways to remove unwanted commits are using git…
One is with interactive rebase, an advanced command which lets you choose which commits you want to keep or discard, or change their order.
The other one is to simply start from a new branch, push it to your fork, and choose that as the basis for your pull request. You can do that by pressing the Edit button next to the title of the PR. Maybe you can do this without git but it’s not a very clean thing to do anyway, and there have been issues with it in the past with Gitea.

I have already succeeded once or twice in having clean files but I never succeed twice in a row.

What editor are you using? The issue is that there can be multiple ways for the source file to say that a line ends and a new one should begin. You are using the Windows one, while Blender uses the Unix one. You need to setup your text editor so that it saves the files using the Unix format (LF) , and not DOS (CRLF). How to do this is different depending on the editor.

> I have already tried using git but without success. Ok, I understand as git is quite a complex tool to use. For a simple fix such as this one, it’s not strictly needed, but you will _really_ need to learn the basics if you want to contribute more advanced stuff in the future. > However, I still haven't found a method, whether online or graphical, to remove bad versions. As far as I know, the only ways to remove unwanted commits are using git… One is with interactive rebase, an advanced command which lets you choose which commits you want to keep or discard, or change their order. The other one is to simply start from a new branch, push it to your fork, and choose that as the basis for your pull request. You can do that by pressing the Edit button next to the title of the PR. _Maybe_ you can do this without git but it’s not a very clean thing to do anyway, and there have been issues with it in the past with Gitea. > I have already succeeded once or twice in having clean files but I never succeed twice in a row. What editor are you using? The issue is that there can be multiple ways for the source file to say that a line ends and a new one should begin. You are using the Windows one, while Blender uses the Unix one. You need to setup your text editor so that it saves the files using the Unix format (LF) , and not DOS (CRLF). How to do this is different depending on the editor.

Gangneron commented

2023-09-11 18:47:18 +02:00

First-time contributor

I asked the question on the blender-coder channel I hope we get answers. If my message on the chat is not clear enough, don't hesitate to tell me or come and clarify certain information

Gangneron commented

2023-09-11 18:49:45 +02:00

First-time contributor

Questions, if I redo a commit with the same modifications but changing the line endings, will this not cause a problem?

Damien Picard commented

2023-09-11 18:50:17 +02:00

I asked the question on the blender-coder channel I hope we get answers. If my message on the chat is not clear enough, don't hesitate to tell me or come and clarify certain information

That’s good, I hope you get replies but these languages are not common among Blender developers as far as I know, so I’m not too hopeful about it. Also, I tried that several times already.

Anyway, this issue has been there for years, don’t worry too much about it if we don’t get a reply soon, I say we should just be patient and wait until someone with the required knowledge contacts us.

> I asked the question on the blender-coder channel I hope we get answers. If my message on the chat is not clear enough, don't hesitate to tell me or come and clarify certain information That’s good, I hope you get replies but these languages are not common among Blender developers as far as I know, so I’m not too hopeful about it. Also, I tried that several times already. Anyway, this issue has been there for years, don’t worry too much about it if we don’t get a reply soon, I say we should just be patient and wait until someone with the required knowledge contacts us.

Gangneron commented

2023-09-11 18:52:15 +02:00

First-time contributor

Questions, if I redo a commit with the same modifications but changing the line endings, will this not cause a problem?

Gangneron commented

2023-09-11 18:53:39 +02:00

First-time contributor

if it's good, I'll do it right away

Gangneron commented

2023-09-11 18:54:27 +02:00

First-time contributor

I asked the question on the blender-coder channel I hope we get answers. If my message on the chat is not clear enough, don't hesitate to tell me or come and clarify certain information

That’s good, I hope you get replies but these languages are not common among Blender developers as far as I know, so I’m not too hopeful about it. Also, I tried that several times already.

Anyway, this issue has been there for years, don’t worry too much about it if we don’t get a reply soon, I say we should just be patient and wait until someone with the required knowledge contacts us.

thank you you that reassures me

> > I asked the question on the blender-coder channel I hope we get answers. If my message on the chat is not clear enough, don't hesitate to tell me or come and clarify certain information > > That’s good, I hope you get replies but these languages are not common among Blender developers as far as I know, so I’m not too hopeful about it. Also, I tried that several times already. > > Anyway, this issue has been there for years, don’t worry too much about it if we don’t get a reply soon, I say we should just be patient and wait until someone with the required knowledge contacts us. thank you you that reassures me

Gangneron commented

2023-09-11 19:00:08 +02:00

First-time contributor

maybe it was a line ending problem. I'm waiting for your confirmation to commit the changes on github

Damien Picard commented

2023-09-11 19:06:29 +02:00

It looks like uploading the file again to your branch with the correct line ending type would work, so you can go ahead and try. However, even if that issue is solved, I don’t think the PR will be accepted because of the more important language knowledge issue.

Gangneron commented

2023-09-11 19:09:58 +02:00

First-time contributor

Okay but at least when we have the information, if everything is correct then we will only have to merge it

Gangneron added 1 commit 2023-09-11 19:12:41 +02:00

2d3315e8a6 Fixed error of ending line

fixed problem of ending line for python file

Gangneron added 1 commit 2023-09-11 19:14:22 +02:00

c5a0382a65 Fixed error of ending line

Fixed problem of ending line for language file

Gangneron commented

2023-09-11 19:15:45 +02:00

First-time contributor

problem solved. Thank you for your help

Gangneron commented

2023-09-11 19:18:37 +02:00

First-time contributor

I just hope it doesn't merge automatically

Gangneron commented

2023-09-11 19:19:50 +02:00

First-time contributor

otherwise you will have to redo everything

Damien Picard commented

2023-09-11 19:20:00 +02:00

I just hope it doesn't merge automatically

It won’t, a maintainer has to review, accept, and merge each pull request!

> I just hope it doesn't merge automatically It won’t, a maintainer has to review, accept, and merge each pull request!

Gangneron commented

2023-09-11 19:23:13 +02:00

First-time contributor

ok

Gangneron commented

2023-09-12 18:08:59 +02:00

First-time contributor

I had an idea, I suggested that we look for translations of the language names we are looking for in online dictionaries.

Gangneron commented

2023-09-12 18:16:02 +02:00

First-time contributor

for Thai it seems good to me

Capture d’écran (95).png

198 KiB

Capture d’écran (94).png

977 KiB

Damien Picard commented

2023-09-12 18:16:50 +02:00

I had an idea, I suggested that we look for translations of the language names we are looking for in online dictionaries.

That is a good idea, and it’s actually the first thing I did. If you look at the original message in #105461, you’ll see that I got a list from the Wikimedia project, which appears quite reliable. But languages are a complicated topic, and I’d really rather not relying on my limited knowledge to make decisions on languages I don’t know about. Indeed, that page is what led to the mistake of proposing “Eesti” instead of “Eesti keel” for Estonian.
If you find multiple sources, how do you know which one is correct? If multiple ways exist to refer to the language, how do you know which one the native speakers prefer in this context?

> I had an idea, I suggested that we look for translations of the language names we are looking for in online dictionaries. That is a good idea, and it’s actually the first thing I did. If you look at the original message in #105461, you’ll see that I got [a list](https://meta.wikimedia.org/wiki/List_of_Wikipedias) from the Wikimedia project, which appears quite reliable. But languages are a complicated topic, and I’d really rather not relying on my limited knowledge to make decisions on languages I don’t know about. Indeed, that page is what led to the mistake of proposing “Eesti” instead of “Eesti keel” for Estonian. If you find multiple sources, how do you know which one is correct? If multiple ways exist to refer to the language, how do you know which one the native speakers prefer in this context?

Gangneron commented

2023-09-12 18:20:11 +02:00

First-time contributor

thailandai seems to be written as thai

Capture d’écran (97).png

180 KiB

Capture d’écran (96).png

192 KiB

Gangneron commented

2023-09-12 18:26:33 +02:00

First-time contributor

I suggest using Larousse translation because several of my language teachers recommended it to me, but in addition to Larousse, use Teverso, Google translation, Wikimedia and other translation sources if you know of others. If all of them give us the same result then I think we can accept the translation (unless we find a counter-example on another site and at that point we would put the translation on hold or we could see if this variant can be found elsewhere). And if all the sources do not agree then we wait for confirmation.

Gangneron commented

2023-09-12 18:27:36 +02:00

First-time contributor

I don't claim to have an infallible method but I think it is very robust. I don't know what you think about it

Gangneron requested review from Bastien Montagne 2023-12-16 18:13:36 +01:00

Bastien Montagne commented

2023-12-18 11:08:30 +01:00

Honestly, I also cannot figure out a definitive and fully trustworthy way to get language names currently.

When I add one, I typically use Wikipedia, and try to cross-reference with some other source if I can find one, but this type of info is surprisingly hard to come by reliably.

Ultimately, I would expect people actually translating the language to come up and report if there is something wrong with the chosen name. I also don't think having Langue Française instead of Français is a critical issue - not the typical expected way to name it, but not incorrect either. Again, actual native speakers are more than welcome to request a change.

Thanks for the patch though.

Honestly, I also cannot figure out a definitive and fully trustworthy way to get language names currently. When I add one, I typically use Wikipedia, and try to cross-reference with some other source if I can find one, but this type of info is surprisingly hard to come by reliably. Ultimately, I would expect people actually translating the language to come up and report if there is something wrong with the chosen name. I also don't think having `Langue Française` instead of `Français` is a critical issue - not the typical expected way to name it, but not incorrect either. Again, actual native speakers are more than welcome to request a change. Thanks for the patch though.

Bastien Montagne closed this pull request

2023-12-18 11:08:32 +01:00

Harley Acheson referenced this pull request

2024-02-29 22:41:13 +01:00

Language names may be incorrect in the language menu #105461