Fix: Animation Editor snapping not working when using rotate or scale #112088

Christoph Lendenfeld · 2023-09-07T17:26:51+02:00

2023-09-07 17:26:51 +02:00

This was introduced with #109015: Animation: Move Snapping to Scene

The issue manifested in two ways.

snapping did not work with rotate and scale
the scale and rotate value would increment in steps instead of fluidly

This was caused because the snapping code would force the mode to SCE_SNAP_TO_INCREMENT if the snapping wasn't enabled for the given transform mode.
By transform mode I mean this enum in the 3D viewport snap settings.

This mode is not supported in the Animation Editors though, causing the snapping switch to fall back to default which is to do no snapping.
My assumption is that this mode also causes the increments in the transform.

It would be good to support that in the future, but for now this is just a fix to get the 3.6 behavior back.

This was introduced with [#109015: Animation: Move Snapping to Scene](https://projects.blender.org/blender/blender/pulls/109015) The issue manifested in two ways. * snapping did not work with rotate and scale * the scale and rotate value would increment in steps instead of fluidly This was caused because the snapping code would force the mode to `SCE_SNAP_TO_INCREMENT` if the snapping wasn't enabled for the given transform mode. By transform mode I mean this enum in the 3D viewport snap settings. ![image](/attachments/177e2289-20c6-452f-bb3c-2deba9273c11) This mode is not supported in the Animation Editors though, causing the snapping `switch` to fall back to `default` which is to do no snapping. My assumption is that this mode also causes the increments in the transform. It would be good to support that in the future, but for now this is just a fix to get the 3.6 behavior back.

image.png

3.5 KiB

Christoph Lendenfeld added the

Module

Animation & Rigging

label 2023-09-07 17:26:51 +02:00

Christoph Lendenfeld added 1 commit 2023-09-07 17:27:04 +02:00

10a3efb803 fix

Christoph Lendenfeld requested review from Nathan Vegdahl 2023-09-07 17:27:22 +02:00

Christoph Lendenfeld changed title from ~~Fix: Graph Editor snapping not working when using rotate or scale~~ to Fix: Animation Editor snapping not working when using rotate or scale

2023-09-07 17:33:31 +02:00

Christoph Lendenfeld added this to the Animation & Rigging project 2023-09-08 09:30:42 +02:00

Nathan Vegdahl approved these changes 2023-09-08 10:49:23 +02:00

Nathan Vegdahl left a comment

Works great in testing, and the code looks good. Thanks!

Christoph Lendenfeld merged commit a41da206cd into main

2023-09-08 11:34:25 +02:00

Christoph Lendenfeld referenced this issue from a commit

2023-09-08 11:34:26 +02:00

Fix: Animation Editor snapping not working when using rotate or scale

Christoph Lendenfeld deleted branch fix_ge_rotate_scale_handle_snap

2023-09-08 11:34:27 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Fix: Animation Editor snapping not working when using rotate or scale #112088