UI: Use asset icon for "Mark Asset" in menus #112111

Pablo Vazquez · 2023-09-08T01:07:18+02:00

Pablo Vazquez commented

2023-09-08 01:07:18 +02:00

Use the asset icon for the "Mark Asset" operator in menus.

Using icons is not only good for accessibility, but also to create
a connection with the Asset Browser and the icon shown in the
data-block template once marked as asset.

Outliner

Object menu

Data-block context

Use the asset icon for the "Mark Asset" operator in menus. Using icons is not only good for accessibility, but also to create a connection with the Asset Browser and the icon shown in the data-block template once marked as asset. |Outliner| |----| |![Outliner](/attachments/a3ca5c21-83f6-4f67-acbc-f59a1cffcf57)| |Object menu| |----| ![icon in asset menu](/attachments/74e35b77-ec8f-402a-bd24-b9c2e5aeaa25) |Data-block context| |----| |![data-block context](/attachments/25305711-0d0a-4e57-85ef-04cdcefa52df)|

image.png

243 KiB

image.png

393 KiB

image.png

431 KiB

👍 3

Pablo Vazquez added 1 commit 2023-09-08 01:07:29 +02:00

04628d4798 UI: Use asset icon for "Mark Asset" in menus

Use the asset icon for the "Mark Asset" operator in menus.

Using icons is not only good for accessibility, but also to create
a connection with the Asset Browser and the icon shown in the
data-block template once marked as asset.

Pablo Vazquez added the

Module

User Interface

label 2023-09-08 01:08:14 +02:00

Pablo Vazquez added this to the User Interface project 2023-09-08 01:08:14 +02:00

Hans Goudey commented

2023-09-08 05:15:49 +02:00

What do you think about putting the icon in the parent menu in this case? Too busy? Might be helpful to make the connection with the asset browser/system without the need to open the submenu?

![image](/attachments/b6354cfd-b1f5-4bf7-b643-5b25426d5d4b) What do you think about putting the icon in the parent menu in this case? Too busy? Might be helpful to make the connection with the asset browser/system without the need to open the submenu?

image.png

77 KiB

👍 1

Pablo Vazquez commented

2023-09-08 13:11:36 +02:00

What do you think about putting the icon in the parent menu in this case? Too busy? Might be helpful to make the connection with the asset browser/system without the need to open the submenu?

It's a good point for discoverability, although we would be giving the same icon to two different actions. Are you suggesting to have it only in the parent menu and not in the sub-menu Mark Asset? It'd break consistency with other menus but .

This is how it looks with both:

Only Asset menu:

> What do you think about putting the icon in the parent menu in this case? Too busy? Might be helpful to make the connection with the asset browser/system without the need to open the submenu? It's a good point for discoverability, although we would be giving the same icon to two different actions. Are you suggesting to have it only in the parent menu and not in the sub-menu `Mark Asset`? It'd break consistency with other menus but . This is how it looks with both: ![icon in both menus](/attachments/13e38dfb-7cca-44ad-ba0e-029d6af5bcb3) Only `Asset` menu: ![icon in asset menu](/attachments/74e35b77-ec8f-402a-bd24-b9c2e5aeaa25)

image.png

124 KiB

image.png

123 KiB

Hans Goudey commented

2023-09-08 14:03:33 +02:00

I did mean only in the parent menu. I don't have a strong opinion, but I do think there's potential for that asset icon and others in that same section to be helpful to users. For example, the collection icon could be used for the collection menu. Not sure if that would be considered over-using icons or good path-finding though.

Totally up to you! I just wanted to bring it up in case you didn't think about it.

I did mean only in the parent menu. I don't have a strong opinion, but I do think there's potential for that asset icon and others in that same section to be helpful to users. For example, the collection icon could be used for the collection menu. Not sure if that would be considered over-using icons or good path-finding though. Totally up to you! I just wanted to bring it up in case you didn't think about it.

👍 1

Pablo Vazquez added 1 commit 2023-09-08 14:50:19 +02:00

4b08d9f1b1 In the Object menu, show the icon in the parent "Assets" menu

Thanks to Hans' suggestion.

Pablo Vazquez commented

2023-09-08 14:52:58 +02:00

For example, the collection icon could be used for the collection menu. Not sure if that would be considered over-using icons or good path-finding though.

Agree. I think the "path finding" argument is the way to go, and we should use it in other menus. Will have a look at that, the Collection entry should be below Asset, so that way Parent and Relations are closer since they are kind of related.

Anyway, updated the patch. Thanks!

> For example, the collection icon could be used for the collection menu. Not sure if that would be considered over-using icons or good path-finding though. Agree. I think the "path finding" argument is the way to go, and we should use it in other menus. Will have a look at that, the `Collection` entry should be below `Asset`, so that way `Parent` and `Relations` are closer since they are kind of related. Anyway, updated the patch. Thanks!

Pablo Vazquez merged commit 754f2f9c80 into main

2023-09-08 15:40:07 +02:00

Pablo Vazquez referenced this issue from a commit

2023-09-08 15:40:07 +02:00

UI: Use asset icon for "Mark Asset" in menus

Pablo Vazquez deleted branch ui-menus-mark-asset-icon

2023-09-08 15:40:09 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

UI: Use asset icon for "Mark Asset" in menus #112111