WIP: I18n: revert context of items in the Add Modifier menu to default #112246

Closed

Damien Picard wants to merge 1 commits from pioverfour:dp_add_mod_menu_contexts into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Damien Picard commented

2023-09-11 17:35:42 +02:00

Member

The Add Modifier menu used to be an operator which called a menu on
invocation (object.modifier_add, called through
operator_menu_enum()). Each item used the default translation
context.

This has changed to using an actual menu, in which each possible type
of modifier is displayed using layout.operator(). This results in
using the default_operator translation context.

Since the context has changed, the translations must be updated, but
this poses two problems:

The old way of calling the menu still exists if one calls the
operator manually, so the translation is duplicated for nothing.
Some of the messages already exist with the Operator context, and
mean something else (e. g. "Bevel" is the imperative form of the verb,
instead of the noun).

This commit fixes those issues by restoring the default context in
the interface of the new menu.

The Add Modifier menu used to be an operator which called a menu on invocation (`object.modifier_add`, called through `operator_menu_enum()`). Each item used the `default` translation context. This has changed to using an actual menu, in which each possible type of modifier is displayed using `layout.operator()`. This results in using the `default_operator` translation context. Since the context has changed, the translations must be updated, but this poses two problems: 1. The old way of calling the menu still exists if one calls the operator manually, so the translation is duplicated for nothing. 2. Some of the messages already exist with the Operator context, and mean something else (e. g. "Bevel" is the imperative form of the verb, instead of the noun). This commit fixes those issues by restoring the `default` context in the interface of the new menu.

Damien Picard added the

labels 2023-09-11 17:35:43 +02:00

Damien Picard added 1 commit 2023-09-11 17:35:56 +02:00

0a9ba13e96 I18n: revert context of items in the Add Modifier menu to default

The Add Modifier menu used to be an operator which called a menu on
invocation (`object.modifier_add`, called through
`operator_menu_enum()`). Each item used the `default` translation
context.

This has changed to using an actual menu, in which each possible type
of modifier is displayed using `layout.operator()`. This results in
using the `default_operator` translation context.

Since the context has changed, the translations must be updated, but
this poses two problems:
1. The old way of calling the menu still exists if one calls the
operator manually, so the translation is duplicated for nothing.
2. Some of the messages already exist with the Operator context, and
mean something else (e. g. "Bevel" is the imperative form of the verb,
instead of the noun).

This commit fixes those issues by restoring the `default` context in
the interface of the new menu.

Damien Picard requested review from Bastien Montagne 2023-09-11 17:36:07 +02:00

Bastien Montagne reviewed 2023-09-11 18:08:20 +02:00

Bastien Montagne left a comment

Owner

This is a nice find, but I think the solution actually lies somewhere else.

In a nutshell, there is no good reason to re-define these names in the python layout code of the menu, these names already exist in the underlying enum.

The solution here is to add a get_name callback to the OBJECT_OT_modifier_add operator type definition.

This is a nice find, but I think the solution actually lies somewhere else. In a nutshell, there is no good reason to re-define these names in the python layout code of the menu, these names already exist in the underlying enum. The solution here is to add a `get_name` callback to the `OBJECT_OT_modifier_add` operator type definition.

Damien Picard commented

2023-09-11 18:21:47 +02:00

Author

Member

The solution here is to add a get_name callback to the OBJECT_OT_modifier_add operator type definition.

Cool, I forgot about this.

> The solution here is to add a `get_name` callback to the `OBJECT_OT_modifier_add` operator type definition. Cool, I forgot about this.

Damien Picard changed title from ~~I18n: revert context of items in the Add Modifier menu to default~~ to WIP: I18n: revert context of items in the Add Modifier menu to default

2023-09-11 18:21:58 +02:00

Bastien Montagne commented

2023-09-11 19:09:24 +02:00

Owner

Unfortunately.... the get_name callback does not work (at all!) in this case, nor essentially in any UI defined from python API.

Tried to implement it, but it turned into a can of worms in itself.

So for now, will rather just change the py code of these modifiers menus, to be a bit smarter and avoid duplicating the info already available in the underlying enum property.

Unfortunately.... the `get_name` callback does not work (at all!) in this case, nor essentially in any UI defined from python API. Tried to implement it, but it turned into a can of worms in itself. So for now, will rather just change the py code of these modifiers menus, to be a bit smarter and avoid duplicating the info already available in the underlying enum property.

Bastien Montagne referenced this pull request

2023-09-11 20:14:36 +02:00

UI/I18N: Fix a couple of issues in new 'Add Modifiers' menu. #112252

Bastien Montagne referenced this pull request

2023-09-11 20:32:13 +02:00

OperatorType's `get_name` callback is useless with any layout-based API-defined UI code. #112253

Damien Picard closed this pull request

2023-09-11 21:00:57 +02:00

Bastien Montagne referenced this issue from a commit

2023-09-13 22:44:55 +02:00

UI/I18N: Fix a couple of issues in new 'Add Modifiers' menu.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112246

No description provided.