UI/I18N: Fix a couple of issues in new 'Add Modifiers' menu. #112252

Bastien Montagne · 2023-09-11T20:14:36+02:00

Bastien Montagne commented

2023-09-11 20:14:36 +02:00

The recent change to the 'Add Modifier' created at least two issues:

A complete duplicate of UI info for each modifier (its name and icon),
now existing in both the RNA enum definition of modifiers types, and
in the Python UI code.
An implicit duplication of these UI names in two different translation
contexts, since the ones from the enum use the default one, while
explicit labels passed to the layout.operator UI API get assigned a
default 'operator' context. See PR !112246 for details about this.

Both issues can be easily solved by making the new python code for these
menus a bit smarter. Adding a helper function that adds the add_modifier
operator with the right parameters, just based on the operator type.

Both names (labels) and icons can be found in the enum property
bl_rna definition itself then.

This change:

Avoids duplicating UI info.
Fixes translation context mismatch, by forcing the usage of the
default one also from the python code.
Makes code less verbose and overall more readable.

NOTE: An attempt has been made to use the get_name callback of
operator types to automatically return the right name based on the
defined type, but this is currently utterly failing with regular
layout-based UI code. This will be reported and handled separately.

The recent change to the 'Add Modifier' created at least two issues: * A complete duplicate of UI info for each modifier (its name and icon), now existing in both the RNA enum definition of modifiers types, and in the Python UI code. * An implicit duplication of these UI names in two different translation contexts, since the ones from the enum use the default one, while explicit labels passed to the `layout.operator` UI API get assigned a default 'operator' context. See PR !112246 for details about this. Both issues can be easily solved by making the new python code for these menus a bit smarter. Adding a helper function that adds the `add_modifier` operator with the right parameters, just based on the operator type. Both names (labels) and icons can be found in the enum property `bl_rna` definition itself then. This change: * Avoids duplicating UI info. * Fixes translation context mismatch, by forcing the usage of the default one also from the python code. * Makes code less verbose and overall more readable. NOTE: An attempt has been made to use the `get_name` callback of operator types to automatically return the right name based on the defined type, but this is currently utterly failing with regular layout-based UI code. This will be reported and handled separately.

❤️ 1

Bastien Montagne requested review from Campbell Barton 2023-09-11 20:15:18 +02:00

Bastien Montagne requested review from Julian Eisel 2023-09-11 20:15:19 +02:00

Bastien Montagne requested review from Hans Goudey 2023-09-11 20:15:19 +02:00

Bastien Montagne commented

2023-09-11 20:15:44 +02:00

@pioverfour FYI :)

🎉 1

Bastien Montagne force-pushed tmp-modifiers-menu-fix from 7188a19e4b to 5cdf8d06a0

2023-09-11 20:17:12 +02:00

Compare

Hans Goudey approved these changes 2023-09-11 20:23:59 +02:00