UI: Allow Tooltip Padding In Any Order #112487

Harley Acheson · 2023-09-17T21:28:24+02:00

Harley Acheson commented

2023-09-17 21:28:24 +02:00

Allow padding anywhere within a tooltip, not just before the current
field, by adding a new field type of UI_TIP_STYLE_SPACER.

With #105905 I tried to keep as close to the existing design as possible, to minimize changes. But #104547 exposes a deficiency that I would like to address separately here.

UI_tooltip_text_field_add has an argument of "is_pad" that adds extra padding before the field being added. This has worked fine up until now because we have only ever needed space before some sections. But if creating custom tooltips there are times when you want to have space after a field and the fields following could vary. Another example is with an image field, where you might want padding before or after it depending on what content it shares the tooltip with.

This PR just makes a new field type of UI_TIP_STYLE_SPACER that can be inserted anywhere. Otherwise everything looks and works exactly as today. Minimal changes are made to existing code by keeping the existing is_pad and just having it create a spacer field.

Allow padding anywhere within a tooltip, not just before the current field, by adding a new field type of UI_TIP_STYLE_SPACER. --- With #105905 I tried to keep as close to the existing design as possible, to minimize changes. But #104547 exposes a deficiency that I would like to address separately here. `UI_tooltip_text_field_add` has an argument of "is_pad" that adds extra padding **before** the field being added. This has worked fine up until now because we have only ever needed space _before_ some sections. But if creating custom tooltips there are times when you want to have space **after** a field and the fields following could vary. Another example is with an image field, where you might want padding before or after it depending on what content it shares the tooltip with. This PR just makes a new field type of UI_TIP_STYLE_SPACER that can be inserted anywhere. Otherwise everything looks and works exactly as today. Minimal changes are made to existing code by keeping the existing `is_pad` and just having it create a spacer field.

Harley Acheson added 1 commit 2023-09-17 21:28:37 +02:00

bec6273bcf UI: Replace Tooltip "isPad" with Spacer Field

Allow padding anywhere within a tooltip, not just before the current
field, by adding a new fielt type of UI_TIP_STYLE_SPACER.

Harley Acheson added this to the User Interface project 2023-09-17 21:28:47 +02:00

Harley Acheson requested review from Brecht Van Lommel 2023-09-17 21:28:56 +02:00

~~Harley Acheson referenced this pull request 2023-09-21 02:23:04 +02:00~~

UI: Recent Menu Previews #112644

Harley Acheson referenced this pull request

2023-09-22 01:34:38 +02:00

UI: Recent Menu Previews #112644

Harley Acheson added 2 commits 2023-10-13 00:13:41 +02:00

d9d0a35abe Merge branch 'main' of projects.blender.org:blender/blender into TooltipIsPad

8a61373c05 Less changes by keeping the is_pad argument.

Harley Acheson added 1 commit 2023-10-13 00:16:00 +02:00

ea79258928 Missed one.

Harley Acheson changed title from ~~UI: Replace Tooltip "isPad" with Spacer Field~~ to UI: Allow Tooltip Padding In Any Order

2023-10-13 00:18:03 +02:00

Harley Acheson requested review from Campbell Barton 2023-10-13 00:22:11 +02:00

Harley Acheson commented

2023-10-13 00:25:50 +02:00

@ideasman42

Do you mind this? The changes are tiny and trivial, but it means that Tooltip padding can be added anywhere, not just before the current field. With more complex tooltips it can be convenient to add padding after the current field. Or before and after an image field. Or multiples if we need.

If possible we might push to get #104547 into 4.1 before the Conference so having this makes that nicer and simpler.

@ideasman42 Do you mind this? The changes are tiny and trivial, but it means that Tooltip padding can be added anywhere, not just before the current field. With more [complex tooltips](https://projects.blender.org/blender/blender/pulls/104547) it can be convenient to add padding after the current field. Or before and after an image field. Or multiples if we need. If possible we might push to get #104547 into 4.1 before the Conference so having this makes that nicer and simpler.

Campbell Barton approved these changes 2023-10-13 02:55:34 +02:00

Harley Acheson merged commit cb9832f9b1 into main

2023-10-13 22:34:50 +02:00

Harley Acheson referenced this issue from a commit

2023-10-13 22:34:52 +02:00

UI: Allow Tooltip Padding In Any Order

Harley Acheson deleted branch TooltipIsPad

2023-10-13 22:34:52 +02:00

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

UI: Allow Tooltip Padding In Any Order #112487