Fix #112630: Skip grave quotation when selecting #112652

Merged
Harley Acheson merged 2 commits from PratikPB2123/blender:112630-grave-skip into blender-v4.0-release 2023-10-03 01:57:09 +02:00
Member

Like single and double quote, skip grave chars when double selecting

Like single and double quote, skip grave chars when double selecting
Pratik Borhade added 1 commit 2023-09-21 08:49:22 +02:00
Like single and double quote, skip grave chars when double selecting
Pratik Borhade requested review from Harley Acheson 2023-09-21 08:49:29 +02:00
Pratik Borhade added the
Module
User Interface
label 2023-09-21 08:49:35 +02:00
Member

If we did this, adding "grave accent", wouldn't we not want to also add the matching "acute accent"? Otherwise we'll get complains that `this´ does work as expected.

case 0xB4:        /* Acute Accent. */
If we did this, adding "grave accent", wouldn't we not want to also add the matching "acute accent"? Otherwise we'll get complains that `this´ does work as expected. ``` case 0xB4: /* Acute Accent. */ ```
Member

Well in that case I could also suggest “”‘’,。 symbols for Chinese punctuation marks? Maybe we need to handle some other languages as well.

Well in that case I could also suggest `“”‘’,。` symbols for Chinese punctuation marks? Maybe we need to handle some other languages as well.
Member

Well in that case I could also suggest “”‘’,。 symbols for Chinese punctuation marks? Maybe we need to handle some other languages as well.

That would make a nice PR, with only changes to this one function for Chinese. It would have to be fairly complete though, so also include the full-width western punctuation characters too. I've wanted to do this but it really should be done by someone who actually knows Chinese. https://en.wikipedia.org/wiki/Chinese_punctuation

> Well in that case I could also suggest `“”‘’,。` symbols for Chinese punctuation marks? Maybe we need to handle some other languages as well. That would make a nice PR, with only changes to this one function for Chinese. It would have to be fairly complete though, so also include the full-width western punctuation characters too. I've wanted to do this but it really should be done by someone who actually knows Chinese. https://en.wikipedia.org/wiki/Chinese_punctuation
Pratik Borhade added 1 commit 2023-09-26 13:00:46 +02:00
Harley Acheson changed title from Fix #112630: Skip grave quotation when selecting to Fix #112630: Skip grave quotation when selecting 2023-10-03 01:41:08 +02:00
Harley Acheson changed target branch from main to blender-v4.0-release 2023-10-03 01:41:12 +02:00
Harley Acheson approved these changes 2023-10-03 01:53:01 +02:00
Harley Acheson left a comment
Member

Awesome! Thanks!

Awesome! Thanks!
Harley Acheson merged commit fcd6b6f4f6 into blender-v4.0-release 2023-10-03 01:57:09 +02:00
Author
Member

Thanks for merging and reviewing :)

Thanks for merging and reviewing :)
Pratik Borhade deleted branch 112630-grave-skip 2023-10-03 13:33:17 +02:00
Member

Thanks for merging and reviewing :)

No worries. I only merged it myself because I wanted to update, retarget, and remove any conflicts in this: #112852

> Thanks for merging and reviewing :) No worries. I only merged it myself because I wanted to update, retarget, and remove any conflicts in this: https://projects.blender.org/blender/blender/pulls/112852
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112652
No description provided.