UI: Recognize CJK punctuation when selecting text #112852

Merged
Harley Acheson merged 4 commits from ChengduLittleA/blender:chinese_punctuations into blender-v4.0-release 2023-10-04 21:08:21 +02:00
Member

Add frequently-used Chinese, Japanese, Korean special character
delimiters (punctuation, quote characters, brackets, etc) to aid the
selection of character segments in text operations.


Without this we can't select sections with double-clicking, or use ctrl-Arrow to move by segment. Following shows current code and double-clicking (3.6.1):

gif

With this PR applied we can select segments:

gif

Add frequently-used Chinese, Japanese, Korean special character delimiters (punctuation, quote characters, brackets, etc) to aid the selection of character segments in text operations. --- Without this we can't select sections with double-clicking, or use ctrl-Arrow to move by segment. Following shows current code and double-clicking (3.6.1): ![gif](/attachments/3f8425b0-c551-4ca1-9146-a7beb350e7db) With this PR applied we can select segments: ![gif](/attachments/e7452aa8-5629-4e6b-bae6-2ae945f6a5de)
YimingWu added 1 commit 2023-09-25 14:53:20 +02:00
86e08158d8 Add Chinese special characters to `STRCUR_DELIM`
Frequently used Chinese special character delimiters are added to aid
string operations like "select by word/segment by double click".
Author
Member

As @Harley suggested in #112652, I added frequently used Chinese punctuation marks into STRCUR_DELIM.

As @Harley suggested in #112652, I added frequently used Chinese punctuation marks into `STRCUR_DELIM`.
YimingWu added 1 commit 2023-09-25 15:01:22 +02:00
Author
Member

Updated a few, didn't include everything in the unicode full width block since only these symbols are most frequently used.

Yes, great to just add the common ones.

For these though, I'd like to see each line with a comment. They can start with "Chinese" or "CJK" if you they are used elsewhere, but then a full name. For example "Chinese full width left lenticular bracket", "CJK full width full stop", etc.

> Updated a few, didn't include everything in the unicode full width block since only these symbols are most frequently used. Yes, great to just add the common ones. For these though, I'd like to see each line with a comment. They can start with "Chinese" or "CJK" if you they are used elsewhere, but then a full name. For example "Chinese full width left lenticular bracket", "CJK full width full stop", etc.
Harley Acheson added this to the User Interface project 2023-09-25 22:28:17 +02:00
Harley Acheson requested review from Harley Acheson 2023-09-25 22:28:25 +02:00
Author
Member

Will update with full name descriptions.

Will update with full name descriptions.
YimingWu added 1 commit 2023-09-27 05:33:45 +02:00
Harley Acheson changed title from Add Chinese special characters to `STRCUR_DELIM` to Add Chinese special characters to `STRCUR_DELIM` 2023-10-03 02:13:11 +02:00
Harley changed target branch from main to blender-v4.0-release 2023-10-03 02:13:13 +02:00
Harley Acheson added 1 commit 2023-10-03 02:45:24 +02:00
Harley Acheson changed title from Add Chinese special characters to `STRCUR_DELIM` to UI: Recognize CJK punctuation when selecting text 2023-10-04 20:58:20 +02:00
Harley Acheson approved these changes 2023-10-04 21:06:56 +02:00
Harley Acheson left a comment
Member

Thank you!!

Thank you!!
@ -88,2 +103,4 @@
case 0xA3: /* pound */
case 0x80: /* euro */
case 0xA3: /* pound */
case 0x80: /* euro */
Member

You've accidentally duplicated the two lines above

You've accidentally duplicated the two lines above
Harley marked this conversation as resolved
Harley Acheson approved these changes 2023-10-04 21:07:23 +02:00
Harley Acheson merged commit 6d64c6dcd7 into blender-v4.0-release 2023-10-04 21:08:21 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#112852
No description provided.