UI: Change Overlay Text Size with Label Text Style #112875

Harley Acheson · 2023-09-25T20:14:29+02:00

Harley Acheson commented

2023-09-25 20:14:29 +02:00

Text Overlays are currently hard-coded to 11 points. This allows them
to be set with Preferences / Themes / Text Styles, Widget Label.

We are currently considering changes to Text Style sizes. Unfortunately the View3D Text Overlays ("Text Info" and "Statistics") are currently hardcoded to be 11 points. This just allows them to be changed with Text Styles, and uses a line spacing based on the text size.

Text Overlays are currently hard-coded to 11 points. This allows them to be set with Preferences / Themes / Text Styles, Widget Label. --- We are currently [considering changes to Text Style sizes](https://projects.blender.org/blender/blender/issues/112748). Unfortunately the View3D Text Overlays ("Text Info" and "Statistics") are currently hardcoded to be 11 points. This just allows them to be changed with Text Styles, and uses a line spacing based on the text size.

Harley Acheson added 1 commit 2023-09-25 20:14:42 +02:00

554f4e2138 UI: Change Overlay Text Size with Label Text Style

Text Overlays are currently hard-coded to 11 points. This allows them
to be set with Preferences / Themes / Text Styles, Widget Label.

Harley Acheson added this to the User Interface project 2023-09-25 20:14:58 +02:00

Harley Acheson requested review from Pablo Vazquez 2023-09-25 20:15:05 +02:00

Pablo Vazquez commented

2023-09-26 12:42:39 +02:00

Interesting! First, yes, we should definitely have this. +1

I love it that it also adjusts the size of numbers in the animation/vse editors and the labels in strips in VSE. We should (as a separate patch) tackle the issues that this brings to light (like the node editor breadcrumbs not following it and spacing away, also present before the patch).

Just to show an example, before patch:

After:

Interesting! First, yes, we should definitely have this. +1 I love it that it also adjusts the size of numbers in the animation/vse editors and the labels in strips in VSE. We should (as a separate patch) tackle the issues that this brings to light (like the node editor breadcrumbs not following it and spacing away, also present before the patch). Just to show an example, before patch: <video src="/attachments/02020d29-7d78-451d-b96e-9712dd77e494" title="before.mp4" controls></video> After: <video src="/attachments/34599466-48e1-495c-9c96-8460707ba73b" title="after.mp4" controls></video>

after.mp4

1.9 MiB

before.mp4

1.4 MiB

Pablo Vazquez approved these changes 2023-09-26 12:42:54 +02:00

Harley Acheson commented

2023-09-26 16:58:17 +02:00

Hmmm... I think it would be best to limit this change to the overlays. I am setting it correctly in this place, but in all the other places they are simply failing to set an output size and using what is previously. Therefore I should, for now, set the size back to the arbitrary 11 at the end of the text overlay routines.

Harley Acheson added 2 commits 2023-09-26 20:24:42 +02:00

887ac4f45b Merge branch 'main' of projects.blender.org:blender/blender into TextOverlaySize

buildbot/vexp-code-patch-coordinator Build done. Details

113723951a Ensure this change only affects text overlays.

Harley Acheson commented

2023-09-26 20:26:44 +02:00

@pablovazquez - This now only affect the text overlays. Anything else not being properly set to a text style size would have to be dealt with in those code locations.

👍 1

Harley Acheson commented

2023-09-26 20:51:54 +02:00

@blender-bot build

Pablo Vazquez commented

2023-09-26 21:23:50 +02:00

@pablovazquez - This now only affect the text overlays. Anything else not being properly set to a text style size would have to be dealt with in those code locations.

As agreed on during the meeting let's go with this and tackle this in the future. We shouldn't hardcode font sizes.

> @pablovazquez - This now only affect the text overlays. Anything else not being properly set to a text style size would have to be dealt with in those code locations. As agreed on during the meeting let's go with this and tackle this in the future. We shouldn't hardcode font sizes.

Harley Acheson merged commit e64e39e3d0 into main

2023-09-26 23:07:36 +02:00

Harley Acheson referenced this issue from a commit

2023-09-26 23:07:37 +02:00

UI: Change Overlay Text Size with Label Text Style

Harley Acheson deleted branch TextOverlaySize

2023-09-26 23:07:38 +02:00

Colin Basnett referenced this issue from a commit

2023-09-27 07:30:23 +02:00

UI: Change Overlay Text Size with Label Text Style

Nate Rupsis referenced this issue from a commit

2023-09-28 20:19:25 +02:00