Geometry Nodes: Move node tools out of experimental #112927

Hans Goudey · 2023-09-26T23:40:26+02:00

Hans Goudey commented

2023-09-26 23:40:26 +02:00

See #101778

❤️ 1

Hans Goudey added the

Interest

Geometry Nodes

label 2023-09-26 23:40:42 +02:00

Hans Goudey requested review from Dalai Felinto 2023-09-26 23:40:48 +02:00

Hans Goudey added this to the 4.0 milestone 2023-09-26 23:40:52 +02:00

Dalai Felinto commented

2023-09-27 10:47:24 +02:00

@SimonThommes any final words (or last minutes second thoughts) or can we confidently go for it for 4.0?

Jacques Lucke reviewed 2023-09-27 12:32:55 +02:00

Jacques Lucke left a comment

Only saw this patch now after the branch split..

source/blender/makesdna/DNA_userdef_types.h Outdated

						
				@ -709,7 +709,6 @@ typedef struct UserDef_Experimental {

				  char use_grease_pencil_version3;

				  char enable_overlay_next;

				  char use_new_volume_nodes;

				  char use_node_group_operators;

Jacques Lucke commented

2023-09-27 12:31:53 +02:00

Missing padding update below.

Simon Thommes approved these changes 2023-09-27 13:05:23 +02:00

Simon Thommes left a comment

For me the changes you made since we last spoke are all sound after giving this a quick spin.

I have no clue how much too late we are for 4.0 at this point. Realised too late that this was kind of waiting for me...

I do have some points I want to mention, as their status is unclear to me.

I only saw the non-assets separator when there are also unassigned assets. I personally don't see the reason to hide it otherwise. Seems to be information that is still useful in any case.
I wasn't involved with the menu entry (unassigned icon) discussion as it was signed off by the UI module, so I'm not sure what the conclusion was, but I remember that we wanted to move away from using the icon like that. Just want to make sure this was signed off.
The fact that the tool context is not remembered between switching to modifier and back to tool is a bug from my perspective
Tool nodes like the selection should ideally be indicated as such when nesting in a non-tool context. Not sure if this is easy to add or even something that should be done in bcon3. Imo that can also follow in the next release anyways, but shouldn't be forgotten

Other than these small caveats this is good for me

For me the changes you made since we last spoke are all sound after giving this a quick spin. I have no clue how much too late we are for 4.0 at this point. Realised too late that this was kind of waiting for me... I do have some points I want to mention, as their status is unclear to me. - I only saw the non-assets separator when there are also unassigned assets. I personally don't see the reason to hide it otherwise. Seems to be information that is still useful in any case. - I wasn't involved with the menu entry (unassigned icon) discussion as it was signed off by the UI module, so I'm not sure what the conclusion was, but I remember that we wanted to move away from using the icon like that. Just want to make sure this was signed off. - The fact that the tool context is not remembered between switching to modifier and back to tool is a bug from my perspective - Tool nodes like the selection should ideally be indicated as such when nesting in a non-tool context. Not sure if this is easy to add or even something that should be done in bcon3. Imo that can also follow in the next release anyways, but shouldn't be forgotten Other than these small caveats this is good for me

Dalai Felinto commented

2023-09-27 13:59:15 +02:00

Agree with most of Simon points (the exception being the icon on the viewport seemed to have been received ok iirc).

To be clear I imagine you don’t expect the separator to show when one of the “categories” is empty, but the Non-Assets label to be present even if only Non-Asset modifiers/tools are around.

I haven’t tested the latest patch so I may be missing something here

Agree with most of Simon points (the exception being the icon on the viewport seemed to have been received ok iirc). To be clear I imagine you don’t expect the separator to show when one of the “categories” is empty, but the Non-Assets label to be present even if only Non-Asset modifiers/tools are around. I haven’t tested the latest patch so I may be missing something here

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Geometry Nodes: Move node tools out of experimental #112927