blender/blender
162
514
Fork 779
Code Issues 6.8k Pull Requests 931 Projects 19 Wiki Activity

Node Tools Overview #101778

New Issue
Closed
opened 2022-10-12 20:26:04 +02:00 by Hans Goudey · 5 comments
Hans Goudey commented 2022-10-12 20:26:04 +02:00
Member
Copy Link

Background

With node group assets becoming more prevalent and geometry nodes becoming essential
for manipulating geometry in Blender, we want to add the ability to implement operators
with geometry node groups.

Relevant node groups would need a geometry input and output, and could have other inputs (and possibly outputs), with similar mappings as the geometry nodes modifier.

Additionally, specific inputs could be marked as editable modally, for example, a "Factor" input could be controlled by moving the mouse cursor left or right.

The specific data design still needs to be settled on (i.e. is the node group an operator, or does an operator reference a node group?).

Design

  • The node group itself is the operator asset
  • Geometry nodes gets new input nodes
    • Selection
    • Mouse coordinates
    • View transform
    • 3D cursor location
    • etc.
  • Geometry node groups with these input nodes can only be used as operators
    • This design is similar to the shared node groups between shader and geometry nodes, for example.
  • The group outputs are used to adjust the output geometry
    • The geometry output will adjust the "active" geometry
    • We might need to store a specific mapping for outputs, but relying on the name is a start
  • The project is "completely finished" when any existing edit mode operator could be implemented with nodes, though realistically that won't be achieved any time soon.

Implementation

Organized by priority in each category

4.0 Targets

Changes needed to move the feature out of experimental and enable it in the release

Polishing

Not necessarily required for a release in main

  • Show visual difference for tool nodes in modifier context
  • Show visual difference for viewer and simulation nodes in tool context
  • Resolve flickering in asset browser when using redo panel
  • Support for node warnings 6ba9ee88c8
  • Add support for evaluating output attributes

Milestone 2

The second phase of the project, after the fundamentals are working well

  • Object mode support 3fcd9c9425
  • Support socket inspection 740d1fbc4b
  • Avoid unnecessary depsgraph evaluation b3ecfcd77d
  • Data-block inputs in redo panel
    • Initial name-based data-block support 65803f262f
    • Add UI for data-block pickers backed by session_uid
  • Option to show settings in popup before operation starts
  • Tool specific nodes
    • Sculpt "soft selection" input and set
    • View transform 83ed92d533
    • Mouse position ce224fe401
    • Deformed positions from object evaluation
  • "Wait for cursor" option 23ebc45f70 ce224fe401
  • Store operator properties for the next execution

Modal Operators

The "modal node tools" project

Use Cases and Ideas

  • Mesh sculpt "face set extract"
  • Mesh sculpt "mask extract"
  • Lasso selection operator
## Background With node group assets becoming more prevalent and geometry nodes becoming essential for manipulating geometry in Blender, we want to add the ability to implement operators with geometry node groups. Relevant node groups would need a geometry input and output, and could have other inputs (and possibly outputs), with similar mappings as the geometry nodes modifier. Additionally, specific inputs could be marked as editable modally, for example, a "Factor" input could be controlled by moving the mouse cursor left or right. The specific data design still needs to be settled on (i.e. is the node group an operator, or does an operator reference a node group?). ## Design - The node group itself is the operator asset - Geometry nodes gets new input nodes - Selection - Mouse coordinates - View transform - 3D cursor location - etc. - Geometry node groups with these input nodes can only be used as operators - This design is similar to the shared node groups between shader and geometry nodes, for example. - The group outputs are used to adjust the output geometry - The geometry output will adjust the "active" geometry - We _might_ need to store a specific mapping for outputs, but relying on the name is a start - The project is "completely finished" when any existing edit mode operator could be implemented with nodes, though realistically that won't be achieved any time soon. ## Implementation _Organized by priority in each category_ ### 4.0 Targets _Changes needed to move the feature out of experimental and enable it in the release_ - [x] Initial basic feature for curves sculpt mode e4cc91a6113f14418b5d8f2a0aace252dc3949d8 - [x] Allow controlling which modes assets are available in fd9d22ba57d75b278a0350492c5eab2d39d39070 - [x] Update 3D view menus dynamically (avoid need to restart Blender) cc83951951efc28411960d950435224e8d06606c - [x] #114102 Make object info node geometry output work properly 66c1ca7419f7393b56b821dacd45d40127481ac1 - [x] #111529 Show menus for unassigned node group assets d2d4de8c710c4e8e648a86f904e6436133664836 - [x] Tool specific nodes - [x] Selection input e3e6fb8ecf8252344e9bfc9dc255bf7f722aa5f0 - [x] Set selection e3e6fb8ecf8252344e9bfc9dc255bf7f722aa5f0 - [x] 3D cursor e3e6fb8ecf8252344e9bfc9dc255bf7f722aa5f0 - [x] Sculpt face sets input e3e6fb8ecf8252344e9bfc9dc255bf7f722aa5f0 - [ ] Node group inputs displayed in the redo panel - [x] Initial input drawing bc393c403325c956ec4e83eeb072a9bdb2e7824d - [x] Display node group name in panel title f0467b4615b366f34f0daae81ef717c342e8f520 ee1ee584ded3b76fdd9b661244274af850b08fa9 - [ ] Add attribute search - [x] Don't draw redo panel when there are no inputs c59d998ce524e37c2449694602fb6d57b6d292fa - [x] #111523 Improved default traits b4dc16f32d92a2fbc140abfe6eb438ff11b5d5e8 - [x] #111524 Finalize trait popover locations 2cb34f7c0df731b903accbd24c3881134885d684 - [x] Shortcut support 65591b2c8cc83b024bc0a283bae1bbeb7ee85132 70ffc7a2de41fa75a9ace68919390bd21ee6f7b9 - [x] Quick favorite support 65591b2c8cc83b024bc0a283bae1bbeb7ee85132 - [x] #111526 Filter data-block selector based on tool/modifier option 1c51f74cb495a76d2b243c809cfcc2b41ec26494 - [x] Publish the user manual ### Polishing _Not necessarily required for a release in main_ - [ ] Show visual difference for tool nodes in modifier context - [ ] Show visual difference for viewer and simulation nodes in tool context - [ ] Resolve flickering in asset browser when using redo panel - [x] Support for node warnings 6ba9ee88c8fa8e645c51a5d7c9125c1ef7e04ed2 - [ ] Add support for evaluating output attributes ### Milestone 2 _The second phase of the project, after the fundamentals are working well_ - [x] Object mode support 3fcd9c94255f28c3a9d704b2dc1985682d07c419 - [x] Support socket inspection 740d1fbc4b134a3ea11d67ccd2ed5b28ef27767d - [x] Avoid unnecessary depsgraph evaluation b3ecfcd77d6392005b773a5eaad4c0337a1c0e52 - [x] Data-block inputs in redo panel - [x] Initial name-based data-block support 65803f262fc788de4c59c0d1b27ada1e3ad7bea4 - [x] Add UI for data-block pickers backed by session_uid - [ ] Option to show settings in popup before operation starts - [ ] Tool specific nodes - [x] Sculpt "soft selection" input and set - [x] View transform 83ed92d533f148d60ea210226d1c09b8d54ce59c - [x] Mouse position ce224fe4010af75c85b300151363dbc37fbbcee6 - [ ] Deformed positions from object evaluation - [x] "Wait for cursor" option 23ebc45f700b7670616294b450337ff0a22f7a4b ce224fe4010af75c85b300151363dbc37fbbcee6 - [ ] Store operator properties for the next execution ### Modal Operators _The "modal node tools" project_ ## Use Cases and Ideas - [ ] Mesh sculpt "face set extract" - [ ] Mesh sculpt "mask extract" - [ ] Lasso selection operator
👀 1 ❤️ 7
Iliya Katushenock commented 2022-10-12 20:28:53 +02:00
Member
Copy Link

It would be useful to provide a module for converting custom panel settings to input sockets as part of the input sockets signature.

It would be useful to provide a module for converting custom panel settings to input sockets as part of the input sockets signature.
Dalai Felinto added this to the Nodes & Physics project 2023-02-27 15:24:57 +01:00
Hans Goudey added this to the 3.6 LTS milestone 2023-02-28 20:11:18 +01:00
Hans Goudey modified the milestone from 3.6 LTS to 4.0 2023-06-26 21:07:57 +02:00
Hans Goudey changed title from Node group operators to Node Tools Overview 2023-09-05 16:36:59 +02:00
Dalai Felinto commented 2023-09-25 10:54:54 +02:00
Owner
Copy Link

Some issues I currently still have with Node Tools:

  • I cannot add custom shortcuts

    • Go to Context Menu > Assign Shortcut, set e.g., "A"
    • Nothing happens (A doesn't show as the shortcut for this menu entry).
    • Repeat that will get a crash bpy.data.window_managers["WinMan"].(null) = 'A' # Property

  • Tool popover layout always "inactive", regardless of the checkbox value:

image

  • Cannot add tools to "sub-menus", for example to Mesh > Delete:

image

  • I still run into No asset found at path "NodeTree/Tool" in some cases.

Not a bug, but nonetheless:

  • No way to make a tool input to take only values (not be a field) - and "values" should be the default I think, at least for tools:

image

Some issues I currently still have with Node Tools: - [x] I cannot add custom shortcuts - Go to Context Menu > Assign Shortcut, set e.g., "A" - Nothing happens (A doesn't show as the shortcut for this menu entry). - Repeat that will get a crash `bpy.data.window_managers["WinMan"].(null) = 'A' # Property` - [x] Tool popover layout always "inactive", regardless of the checkbox value: ![image](/attachments/055d6009-3cd9-4253-8e1a-7ea7051d8f46) - [x] Cannot add tools to "sub-menus", for example to `Mesh > Delete`: ![image](/attachments/fef318c5-3d03-4724-8d1d-29b62087078c) - [ ] I still run into `No asset found at path "NodeTree/Tool"` in some cases. --- Not a bug, but nonetheless: - [x] No way to make a tool input to take only values (not be a field) - and "values" should be the default I think, at least for tools: ![image](/attachments/368f614f-90d4-47b3-872f-654f65926231)
image.png
6.3 KiB
image.png
11 KiB
image.png
7.8 KiB
Sun Kim commented 2023-10-07 09:41:10 +02:00
Contributor
Copy Link

I think the warnings only displayed in modifier panels (like the one below) should be visible when making tools.

blender_vO0uEax4uI.png

Maybe the warnings should have displayed somewhere inside the node editor to begin with? (Like in header as other warnings?)

I think the warnings only displayed in modifier panels (like the one below) should be visible when making tools. ![blender_vO0uEax4uI.png](/attachments/21ea5995-a74d-40ee-b155-41b215d9a7b9) Maybe the warnings should have displayed somewhere inside the node editor to begin with? (Like in header as other warnings?)
blender_vO0uEax4uI.png
13 KiB
Dwayne-Slater commented 2024-07-06 12:12:11 +02:00
Copy Link

Wondering about live preview/update support. Since mouse position is exposed it seems like a natural next step.

Tools should be able to receive events on each live update. e.g. mouse left click or keyboard enter. Events are delivered via scene input booleans. In this new mode tools would be responsible for committing or cancelling. This would probably go on a new "Tool output" node (like group output, but for tool specific controls).

Still not sure about incremental editing. Maybe group outputs would be used as inputs on the next live update. This also requires access to a time delta. Imagine a custom sculpting tool accumulating edits across live updates.

Wondering about live preview/update support. Since mouse position is exposed it seems like a natural next step. Tools should be able to receive events on each live update. e.g. mouse left click or keyboard enter. Events are delivered via scene input booleans. In this new mode tools would be responsible for committing or cancelling. This would probably go on a new "Tool output" node (like group output, but for tool specific controls). Still not sure about incremental editing. Maybe group outputs would be used as inputs on the next live update. This also requires access to a time delta. Imagine a custom sculpting tool accumulating edits across live updates.
Hans Goudey commented 2024-11-19 02:25:33 +01:00
Author
Member
Copy Link

Think I'll close this task. Further development like modal node tools (like live update mentioned in the previous comment) is not tracked here anyway.

Think I'll close this task. Further development like modal node tools (like live update mentioned in the previous comment) is not tracked here anyway.
Blender Bot added
Status
Archived
 and removed
Status
Confirmed
 labels 2024-11-19 02:25:41 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset System
Asset datablocks, libraries, browser and shelf

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Code Documentation
Code comments, Python/RNA API descriptions

  
Interest
Collada

  
Interest
Compatibility
Backward and forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Viewport & EEVEE

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Wayland windowing on Unix

  
Interest
Workbench

  
Interest: X11

Xorg/X11 windowing

  
Legacy
Asset Browser Project

Archived

  
Legacy
Blender 2.8 Project

Archived

  
Legacy
Milestone 1: Basic, Local Asset Browser

Archived

  
Legacy
OpenGL Error

Archived

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Module
Viewport & EEVEE

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Severity
High

  
Severity
Low

  
Severity
Normal

  
Severity
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

Archived

  
Type
Report

Archived

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
4.0
Projects
Clear projects
No project
Nodes & Physics
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#101778
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?