Geometry Nodes: Show uncategorized assets in separate menus #112355
No reviewers
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#112355
Loading…
Reference in New Issue
No description provided.
Delete Branch "HooglyBoogly/blender:assets-uncategorized"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
In the add modifier menu, 3D viewport menus for node tools, and the node
editor add menu, assets not in catalogs are added to an "No Catalog"
menu rather than not being accessible at all.
This makes the default behavior when adding a node tool "not broken"
so at least something happens by default. The question of "How do I
add a catalog?" is much better than "Why didn't anything happen?"
Implements #111529
See #101778
Hans Goudey referenced this pull request2023-09-14 05:18:11 +02:00
I think we need to add a separator between the other Asset catalogs and the Uncategorized.
Otherwise we will either have it out of order. Let's say we also have a Vertex catalog:
e.g.,
Or have Uncategorized mingled between the others:
Neither option is very good.
Agreed. I had the same idea, and there are separators in the PR. Looks like I took the screenshots before that by mistake though.
Quick look over the code, looks fine. The need for special handling is a bit annoying, but not too bad.
Design: I don't really like "Uncategorized". These are catalogs, not categories. People already tend to use the wrong term, I want them to learn the correct one and not contribute to the confusion. Looking for "catalog" related operators in search menus, the asset browser or the manual will lead them nowhere.
What's the reason to not use "Unassigned", like the asset browser? Just thinking about alternatives... The word "uncataloged" seems to exist, but it's a bit awkward I guess. I think I still prefer that though. Some more alternatives: "No Catalog", "Not Cataloged", "More", "More Assets", ...
Would also be good to set a
MenuType.description
, to further help users (also for the other asset add menus).I like "No Catalog"! It's a bit more ugly to have in the header consistently, but that's sort of the point, and on the off chance users have heard the word "catalog" in relation with the asset system, it would help tell where to go.
I'll change that and add menu descriptions.
How should we handle assets that we can't find the catalog for (e.g. after the catalog was deleted)? In the asset browser we include them under "Unassigned". Maybe we should include them here too? You should be able to use
AssetCatalogService::is_catalog_known()
for that.