Fix #112642: Anchor Word Start For Double-click Word Select #113037

Harley Acheson · 2023-09-29T00:25:55+02:00

Harley Acheson commented

2023-09-29 00:25:55 +02:00

In Interface text inputs, when double-clicking to select a word, set
the "initial selection position" to the beginning of the word. This way
you can continue to select forward by dragging before releasing mouse.

The behavior described in #112642 is very specific. You double-click on a word to select, but do not release the mouse at the end of it. Instead keep the mouse depressed and then drag to the right to select more.

This PR restores the behavior to what it was like in 3.5 and earlier. When the word is selected we set sel_pos_init to the word start. That way the selection stays anchored to the start of the word while you drag. Of course if you lift your mouse and make a new selection that position is reset because sel_pos_init is always set on mouse press.

In Interface text inputs, when double-clicking to select a word, set the "initial selection position" to the beginning of the word. This way you can continue to select forward by dragging before releasing mouse. --- The behavior described in #112642 is very specific. You double-click on a word to select, but do not release the mouse at the end of it. Instead keep the mouse depressed and then drag to the right to select more. This PR restores the behavior to what it was like in 3.5 and earlier. When the word is selected we set `sel_pos_init` to the word start. That way the selection stays anchored to the start of the word while you drag. Of course if you lift your mouse and make a new selection that position is reset because `sel_pos_init` is always set on mouse press.

Harley Acheson added 1 commit 2023-09-29 00:26:07 +02:00

15369d17db Fix #112642 : Anchor Word Start For Double-click Word Select

In Interface text inputs, when double-clicking to select a word, set
the "initial selection position" to the beginning of the word. This way
you can continue to select forward by dragging before releasing mouse.

Harley Acheson added this to the User Interface project 2023-09-29 00:26:41 +02:00

Harley Acheson merged commit 5ccb289ef7 into blender-v4.0-release

2023-09-29 00:28:07 +02:00

Harley Acheson referenced this issue from a commit

2023-09-29 00:28:08 +02:00

Fix #112642: Anchor Word Start For Double-click Word Select

Harley Acheson deleted branch Fix112621

2023-09-29 00:28:11 +02:00

nxo commented

2023-09-29 00:30:53 +02:00

First-time contributor

Is there something like sel_pos_end too so if you double click and drag backwards you can select the word and all the words to the left of it as well?

Harley Acheson commented

2023-09-29 00:36:32 +02:00

No, this is more like the "initial selection point". You see in use better when you click at some point, then drag to the right, and while dragging change direction and go back to the left. You see it remembers that initial insertion point.

Going both ways would take a bit of thinking. Unlike many similar programs we show both the selection and the text caret. And for now our text processing avoids showing the text cursor within a selection - it is always at the beginning or end,

No, this is more like the "initial selection point". You see in use better when you click at some point, then drag to the right, and while dragging change direction and go back to the left. You see it remembers that initial insertion point. Going both ways would take a bit of thinking. Unlike many similar programs we show both the selection and the text caret. And for now our text processing avoids showing the text cursor within a selection - it is always at the beginning or end,

nxo commented

2023-09-29 00:40:30 +02:00

First-time contributor

Ah, would it be possible if the last word is the one selected then the position is at the end?

Harley Acheson commented

2023-10-01 23:43:05 +02:00

Ah, would it be possible if the last word is the one selected then the position is at the end?

Yes, good idea. done here: #113125

> Ah, would it be possible if the last word is the one selected then the position is at the end? Yes, good idea. done here: https://projects.blender.org/blender/blender/pulls/113125

nxo commented

2023-10-06 01:29:32 +02:00

First-time contributor

Amazing! Thank you!!

Joseph Eagar referenced this issue from a commit

2023-10-07 21:46:16 +02:00

Fix #112642: Anchor Word Start For Double-click Word Select

Joseph Eagar referenced this issue from a commit

2023-10-07 21:46:17 +02:00

Fix #112642: Anchor Word Start For Double-click Word Select

Colin Basnett referenced this issue from a commit

2023-10-08 23:38:51 +02:00