I18n: make new bones and bone collections' names translatable #113171

Merged

Bastien Montagne merged 1 commits from pioverfour/blender:dp_fix_new_bone_names into blender-v4.0-release

2023-10-05 14:39:02 +02:00

Damien Picard commented

2023-10-02 19:30:09 +02:00

Member

Newly created bones and bone collections get a default name. Like
other types of data, these names should be translated if the user
enabled the translation of new data in the preferences.

This commit adds the appropriate DATA_() macro:

when creating a new armature;
when creating a new bone;
when creating a new bone collection through ANIM_bonecoll_new();
when ensuring that a new bone collection has a unique name;
when renaming a bone collection;
in the bone collection tests, to check that new bones have the
expected translated name.

It also sets the default value of the bone name in the
ARMATURE_OT_bone_primitive_add() operator to a null string instead
of "Bone", so that the default name may be chosen while checking for
unique names, since an empty string will default to the translation.

Newly created bones and bone collections get a default name. Like other types of data, these names should be translated if the user enabled the translation of new data in the preferences. This commit adds the appropriate `DATA_()` macro: - when creating a new armature; - when creating a new bone; - when creating a new bone collection through `ANIM_bonecoll_new()`; - when ensuring that a new bone collection has a unique name; - when renaming a bone collection; - in the bone collection tests, to check that new bones have the expected translated name. It also sets the default value of the bone name in the `ARMATURE_OT_bone_primitive_add()` operator to a null string instead of "Bone", so that the default name may be chosen while checking for unique names, since an empty string will default to the translation.

Damien Picard added the

labels 2023-10-02 19:30:09 +02:00

Damien Picard added 1 commit 2023-10-02 19:30:22 +02:00

da42183395 I18n: make new bones and bone collections' names translatable

Newly created bones and bone collections get a default name. Like
other types of data, these names should be translated if the user
enabled the translation of new data in the preferences.

This commit adds the appropriate `DATA_()` macro:
- when creating a new armature;
- when creating a new bone;
- when creating a new bone collection through `ANIM_bonecoll_new()`;
- when ensuring that a new bone collection has a unique name;
- when renaming a bone collection;
- in the bone collection tests, to check that new bones have the
  expected translated name.

It also sets the default value of the bone name in the
`ARMATURE_OT_bone_primitive_add()` operator to a null string instead
of "Bone", so that the default name may be chosen while checking for
unique names, since an empty string will default to the translation.

Damien Picard requested review from Bastien Montagne 2023-10-02 19:31:48 +02:00

Bastien Montagne approved these changes 2023-10-03 17:54:22 +02:00

Bastien Montagne left a comment

Owner

LGTM, will add the Animation team as reviewer too first, though.

LGTM, will add the Animation team as reviewer too first, though.

Bastien Montagne requested review from Nathan Vegdahl 2023-10-03 17:54:40 +02:00

Bastien Montagne requested review from Sybren A. Stüvel 2023-10-03 17:54:40 +02:00

Sybren A. Stüvel added the

Animation & Rigging

label 2023-10-05 11:57:17 +02:00

Sybren A. Stüvel approved these changes 2023-10-05 11:58:16 +02:00

Sybren A. Stüvel left a comment

Member

This is super nice, thanks!

@mont29 given that this targets the translatability of Blender, do you think this could be merged for 4.0?

This is super nice, thanks! @mont29 given that this targets the translatability of Blender, do you think this could be merged for 4.0?

Damien Picard changed title from ~~I18n: make new bones and bone collections' names translatable~~ to I18n: make new bones and bone collections' names translatable

2023-10-05 12:35:02 +02:00

pioverfour changed target branch from main to blender-v4.0-release

2023-10-05 12:35:05 +02:00

Damien Picard commented

2023-10-05 12:35:42 +02:00

Author

Member

Oh yeah, sorry about that! I keep forgetting to choose the target branch when opening PRs :/

Oh yeah, sorry about that! I keep forgetting to choose the target branch when opening PRs :/

Sybren A. Stüvel commented

2023-10-05 12:39:30 +02:00

Member

Don't forget to also rebase your branch & force-push. Otherwise many 4.1 commits will end up in your PR.

Don't forget to also rebase your branch & force-push. Otherwise many 4.1 commits will end up in your PR.

Damien Picard commented

2023-10-05 12:41:54 +02:00

Author

Member

I just checked that it was indeed based on the 4.0 branch already. :)

I just checked that it was indeed based on the 4.0 branch already. :)

Bastien Montagne commented

2023-10-05 14:38:25 +02:00

Owner

Yes indeed, this should definitely go in 4.0.

Yes indeed, this should definitely go in 4.0.

Bastien Montagne referenced this issue from a commit

2023-10-05 14:39:00 +02:00

I18n: make new bones and bone collections' names translatable

Bastien Montagne merged commit 730bb2ee3e into blender-v4.0-release

2023-10-05 14:39:01 +02:00

Bastien Montagne deleted branch dp_fix_new_bone_names

2023-10-05 14:39:03 +02:00

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113171

No description provided.