Fix #102591: Improvements to Context Menu Path Operators #113216

Harley Acheson · 2023-10-03T18:38:45+02:00

Harley Acheson commented

2023-10-03 18:38:45 +02:00

Improvements to ui_but_menu_add_path_operators so that it properly
differentiates between files and directories even if the filepath is
not slash terminated. It will also not add the operators to the menu
if the filepath does not exist.

Right-clicking on a pathname input we get a context menu that might contain "Open File Externally" and/or "Open Location Externally". But the first problem is that it does not check if this location exists, and we do have times where the paths do not exist yet. This PR makes this function a bool so that can return false if the files do not exist.

The second problem is that the function does not properly differentiate between a file path and directory path. For a directory path that is not slash terminated it will assume it is a file path. This PR actually checks the path (BLI_is_dir) to see if it really is a directory path.

Improvements to `ui_but_menu_add_path_operators` so that it properly differentiates between files and directories even if the filepath is not slash terminated. It will also not add the operators to the menu if the filepath does not exist. --- Right-clicking on a pathname input we get a context menu that might contain "Open File Externally" and/or "Open Location Externally". But the first problem is that it does not check if this location exists, and we do have times where the paths do not exist yet. This PR makes this function a bool so that can return false if the files do not exist. The second problem is that the function does not properly differentiate between a file path and directory path. For a directory path that is not slash terminated it will assume it is a file path. This PR actually checks the path (BLI_is_dir) to see if it really is a directory path.

Harley Acheson added 1 commit 2023-10-03 18:38:57 +02:00

7ab0fb85b8 Fix #102591 : Improvements to Context Menu Path Operators

Improvements to `ui_but_menu_add_path_operators` so that it properly
differentiates between files and directories even if the filepath is
not slash terminated. It will also not add the operators to the menu
if the filepath does not exist.

Harley Acheson added 1 commit 2023-10-03 18:40:06 +02:00

cae6c83c5e Unwanted formatting changes.

Harley Acheson added this to the User Interface project 2023-10-03 18:43:21 +02:00

Harley Acheson merged commit e44f500be8 into blender-v4.0-release

2023-10-03 18:45:05 +02:00

Harley Acheson referenced this issue from a commit

2023-10-03 18:45:06 +02:00

Fix #102591: Improvements to Context Menu Path Operators

Harley Acheson deleted branch Fix102591

2023-10-03 18:45:10 +02:00

Colin Basnett referenced this issue from a commit

2023-10-08 23:38:52 +02:00