EEVEE-Next: Skip bake if there's not enough VRAM #113509

Miguel Pozo · 2023-10-10T18:38:33+02:00

Miguel Pozo commented

2023-10-10 18:38:33 +02:00

Skip the bake if there's not enough GPU memory to allocate all the required resources.
Print bake messages to the command line.

* Skip the bake if there's not enough GPU memory to allocate all the required resources. * Print bake messages to the command line.

Miguel Pozo added the

labels 2023-10-10 18:38:33 +02:00

Miguel Pozo added 2 commits 2023-10-10 18:38:47 +02:00

0dc02b1c53 Handle out of memory situations

ca31a171e3 Print bake errors

Miguel Pozo requested review from Clément Foucault 2023-10-10 18:40:19 +02:00

Clément Foucault requested changes 2023-10-10 19:27:25 +02:00

source/blender/draw/engines/eevee_next/eevee_irradiance_cache.cc Outdated

						
				@ -951,3 +952,3 @@

				  }

				  /* TODO(fclem): Check for GL limit and abort if the surfel cache doesn't fit the GPU memory. */

				  if (capture_info_buf_.surfel_len > surfels_buf_.size() && GPU_mem_stats_supported()) {

Clément Foucault commented

2023-10-10 19:27:13 +02:00

While this is nice to check when it is supported, we should also check GL_MAX_SHADER_STORAGE_BLOCK_SIZE in any cases.

While this is nice to check when it is supported, we should also check `GL_MAX_SHADER_STORAGE_BLOCK_SIZE` in any cases.

Miguel Pozo commented

2023-10-10 20:40:39 +02:00

There was no way to query that info, so I made a separate commit to add a GPU_max_storage_buffer_size function.

There was no way to query that info, so I made a separate commit to add a `GPU_max_storage_buffer_size` function.

👍 1

Clément Foucault commented

2023-10-10 19:28:17 +02:00

Note: Should we maybe check before allocating the grid textures too?

Yes. Allocating the grid texture can return a null texture it it doesn't fit the implementation limits.

> Note: Should we maybe check before allocating the grid textures too? Yes. Allocating the grid texture can return a null texture it it doesn't fit the implementation limits.

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

EEVEE-Next: Skip bake if there's not enough VRAM #113509