Fix #112935: Wrong window order handling on macOS 14 #113515

Merged
Sergey Sharybin merged 1 commits from Sergey/blender:fix_112935 into blender-v4.0-release 2023-10-11 19:11:49 +02:00

The issue was caused by the custom code which was ensuring that closing
About window does not leave application without any key
windows.

Turns out that the windowWillClose is executed when menu is closed,
forcing the custom code to ensure a key window.

The solution is to only perform manual re-ordering if the closing window
was a key window. This both keeps old behavior of ensuring there is a
key window after closing About, and solves the ordering issues when a
window is created or activated via menus.

The issue was caused by the custom code which was ensuring that closing About window does not leave application without any key windows. Turns out that the windowWillClose is executed when menu is closed, forcing the custom code to ensure a key window. The solution is to only perform manual re-ordering if the closing window was a key window. This both keeps old behavior of ensuring there is a key window after closing About, and solves the ordering issues when a window is created or activated via menus.
Sergey Sharybin added the
Platform
macOS
Module
Platforms, Builds & Tests
labels 2023-10-10 20:22:56 +02:00
Sergey Sharybin requested review from Brecht Van Lommel 2023-10-10 20:23:13 +02:00
Miguel Pozo added a new dependency 2023-10-10 20:37:28 +02:00
Miguel Pozo removed a dependency 2023-10-10 20:37:37 +02:00
Author
Owner

Tested on Ventura. Works like a charm!

Tested on Ventura. Works like a charm!
Brecht Van Lommel approved these changes 2023-10-11 16:40:05 +02:00
Sergey Sharybin changed title from Fix #112935: Wrong window order handling on macOS 14 to Fix #112935: Wrong window order handling on macOS 14 2023-10-11 19:08:24 +02:00
Sergey Sharybin changed target branch from main to blender-v4.0-release 2023-10-11 19:08:26 +02:00
Sergey Sharybin force-pushed fix_112935 from efca066e5c to b116800dca 2023-10-11 19:11:16 +02:00 Compare
Sergey Sharybin merged commit 534e7f4470 into blender-v4.0-release 2023-10-11 19:11:49 +02:00
Sergey Sharybin deleted branch fix_112935 2023-10-11 19:11:53 +02:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
Interest
Freestyle
Interest
Geometry Nodes
Interest
glTF
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#113515
No description provided.