Fix #113803: some cloth weight groups change on reordering #114032

Merged
Philipp Oeser merged 1 commits from pioverfour/blender:dp_fix_113803 into blender-v4.1-release 2024-02-09 15:39:18 +01:00
Member

When reordering vertex groups on a mesh, some cloth properties would
get affected by another group, because they were based on group index
instead of name.

This issue was already handled by
BKE_object_defgroup_remap_update_users() for some properties, but
not all.

This commit extends the function for missing properties: Shrinking,
Shear, Internal Springs, Pressure, Self Colllisions and Object
Collisions.

When reordering vertex groups on a mesh, some cloth properties would get affected by another group, because they were based on group index instead of name. This issue was already handled by `BKE_object_defgroup_remap_update_users()` for some properties, but not all. This commit extends the function for missing properties: Shrinking, Shear, Internal Springs, Pressure, Self Colllisions and Object Collisions.
Damien Picard changed target branch from blender-v4.0-release to main 2023-12-12 16:23:23 +01:00
Damien Picard added the
Module
Nodes & Physics
label 2024-01-03 21:30:38 +01:00
Damien Picard force-pushed dp_fix_113803 from 04f9c07aa0 to a8710d3040 2024-02-08 18:36:40 +01:00 Compare
Damien Picard changed target branch from main to blender-v4.1-release 2024-02-08 18:36:46 +01:00
Member

Thx @pioverfour .

There still seems to be something wrong with reordering.
Moving various vertex groups up and down, I can still see the Bending vertexgroup changing...

Not sure yet why that is, checking...

Thx @pioverfour . There still seems to be something wrong with reordering. Moving various vertex groups up and down, I can still see the Bending vertexgroup changing... Not sure yet why that is, checking...
Philipp Oeser added this to the Modeling project 2024-02-09 09:05:11 +01:00
Philipp Oeser added
Interest
Nodes & Physics
and removed
Module
Nodes & Physics
labels 2024-02-09 09:05:23 +01:00
Member

Thx @pioverfour .

There still seems to be something wrong with reordering.
Moving various vertex groups up and down, I can still see the Bending vertexgroup changing...

Not sure yet why that is, checking...

Oh boy, that was a mistake on my side, sorry, was applying the patch wrong... facepalm...

> Thx @pioverfour . > > There still seems to be something wrong with reordering. > Moving various vertex groups up and down, I can still see the Bending vertexgroup changing... > > Not sure yet why that is, checking... Oh boy, that was a mistake on my side, sorry, was applying the patch wrong... facepalm...
Philipp Oeser approved these changes 2024-02-09 09:33:36 +01:00
Philipp Oeser left a comment
Member

So, LGTM, thx!

Think this is actually straightforward and ready to land

So, LGTM, thx! Think this is actually straightforward and ready to land
Author
Member

So, LGTM, thx!

Think this is actually straightforward and ready to land

Great, thanks! I can’t land PRs myself, though.

> So, LGTM, thx! > > Think this is actually straightforward and ready to land Great, thanks! I can’t land PRs myself, though.
Member

@blender-bot build

@blender-bot build
Philipp Oeser merged commit 990c0ad42c into blender-v4.1-release 2024-02-09 15:39:18 +01:00
Philipp Oeser deleted branch dp_fix_113803 2024-02-09 15:39:24 +01:00
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#114032
No description provided.