blender
/
blender
134
399
Fork 581
Code Issues 6.3k Pull Requests 757 Projects 19 Wiki Activity

Anim: Add "Add/delete" track operations to NLA context menu #114202

Merged
Nate Rupsis merged 8 commits from nrupsis/blender:NLA-context-menu into main 2023-11-30 17:15:16 +01:00
Conversation 8 Commits 8 Files Changed 1 +7
Nate Rupsis commented 2023-10-27 18:23:04 +02:00
Member
Copy Link

Updating NLA context menu, adding in more relevant track operations (tracks add, tracks add above, tracks delete).

Old (4.0)
image

New (4.1)
image

Updating NLA context menu, adding in more relevant track operations (tracks add, tracks add above, tracks delete). Old (4.0) ![image](/attachments/436697b1-33d5-488c-9dcf-140134186828) New (4.1) ![image](/attachments/547641a8-49ff-473d-a9ec-5c326bc04939)
image.png
114 KiB
image.png
24 KiB
Nate Rupsis added 1 commit 2023-10-27 18:23:20 +02:00
Nate Rupsis changed title from Anim: Update NLA "Channel Context Menu" to be "NLA Tracks" with some more options to Anim: Update NLA "Channel Context Menu" to be "NLA Tracks" + add/delete operations 2023-10-27 18:26:35 +02:00
Nate Rupsis changed title from Anim: Update NLA "Channel Context Menu" to be "NLA Tracks" + add/delete operations to WIP: Anim: Update NLA "Channel Context Menu" to be "NLA Tracks" + add/delete operations 2023-10-27 18:46:15 +02:00
Nate Rupsis changed title from WIP: Anim: Update NLA "Channel Context Menu" to be "NLA Tracks" + add/delete operations to Anim: Update NLA "Channel Context Menu" to "NLA Tracks" + add/delete operations 2023-11-08 23:53:16 +01:00
Nate Rupsis requested review from Sybren A. Stüvel 2023-11-08 23:53:23 +01:00
Nate Rupsis requested review from Harley Acheson 2023-11-08 23:53:32 +01:00
Nate Rupsis added the
Module
Animation & Rigging
 label 2023-11-08 23:53:39 +01:00
Nate Rupsis commented 2023-11-10 19:23:22 +01:00
Author
Member
Copy Link

Suggestion: "Remove Empty Animation Data" -> "Remove Empty" ?

The user is already in the context of Tracks, and that's really what they're cleaning up.

Suggestion: "Remove Empty Animation Data" -> "Remove Empty" ? The user is already in the context of Tracks, and that's _really_ what they're cleaning up.
Harley Acheson commented 2023-11-11 18:34:21 +01:00
Member
Copy Link

Hey, I'm all for changing the terminology of NLA "Channel" to "Track" if that is what you guys want. But...

It could get a bit more involved to make this change completely. There are a few other client-facing uses of "Channel", like in operator names, in some error messages, etc. There is a keymap name of "NLA Channels" that contains "channel" items, including one that calls this context menu:

image

So again, no problem about changing it, but I just wanted to make sure you know you could be chasing down inconsistencies for a while.

Hey, I'm all for changing the terminology of NLA "Channel" to "Track" if that is what you guys want. But... It could get a bit more involved to make this change completely. There are a few other client-facing uses of "Channel", like in operator names, in some error messages, etc. There is a keymap name of "NLA Channels" that contains "channel" items, including one that calls this context menu: ![image](/attachments/d4b9609e-52a9-4411-a9a1-a598c958dd76) So again, no problem about changing it, but I just wanted to make sure you know you could be chasing down inconsistencies for a while.
image.png
52 KiB
Nate Rupsis commented 2023-11-13 05:20:43 +01:00
Author
Member
Copy Link

Hey, I'm all for changing the terminology of NLA "Channel" to "Track" if that is what you guys want. But...

I personally think we should change it across the board. I'm 98% confident the Animation & Rigging module will agree, but I'll run it by them again.

I'm also happy to do the work. I can either update this PR or create follow up(s), whatever your preference is.

> Hey, I'm all for changing the terminology of NLA "Channel" to "Track" if that is what you guys want. But... I personally think we should change it across the board. I'm 98% confident the Animation & Rigging module will agree, but I'll run it by them again. I'm also happy to do the work. I can either update this PR or create follow up(s), whatever your preference is.
Nate Rupsis added 3 commits 2023-11-15 19:12:36 +01:00
Nate Rupsis changed title from Anim: Update NLA "Channel Context Menu" to "NLA Tracks" + add/delete operations to Anim: Add "Add/delete" track operations to NLA context menu 2023-11-15 19:13:39 +01:00
Nate Rupsis commented 2023-11-15 20:04:20 +01:00
Author
Member
Copy Link

@Harley Updating this PR to just be adding in new Track operators to the context menu. NLA channels rename has been moved to new PR

@Harley Updating this PR to just be adding in new Track operators to the context menu. NLA channels rename has been moved to [new PR](https://projects.blender.org/blender/blender/pulls/114932)
Nate Rupsis requested review from Nathan Vegdahl 2023-11-15 20:04:36 +01:00
Nate Rupsis requested review from Christoph Lendenfeld 2023-11-15 20:04:37 +01:00
Harley Acheson commented 2023-11-15 22:33:09 +01:00
Member
Copy Link

@nrupsis - NLA channels rename has been moved to new PR

That makes sense.

Ultimately these context menu items should be how you guys prefer it, so take any advice from me with very light weight.

I would consider expanding the description of the regular nla.tracks_add item so that both items are equally explicit on where the new track is positioned. Otherwise you have to make assumptions about the first item based on the name of the second one. "Add Tracks Below Selected" & "Add Tracks Above Selected" perhaps. That might make you think about what order they should be in.

If you do so you might find that the pair look a little awkward, both having such similar names. But add a separator after them and they would then look like a nice logical pair and the "add" items would have a separation from "delete" to help avoid accidents.

> @nrupsis - NLA channels rename has been moved to [new PR](https://projects.blender.org/blender/blender/pulls/114932) That makes sense. Ultimately these context menu items should be how **you guys** prefer it, so take any advice from me with very light weight. I would _consider_ expanding the description of the regular `nla.tracks_add` item so that both items are equally explicit on where the new track is positioned. Otherwise you have to make assumptions about the first item based on the name of the second one. "Add Tracks Below Selected" & "Add Tracks Above Selected" perhaps. That might make you think about what order they should be in. If you do so you might find that the pair look a little awkward, both having such similar names. But add a separator after them and they would then look like a nice logical pair and the "add" items would have a separation from "delete" to help avoid accidents.
Christoph Lendenfeld approved these changes 2023-11-16 11:27:44 +01:00
Christoph Lendenfeld left a comment
Member
Copy Link

in terms of functionality this is a clear yes
I agree with harley that it's probably better to be explicit in the label. If there is an "...above selected" there should be a "...below selected"
but giving my approval since I don't feel super strongly about that

in terms of functionality this is a clear yes I agree with harley that it's probably better to be explicit in the label. If there is an "...above selected" there should be a "...below selected" but giving my approval since I don't feel super strongly about that
Nate Rupsis added 2 commits 2023-11-21 22:17:57 +01:00
Nathan Vegdahl commented 2023-11-28 12:54:04 +01:00
Member
Copy Link

Tested it out. I like the direction a lot.

I think Add Tracks... -> Add Track ... would be better. It only adds a single track.

Also, at the moment both Add Tracks Above Selected and Add Tracks Below Selected add a track above the selected track, at least in my testing.

Tested it out. I like the direction a lot. I think `Add Tracks...` -> `Add Track ...` would be better. It only adds a single track. Also, at the moment both `Add Tracks Above Selected` and `Add Tracks Below Selected` add a track above the selected track, at least in my testing.
Nate Rupsis added 2 commits 2023-11-28 20:03:35 +01:00
Nate Rupsis commented 2023-11-28 20:06:44 +01:00
Author
Member
Copy Link

@nathanvegdahl ah, I guess the opposite of above_selected = True is not to add tracks below selected, rather just add em to the top of the stack...

If people think adding in "Add tracks below selected" option to the operator (and menu), I can add that as a follow up change.

@nathanvegdahl ah, I guess the opposite of `above_selected = True` is _not_ to add tracks below selected, rather just add em to the top of the stack... If people think adding in "Add tracks below selected" option to the operator (and menu), I can add that as a follow up change.
Nathan Vegdahl commented 2023-11-30 11:53:17 +01:00
Member
Copy Link

@nrupsis Ah, got it. Yeah, I think if there's an "add above" there should probably be an "add below". But agree that's better as follow up PR.

@nrupsis Ah, got it. Yeah, I think if there's an "add above" there should probably be an "add below". But agree that's better as follow up PR.
Nathan Vegdahl approved these changes 2023-11-30 11:53:49 +01:00
Nathan Vegdahl left a comment
Member
Copy Link

Looks good to me!

Looks good to me!
Harley Acheson approved these changes 2023-11-30 16:56:10 +01:00
Nate Rupsis merged commit da83b2951d into main 2023-11-30 17:15:16 +01:00
Nate Rupsis deleted branch NLA-context-menu 2023-11-30 17:15:18 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Sybren A. Stüvel
Christoph Lendenfeld
Nathan Vegdahl
Harley Acheson
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#114202
No description provided.
Delete Branch "nrupsis/blender:NLA-context-menu"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?