Nodes: add int and bool to shader nodegroups #115026

Merged

Brecht Van Lommel merged 3 commits from Diana-G/blender:shader-ints-bools into main

2024-01-10 20:09:46 +01:00

Diana G commented

2023-11-17 05:49:49 +01:00

Contributor

Ints and Bools work as expected in shader nodegroups. I've known users in the past used the python api to add sockets of these types to shader nodegroups as they could not be selected via the dropdown, but that no longer works in 4.0. So I was wondering if there was a reason it was not included in the dropdown (maybe some sorta technical reason or something).

Also, I'm not sure if I'm following the correct protocol for making a PR

Ints and [Bools](https://projects.blender.org/blender/blender/pulls/109576) work as expected in shader nodegroups. I've known users in the past used the python api to add sockets of these types to shader nodegroups as they could not be selected via the dropdown, but that no longer works in 4.0. So I was wondering if there was a reason it was not included in the dropdown (maybe some sorta technical reason or something). Also, I'm not sure if I'm following the correct protocol for making a PR

2023-11-16_23-03-23_blender.gif

299 KiB

❤️ 7 🎉 6

Diana G added 1 commit 2023-11-17 05:50:01 +01:00

buildbot/vexp-code-patch-coordinator Build done. Details

a6f9cf906f add int and bool to shader nodegroups

Iliya Katushenock added this to the Nodes & Physics project 2023-11-17 08:36:45 +01:00

Iliya Katushenock added the

Render & Cycles

EEVEE & Viewport

labels 2023-11-17 08:36:54 +01:00

Simarilius commented

2023-11-19 00:28:28 +01:00

First-time contributor

Also the fact their not supported any more isn't in the release notes

Also the fact their not supported any more isn't in the release notes

Nika Kutsniashvili commented

2023-11-19 09:26:23 +01:00

Contributor

I think you need to tag reviewers. You can ask on Nodes & Physics module chat

I think you need to tag reviewers. You can ask on [Nodes & Physics module chat](https://blender.chat/channel/nodes-physics-module)

Diana G commented

2023-11-20 19:13:08 +01:00

Author

Contributor

I think you need to tag reviewers. You can ask on Nodes & Physics module chat

I'm not sure how to do that, this is my first time really doing anything with blender development/etc

> I think you need to tag reviewers. You can ask on [Nodes & Physics module chat](https://blender.chat/channel/nodes-physics-module) I'm not sure how to do that, this is my first time really doing anything with blender development/etc

Hans Goudey requested review from Brecht Van Lommel 2023-11-20 19:55:51 +01:00

Hans Goudey commented

2023-11-20 19:56:39 +01:00

Member

Seems reasonable to me, I guess this was already possible in the past through Python. It's a bit weird though, since they aren't really passed as integers or booleans at all. Brecht would probably know best whether this is the right way to go.

Seems reasonable to me, I guess this was already possible in the past through Python. It's a bit weird though, since they aren't really passed as integers or booleans at all. Brecht would probably know best whether this is the right way to go.

Nika Kutsniashvili commented

2023-11-20 20:14:30 +01:00

Contributor

Seems reasonable to me, I guess this was already possible in the past through Python. It's a bit weird though, since they aren't really passed as integers or booleans at all. Brecht would probably know best whether this is the right way to go.

It's much needed UX tool, OSL shaders already have them, so they are present in Shader Nodes. It allows asset creators to restrict value to either 0 or 1 (or for example 0-1-2 for when choosing axis) and avoid anything in the middle. Currently we have to do math nodes for that behavior, but on user level it still looks like they can set value to 0.5 and get other result, so the property isn't communicated correctly to the user.

> Seems reasonable to me, I guess this was already possible in the past through Python. It's a bit weird though, since they aren't really passed as integers or booleans at all. Brecht would probably know best whether this is the right way to go. It's much needed UX tool, OSL shaders already have them, so they are present in Shader Nodes. It allows asset creators to restrict value to either 0 or 1 (or for example 0-1-2 for when choosing axis) and avoid anything in the middle. Currently we have to do math nodes for that behavior, but on user level it still looks like they can set value to 0.5 and get other result, so the property isn't communicated correctly to the user.

August R. commented

2023-11-20 20:15:25 +01:00

First-time contributor

I've used ints extensively in my nodegroups ever since i found the python command i could run to add them to my groups. Was really bummed out when i couldn't add them anymore with 4.0, hoping this gets accepted especially now that bools work as well, previously i just used an int between 0 and 1 for switches so having an actual checkbox would be fantastic

I've used ints extensively in my nodegroups ever since i found the python command i could run to add them to my groups. Was really bummed out when i couldn't add them anymore with 4.0, hoping this gets accepted especially now that bools work as well, previously i just used an int between 0 and 1 for switches so having an actual checkbox would be fantastic

Simarilius commented

2023-11-20 20:18:51 +01:00

First-time contributor

Seems reasonable to me, I guess this was already possible in the past through Python. It's a bit weird though, since they aren't really passed as integers or booleans at all. Brecht would probably know best whether this is the right way to go.

they are passed as ints, just the UI doesnt show it. had to switch things to floats and add extra round nodes to unbreak some nodetrees we had.

> Seems reasonable to me, I guess this was already possible in the past through Python. It's a bit weird though, since they aren't really passed as integers or booleans at all. Brecht would probably know best whether this is the right way to go. they are passed as ints, just the UI doesnt show it. had to switch things to floats and add extra round nodes to unbreak some nodetrees we had.

Diana G commented

2023-11-20 20:22:23 +01:00

Author

Contributor

Seems reasonable to me, I guess this was already possible in the past through Python. It's a bit weird though, since they aren't really passed as integers or booleans at all. Brecht would probably know best whether this is the right way to go.

they are passed as ints, just the UI doesnt show it. had to switch things to floats and add extra round nodes to unbreak some nodetrees we had.

actually afaik theyre casted to floats and passed around as such, since shader nodes only accept floats, etc. the functionality for ints to floats have existed for years afaik while bools being casted is a new thing with 4.0

> > Seems reasonable to me, I guess this was already possible in the past through Python. It's a bit weird though, since they aren't really passed as integers or booleans at all. Brecht would probably know best whether this is the right way to go. > > they are passed as ints, just the UI doesnt show it. had to switch things to floats and add extra round nodes to unbreak some nodetrees we had. actually afaik theyre casted to floats and passed around as such, since shader nodes only accept floats, etc. the functionality for ints to floats have existed for years afaik while bools being casted is a [new thing with 4.0](https://projects.blender.org/blender/blender/pulls/109576)

Simarilius commented

2023-11-20 20:24:45 +01:00

First-time contributor

Seems reasonable to me, I guess this was already possible in the past through Python. It's a bit weird though, since they aren't really passed as integers or booleans at all. Brecht would probably know best whether this is the right way to go.

they are passed as ints, just the UI doesnt show it. had to switch things to floats and add extra round nodes to unbreak some nodetrees we had.

actually afaik theyre casted to floats and passed around as such, since shader nodes only accept floats, etc. the functionality for ints to floats have existed for years afaik while bools being casted is a new thing with 4.0

Right, but that 'cast to floats' effectively does a round on them, so you get an integer value, which if you just set the socket to float you loose, which then breaks the shaders that were using them.

> > > Seems reasonable to me, I guess this was already possible in the past through Python. It's a bit weird though, since they aren't really passed as integers or booleans at all. Brecht would probably know best whether this is the right way to go. > > > > they are passed as ints, just the UI doesnt show it. had to switch things to floats and add extra round nodes to unbreak some nodetrees we had. > > actually afaik theyre casted to floats and passed around as such, since shader nodes only accept floats, etc. the functionality for ints to floats have existed for years afaik while bools being casted is a [new thing with 4.0](https://projects.blender.org/blender/blender/pulls/109576) Right, but that 'cast to floats' effectively does a round on them, so you get an integer value, which if you just set the socket to float you loose, which then breaks the shaders that were using them.

Diana G commented

2023-11-20 20:26:33 +01:00

Author

Contributor

Seems reasonable to me, I guess this was already possible in the past through Python. It's a bit weird though, since they aren't really passed as integers or booleans at all. Brecht would probably know best whether this is the right way to go.

they are passed as ints, just the UI doesnt show it. had to switch things to floats and add extra round nodes to unbreak some nodetrees we had.

actually afaik theyre casted to floats and passed around as such, since shader nodes only accept floats, etc. the functionality for ints to floats have existed for years afaik while bools being casted is a new thing with 4.0

Right, but that 'cast to floats' effectively does a round on them, so you get an integer value, which if you just set the socket to float you loose, which then breaks the shaders that were using them.

well yea, it displays to the user as an int (and therefore is locked to ints/whole numbers only) while technically internally its a float, preventing a user from entering in non whole values

> > > > Seems reasonable to me, I guess this was already possible in the past through Python. It's a bit weird though, since they aren't really passed as integers or booleans at all. Brecht would probably know best whether this is the right way to go. > > > > > > they are passed as ints, just the UI doesnt show it. had to switch things to floats and add extra round nodes to unbreak some nodetrees we had. > > > > actually afaik theyre casted to floats and passed around as such, since shader nodes only accept floats, etc. the functionality for ints to floats have existed for years afaik while bools being casted is a [new thing with 4.0](https://projects.blender.org/blender/blender/pulls/109576) > > Right, but that 'cast to floats' effectively does a round on them, so you get an integer value, which if you just set the socket to float you loose, which then breaks the shaders that were using them. well yea, it displays to the user as an int (and therefore is locked to ints/whole numbers only) while technically internally its a float, preventing a user from entering in non whole values

Brecht Van Lommel commented

2023-11-21 20:03:53 +01:00

Owner

The main weakness I think is that there for larger integer values, floats can't represent them exactly so they will be off by a bit. But they end will end up in a float precision render buffer anyway, so it seems acceptable until there is native support.

@blender-bot build

The main weakness I think is that there for larger integer values, floats can't represent them exactly so they will be off by a bit. But they end will end up in a float precision render buffer anyway, so it seems acceptable until there is native support. @blender-bot build

Brecht Van Lommel approved these changes 2023-11-21 20:04:00 +01:00

Brecht Van Lommel requested changes 2023-11-22 17:41:08 +01:00

Brecht Van Lommel left a comment

Owner

One of the test is failing, as can be seen in the buildbot logs:
https://builder.blender.org/admin/#/builders/132/builds/2881/steps/6/logs/stdio

 89/317 Test  #90: bl_node_group_interface ..............................................***Failed    2.28 sec

======================================================================
FAIL: test_all_socket_types (__main__.ShaderNodeGroupInterfaceTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/blender/git/blender-vexp/blender.git/tests/python/bl_node_group_interface.py", line 404, in test_all_socket_types
    self.do_test_invalid_socket_type("NodeSocketBool")
  File "/home/blender/git/blender-vexp/blender.git/tests/python/bl_node_group_interface.py", line 115, in do_test_invalid_socket_type
    self.assertIsNone(in0, f"Socket created for invalid type {socket_type}")
AssertionError: bpy.data.node_groups['test'].interface.items_tree[0] is not None : Socket created for invalid type NodeSocketBool
----------------------------------------------------------------------

One of the test is failing, as can be seen in the buildbot logs: https://builder.blender.org/admin/#/builders/132/builds/2881/steps/6/logs/stdio ``` 89/317 Test #90: bl_node_group_interface ..............................................***Failed 2.28 sec ``` ``` ====================================================================== FAIL: test_all_socket_types (__main__.ShaderNodeGroupInterfaceTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/blender/git/blender-vexp/blender.git/tests/python/bl_node_group_interface.py", line 404, in test_all_socket_types self.do_test_invalid_socket_type("NodeSocketBool") File "/home/blender/git/blender-vexp/blender.git/tests/python/bl_node_group_interface.py", line 115, in do_test_invalid_socket_type self.assertIsNone(in0, f"Socket created for invalid type {socket_type}") AssertionError: bpy.data.node_groups['test'].interface.items_tree[0] is not None : Socket created for invalid type NodeSocketBool ---------------------------------------------------------------------- ```

Diana G added 1 commit 2023-11-27 20:41:38 +01:00

buildbot/vexp-code-patch-coordinator Build done. Details

cb11d913f5 update the failing test

Diana G commented

2023-11-27 20:42:22 +01:00

Author

Contributor

I'm not sure if this is what I was supposed to do

I'm not sure if this is what I was supposed to do

Diana G requested review from Brecht Van Lommel 2023-11-27 20:42:30 +01:00

Brecht Van Lommel approved these changes 2023-11-27 22:33:03 +01:00

Brecht Van Lommel commented

2023-11-27 22:33:15 +01:00

Owner

@blender-bot build

@blender-bot build

Diana G commented

2023-11-29 20:28:39 +01:00

Author

Contributor

how would i go about fixing the failed tests?

how would i go about fixing the failed tests?

Brecht Van Lommel commented

2023-11-29 22:29:19 +01:00

Owner

Merging latest main into this pull request should fix it.

Merging latest main into this pull request should fix it.

Brecht Van Lommel added 1 commit 2024-01-10 20:00:21 +01:00

6ee7c4ceb6 Merge branch 'main' into HEAD

Diana G commented

2024-01-10 20:07:52 +01:00

Author

Contributor

Oh thank you, I forgot I made this PR

Oh thank you, I forgot I made this PR

Brecht Van Lommel merged commit eca14d5b40 into main

2024-01-10 20:09:46 +01:00

Brecht Van Lommel referenced this issue from a commit

2024-01-10 20:09:47 +01:00

Nodes: add int and bool to shader nodegroups

Brecht Van Lommel deleted branch shader-ints-bools

2024-01-10 20:09:48 +01:00

Kazashi Yoshioka referenced this issue from a commit

2024-01-12 19:10:53 +01:00

Nodes: add int and bool to shader nodegroups

Arye Ramaty referenced this issue from a commit

2024-01-21 15:37:39 +01:00

Nodes: add int and bool to shader nodegroups

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

6 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#115026

No description provided.