Anim: Add basic autokey tests #115064

Christoph Lendenfeld · 2023-11-17T18:09:57+01:00

2023-11-17 18:09:57 +01:00

Add basic unit tests for the auto keying system.

Part of #113278: Anim: Keyframing Rework

Add basic unit tests for the auto keying system. Part of [#113278: Anim: Keyframing Rework](https://projects.blender.org/blender/blender/issues/113278)

Christoph Lendenfeld added the

Module

Animation & Rigging

label 2023-11-17 18:09:57 +01:00

Christoph Lendenfeld added 1 commit 2023-11-17 18:10:10 +01:00

ad79904ad4 add basic autokey tests

Christoph Lendenfeld requested review from Nathan Vegdahl 2023-11-17 18:15:18 +01:00

Nathan Vegdahl approved these changes 2023-11-21 14:23:20 +01:00

Nathan Vegdahl left a comment

Looks good to me! Just one thing you could change if you feel like taking the time, but I don't think it's especially important.

tests/python/bl_animation_keyframing.py Outdated

						
				@ -203,0 +247,4 @@

				            bpy.ops.transform.translate(value=(1, 0, 0))

				        action = keyed_object.animation_data.action

				        self.assertTrue(_fcurve_paths_match(action.fcurves, ["location"]))

Nathan Vegdahl commented

2023-11-21 14:19:14 +01:00

Not critical, but if you want to take the time: this checks that keys weren't added for rotation and scale, but it doesn't check that a new key was added by autokey for the location channel, since the location channel already existed from manually creating a key.

That's probably okay, since that's basically already tested by test_autokey_basic above. But just to ensure nothing funky happens because of locking the other channels, it might be worth e.g. changing the current frame between the manual keying and the transform, and then checking that indeed two keys were created on location.

Not critical, but if you want to take the time: this checks that keys *weren't* added for rotation and scale, but it doesn't check that a new key *was* added by autokey for the location channel, since the location channel already existed from manually creating a key. That's probably okay, since that's basically already tested by `test_autokey_basic` above. But just to ensure nothing funky happens because of locking the other channels, it might be worth e.g. changing the current frame between the manual keying and the transform, and then checking that indeed two keys were created on location.

Christoph Lendenfeld commented

2023-11-21 16:07:48 +01:00

good idea, changed it :)