Fullframe compositor: unify size inference with GPU compositor part 2 #115733

Habib Gahbiche · 2023-12-03T22:05:34+01:00

Habib Gahbiche commented

2023-12-03 22:05:34 +01:00

Followup to #114755. Initialize operation results explicitly if the input is constant. This patch unifies the size inference behavior of the following nodes/operation:

Flip node
Kuwahara (classic)
Lens distortion
Tonemap node

Followup to #114755. Initialize operation results explicitly if the input is constant. This patch unifies the size inference behavior of the following nodes/operation: - Flip node - Kuwahara (classic) - Lens distortion - Tonemap node

❤️ 1

Habib Gahbiche added 2 commits 2023-12-03 22:05:43 +01:00

54b98c9a8f Fullframe compositor: unify size inference with GPU compositor

buildbot/vexp-code-patch-coordinator Build done. Details

6a3afdc8c8 Merge remote-tracking branch 'origin/main' into com-unify-size-inference-complex-nodes

Habib Gahbiche commented

2023-12-03 22:06:06 +01:00

@blender-bot build

Habib Gahbiche added this to the Compositing project 2023-12-03 22:07:35 +01:00

Habib Gahbiche requested review from Omar Emara 2023-12-03 22:38:35 +01:00

Omar Emara commented

2023-12-04 12:36:13 +01:00

Why do we need update_memory_buffer_started? Isn't a single value input guaranteed to execute as a single work package?

Why do we need `update_memory_buffer_started`? Isn't a single value input guaranteed to execute as a single work package?

Omar Emara referenced this pull request

2023-12-06 14:30:07 +01:00

Regression: Compositor Split node with only colors does not work (in 3DView, compositor backdrop is fine) #115780

Habib Gahbiche commented

2023-12-06 20:22:56 +01:00

My understanding is no, because constant folding changes inputs only. The output buffer still has the same size as render size, so update_memory_buffer_partial gets called multiple times for a single element input.

My understanding is no, because constant folding changes inputs only. The output buffer still has the same size as render size, so `update_memory_buffer_partial` gets called multiple times for a single element input.

Omar Emara commented

2023-12-11 20:01:37 +01:00

I tried doing it in update_memory_buffer_partial instead of update_memory_buffer_started and it seems to work.

The constant folder initializes first_elem_area_ to a 1x1 area as can be seen in the call: BLI_rcti_init(&first_elem_area_, 0, 1, 0, 1);. So I would expect it to work.

I am interested in doing it like this for clarity and avoiding potential bugs.

I tried doing it in `update_memory_buffer_partial` instead of `update_memory_buffer_started` and it seems to work. The constant folder initializes `first_elem_area_` to a `1x1` area as can be seen in the call: `BLI_rcti_init(&first_elem_area_, 0, 1, 0, 1);`. So I would expect it to work. I am interested in doing it like this for clarity and avoiding potential bugs.

Habib Gahbiche commented

2023-12-17 11:54:14 +01:00

Sure, if it's more clear to you I can move the code to update_memory_partial

Sure, if it's more clear to you I can move the code to `update_memory_partial`

Habib Gahbiche added 2 commits 2023-12-17 12:30:11 +01:00

9aa3c1ca4f Merge remote-tracking branch 'origin/main' into com-unify-size-inference-complex-nodes

76b78c8eaf Use update_memory_buffer_partial only for clarity

Habib Gahbiche added 1 commit 2023-12-17 12:47:30 +01:00