blender-v3.6-release backports #115846

Philipp Oeser · 2023-12-06T14:58:36+01:00

Philipp Oeser commented

2023-12-06 14:58:36 +01:00

No response

_No response_

Philipp Oeser added 9 commits 2023-12-06 14:58:46 +01:00

c3f67cd541 Fix uninitialized pending actions for Windows under Wayland

A windows pending actions wasn't cleared for new windows.
Although I'm not aware of user visible bugs, this prevents
unpredictable updates for new windows.

ec6aa0b3fd Ghost: Fix build error with MSVC 17.7 preview 3

the initialization of m_pkts with an int threw an error with
17.7P3 since it decided int -> uint64_t required a narrowing
conversion. Not sure why it got picky here all of a sudden
but given it's not wrong, we may as well fix it properly.

This change changes the queueSize parameter to size_t and
adds a bounds check at the calling site to ensure the value
it gets will be positive before casting.

77947af0d6 Fix #114685 : GP time offset modifier doesn't work if the animation is 1 frame long

This is due to the early return of current frame when start and end of
custom range is same

71b159d158 Fix 'Make LibOverride' on Empty-instanced collection making everything editable.

Logic handling the 'make everything editable' option was wrong, this is
currently not exposed in 3DView operator, and should always be false.

836063cbd6 Fix #113325 : Zero-sized curve leads to OptiX error

Empty hair geometry in Cycles may still report having one curve, even when
there are no actual segments in that curve. This caused an attempt to build
an acceleration structure with zero primitives, which due to other setup
OptiX rejected with an error. Fix that by checking the number of segments
rather than the number of curves in the hair geometry, since the former will
always be zero for empty geometry.

Pull Request: #115044

94bd19bf1b Fix #113697 : Fix timer leak from panel drag/animate processing

When clicking or dragging a Panel's drag handle, a PANEL_STATE_DRAG
state transition is followed immediately by a PANEL_STATE_ANIMATE
transition.  Both transitions start a timer.

Unfortunately, a subtle change introduced in
f3ab698951 meant the first timer would no
longer be destroyed before starting the second one.

The fix is to just reuse the timer if it's already present so that a
second one is not created in the first place.

Pull Request: #113711

29cd4eb559 Fix #115060 : Swapped custom data mask in BMesh code

cd7bc85237 Fix #115363 : Scrollbars for template_lists in popups update issue

Scrollbars in popups need UI layout refresh to update the right items to
show correctly.

Pull Request: #115364

buildbot/vexp-code-patch-coordinator Build done. Details

9089935f43 Fix #114557 : UI scrollbar "focus bubble" interaction wrong in cases

Some Editors like the Filebrowser or Spreadsheet set up custom masks for
scrollbars (they dont cover the whole region width or height, some rows
or colums are excluded here -- e.g. the "index" column in the
Spreadsheet), this was working fine for drawing, but mouse interaction
was ignoring these custom masks.

Symptoms were that clicking on the "focus bubble" of the scrollbar and
dragging would not result in smooth scrolling [because internally code
would assume the mouse was clicking outside], instead scroll by 1 'page'
was happening [was perceived as a massive lag]. Especially noticable
with many rows/columns (where the "focus bubble" gets small).

So for drawing (`UI_view2d_scrollers_draw`) this wasnt a problem, masks
were passed in for `view2d_scrollers_calc`.
But for interaction (`scroller_activate_init`) `view2d_scrollers_calc`
is called again and a NULL mask was passed.

The already set up rects need to be considered though, otherwise coords
for `mouse_in_scroller_handle` later are not compatible.
To fix this, use existing `View2D` rects fors scrollbars, and pass a
union of those as `mask_custom` to `view2d_scrollers_calc`.

NOTE: this can temporarily extend the `View2D` scrollbar rect by a
pixel, the next draw call will correct this again though.

Pull Request: #114631

Philipp Oeser commented

2023-12-06 14:59:04 +01:00

@blender-bot build

Philipp Oeser merged commit 4f127b9654 into blender-v3.6-release

2023-12-06 15:36:44 +01:00

Philipp Oeser referenced this issue from a commit

2023-12-06 15:36:46 +01:00

Fix #114557: UI scrollbar "focus bubble" interaction wrong in cases

Philipp Oeser deleted branch blender-v3.6-release

2023-12-06 15:36:46 +01:00

Sign in to join this conversation.

No reviewers