Transform: Implement Snap to Grid mode #116109

Germano Cavalcante · 2023-12-12T21:14:03+01:00

Germano Cavalcante commented

2023-12-12 21:14:03 +01:00

Addresses two improvements to Snap to Grid as suggested in #73993:

Make 'Absolute Grid Snapping' a new Snap Mode
Snap to Grid in Non-Side View performed at ground level

Implementation details:

Snap to Grid has no snap symbol on the position being snapped, unless we are in Set Snap Base mode. This maintains the old 'Absolute Grid Snap' behavior. And a grid snap indication is not necessary.
In Non-Side view, Snap to Grid is done at ground level.
If Snap With is Closest, Snap to Grid uses the transform pivot point instead. Tests have shown that Closest is not really useful for Sap to Grid. And this keeps the behavior closer to the previous "Absolute Grid Snap".
The old "Absolute Grid Snap" option has been removed.

Snap Menu for View 3D:

Snap Menu for UV:

Usage with Set Snap Base:

Addresses two improvements to `Snap to Grid` as suggested in #73993: - Make 'Absolute Grid Snapping' a new Snap Mode - Snap to Grid in Non-Side View performed at ground level Implementation details: - Snap to Grid has no snap symbol on the position being snapped, unless we are in `Set Snap Base` mode. This maintains the old 'Absolute Grid Snap' behavior. And a grid snap indication is not necessary. - In Non-Side view, Snap to Grid is done at ground level. - If `Snap With` is `Closest`, Snap to Grid uses the transform pivot point instead. Tests have shown that Closest is not really useful for Sap to Grid. And this keeps the behavior closer to the previous "Absolute Grid Snap". - The old "Absolute Grid Snap" option has been removed. --- Snap Menu for View 3D: ![View3D_popover.png](/attachments/f320851b-d096-488c-8374-87f9f583ac8d) Snap Menu for UV: ![UV_popover.png](/attachments/43e6ff49-47e6-4c1c-bfe9-ff4e2138f8e7) Usage with Set Snap Base: ![GIF.gif](/attachments/ded22abe-b035-4cab-a460-47aacf7ca1a9)

View3D_popover.png

63 KiB

UV_popover.png

20 KiB

GIF.gif

108 KiB

👍 4 ❤️ 4 🎉 3

Germano Cavalcante requested review from Campbell Barton 2023-12-12 21:14:26 +01:00

Germano Cavalcante requested review from Dalai Felinto 2023-12-12 21:14:26 +01:00

Germano Cavalcante commented

2023-12-12 21:16:11 +01:00

It may be late, but I believe this idea could be added to 'the planning for 2024'.

Dalai Felinto commented

2023-12-14 10:57:12 +01:00

Something that is small scoped, doesn't require a team, and even has a patch for it, can be tackled as part of the regular module development. It doesn't need to be in the big-overarching 2024 planning.

Dalai Felinto commented

2023-12-14 11:02:27 +01:00

"Snap to Grid has no symbol, unless we are in Set Snap Base mode."

What is the rational for showing when in Snap Base mode but not always?

If Snap With is Closest, Snap to Grid uses the transform pivot instead.

That sounds arbritrary. I still think we should get rid of "Closest" once and for all.

> "Snap to Grid has no symbol, unless we are in Set Snap Base mode." What is the rational for showing when in Snap Base mode but not always? > If Snap With is Closest, Snap to Grid uses the transform pivot instead. That sounds arbritrary. I still think we should get rid of "Closest" once and for all.

Germano Cavalcante commented

2023-12-14 12:05:39 +01:00

What is the rational for showing when in Snap Base mode but not always?

It doesn't have a symbol because:

Matches the standard seen in industry CAD applications that also do not have a symbol;
Keeps the behavior more similar to the now removed 'Absolute Grid Snap';
If Snap to Grid is enabled and we do not have snap to another type of element, Snap to Grid is certainly being done, no indication is needed.

It displays a 'Loose Point' symbol in 'Set Snap Base' mode because: since nothing else moves, this is the only way to know if the Base point is on the Grid.

"If Snap With is Closest, Snap to Grid uses the transform pivot instead" sounds arbitrary.

The 'Absolute Grid Snap' behavior (which always used the midpoint) also seemed arbitrary.
I tested Closest and it really isn't useful for Snap to Grid. Especially if we are snapping a UV. Since a UV mesh has many internal points and the Grid is inside it, seemingly random base points are chosen for snapping. Very unpredictable result.
In 3D View the entire object moves to snap to a point that is inside it. And once again the Closest base point appears to be random. It's not useful either.
By changing only the Closest, the Snap to Grid behavior is less restricted than the previous 'Absolute Grid Snap'.

I see it as a plus on the way to making Closest less used and possibly removed in the future.

> What is the rational for showing when in Snap Base mode but not always? It doesn't have a symbol because: - Matches the standard seen in industry CAD applications that also do not have a symbol; - Keeps the behavior more similar to the now removed 'Absolute Grid Snap'; - If Snap to Grid is enabled and we do not have snap to another type of element, Snap to Grid is certainly being done, no indication is needed. It displays a 'Loose Point' symbol in 'Set Snap Base' mode because: since nothing else moves, this is the only way to know if the Base point is on the Grid. > "If Snap With is Closest, Snap to Grid uses the transform pivot instead" sounds arbitrary. The 'Absolute Grid Snap' behavior (which always used the midpoint) also seemed arbitrary. I tested Closest and it really isn't useful for Snap to Grid. Especially if we are snapping a UV. Since a UV mesh has many internal points and the Grid is inside it, seemingly random base points are chosen for snapping. Very unpredictable result. In 3D View the entire object moves to snap to a point that is inside it. And once again the Closest base point appears to be random. It's not useful either. By changing only the Closest, the Snap to Grid behavior is less restricted than the previous 'Absolute Grid Snap'. I see it as a plus on the way to making `Closest` less used and possibly removed in the future.

👍 1

Germano Cavalcante referenced this pull request

2023-12-26 19:06:53 +01:00

Blender Absolute grid Snap issue #116508

Germano Cavalcante referenced this pull request

2024-03-18 14:42:50 +01:00

Grid Snap Does not work when Snap Base is Used #119556

Daniel Gryningstjerna referenced this pull request

2024-03-18 15:09:55 +01:00

Grid Snap Does not work when Snap Base is Used #119556

Campbell Barton commented

2024-03-19 04:53:07 +01:00

This seems fine, if user-stakeholders find the solution acceptable I have no objections.
CC'ing @DanielBystedt & @JulienKaspar.

This seems fine, if user-stakeholders find the solution acceptable I have no objections. CC'ing @DanielBystedt & @JulienKaspar.

❤️ 1 🎉 1 🚀 1

Germano Cavalcante force-pushed snap_to_grid from 636af938b7 to 75f412cd0b

2024-03-19 12:28:35 +01:00

Compare

Germano Cavalcante commented

2024-03-19 12:29:03 +01:00

@blender-bot package

Blender Bot commented

2024-03-19 12:29:06 +01:00

Package build started. Download here when ready.

Package build started. [Download here](https://builder.blender.org/download/patch/PR116109) when ready.

Daniel Gryningstjerna commented

2024-03-19 15:28:43 +01:00

First-time contributor

Wow! Works really, really good from my testing! We will finally be able to snap precisely with Snap Base to the grid and it just works! ❤️

After using this, it feels bad going back to regular Blender Increments + Grid Snap that barley works half of the time haha 😅

I can not wait until it is finally added officially! 🥳4.2 is going to be great! 🎊

Wow! Works really, really good from my testing! We will finally be able to snap precisely with Snap Base to the grid and it just works! ❤️ After using this, it feels bad going back to regular Blender Increments + Grid Snap that barley works half of the time haha 😅 I can not wait until it is finally added officially! 🥳4.2 is going to be great! 🎊

❤️ 1

Daniel Bystedt commented

2024-03-21 00:05:43 +01:00

Nice addition! This works very nicely. The only thing that I've found that I'd like to get fixed is that the snapping to grid does not work in conjunction with X-ray mode. Snapping does work with other snapping targets like vertex, edge etc when in x-ray

Nice addition! This works very nicely. The only thing that I've found that I'd like to get fixed is that the snapping to grid does not work in conjunction with X-ray mode. Snapping does work with other snapping targets like vertex, edge etc when in x-ray ![bild](/attachments/904e5ed9-ff22-4600-822a-bfb106025844)

bild.png

87 KiB

❤️ 1

Germano Cavalcante added 3 commits 2024-03-21 02:46:06 +01:00

bb01343107 Merge remote-tracking branch 'origin/main' into snap_to_grid

cf2d26302f Fix: Snap to Grid not working in X-Ray

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details