Anim: Add falloff shape property to Weight Paint context menu #116163

Nika Kutsniashvili · 2023-12-13T22:20:59+01:00

2023-12-13 22:20:59 +01:00

Falloff shape is very important property for weight painting, as it acts basically as "X-Ray" mode, and changing it is cumbersome for something that you need to change pretty often.

People are creating addons for quickly accessing this property. Even Blender Studios Easy Weights has it in its own context menu.

This patch adds Falloff Shape property to context menu. Context menus in object modes are reserved for quickly accessing important brush properties and I think this should be there aswell.

Falloff shape is very important property for weight painting, as it acts basically as "X-Ray" mode, and changing it is cumbersome for something that you need to change pretty often. People are [creating addons](https://www.youtube.com/watch?v=d5qIaVyoEJs) for quickly accessing this property. Even Blender Studios Easy Weights has it in its own context menu. This patch adds Falloff Shape property to context menu. Context menus in object modes are reserved for quickly accessing important brush properties and I think this should be there aswell. ![image](/attachments/3968405b-53b0-4da1-85df-ba6a095030fa)

image.png

52 KiB

Nika Kutsniashvili added 1 commit 2023-12-13 22:21:15 +01:00

b5fef34622 Add falloff shape property to weight paint context menu

Nika Kutsniashvili requested review from Nathan Vegdahl 2023-12-13 22:22:04 +01:00

Nika Kutsniashvili requested review from Sybren A. Stüvel 2023-12-13 22:22:04 +01:00

Nathan Vegdahl commented

2023-12-14 10:51:06 +01:00

This makes a lot of sense to me. @Mets Any opinions?

Demeter Dzadik commented

2023-12-14 12:08:43 +01:00

I'm fine with this, in fact I also have an add-on that makes the weight paint context menu less useless, and this is one of the buttons I put there for myself as well. Here's what mine looks like, for reference.

It's a bit messy of course, but it's mostly for myself.

So, if you wanted to add Accumulate and Front Faces Only toggles, that would be more than fine by me too. Although probably as toggle=False checkboxes, unlike I have here.

I'm fine with this, in fact I also have an add-on that makes the weight paint context menu less useless, and this is one of the buttons I put there for myself as well. Here's what mine looks like, for reference. ![image](/attachments/9ba31657-5130-4193-94b4-e21e5a9c0e45) It's a bit messy of course, but it's mostly for myself. So, if you wanted to add Accumulate and Front Faces Only toggles, that would be more than fine by me too. Although probably as `toggle=False` checkboxes, unlike I have here.

image.png

42 KiB

Nika Kutsniashvili commented

2023-12-14 12:26:18 +01:00

I'll do a test with accumulate and front faces, lets see what it looks like.

Operators in context menu do have precedent in Blender of course, but not alongside properties. So that's a design task that UI module needs to approve.

As for Overlay settings, they're more suited for Quick Favorites, but currently Enum properties cant be added in quick favourites and that's a big limitation. But thats another general task as well.

I'll do a test with accumulate and front faces, lets see what it looks like. Operators in context menu do have precedent in Blender of course, but not alongside properties. So that's a design task that UI module needs to approve. As for Overlay settings, they're more suited for Quick Favorites, but currently Enum properties cant be added in quick favourites and that's a big limitation. But thats another general task as well.

Nika Kutsniashvili commented

2023-12-14 22:26:15 +01:00

I noticed that Blend mode property wasn't in the context menu, and I added it as well, since its in every other paint mode and Weight Paint was only exception for some reason.

With accumulate and front faces only it can look one of those ways. Neither of them have precendent in existing context menus, but maybe can work:

I like last one most, while it has its downsides its aligned with Blender UI and doesn't look out of place

I noticed that Blend mode property wasn't in the context menu, and I added it as well, since its in every other paint mode and Weight Paint was only exception for some reason. With accumulate and front faces only it can look one of those ways. Neither of them have precendent in existing context menus, but maybe can work: ![image](/attachments/7b73c2ff-98a7-46bb-b668-0570d2910533) ![image](/attachments/21a2a464-b594-426c-a003-8d1bf168003c) ![image](/attachments/492132ab-68b1-4a74-aec5-5f9e53d28404) ![image](/attachments/b72acfb7-b5aa-4b32-9f3a-46588f647c77) I like last one most, while it has its downsides its aligned with Blender UI and doesn't look out of place

image.png

15 KiB

image.png

21 KiB

image.png

16 KiB

image.png

18 KiB

Demeter Dzadik commented

2023-12-15 11:50:34 +01:00

Damn, the checkboxes don't look as nice as I'd hoped. I'd go with #3, or actually just embrace toggle=True instead. But I don't mind too much, it's up to you or whoever else wants to chip in.

Damn, the checkboxes don't look as nice as I'd hoped. I'd go with #3, or actually just embrace `toggle=True` instead. But I don't mind too much, it's up to you or whoever else wants to chip in.

Merge conflict checking is in progress. Try again in few moments.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u weight-context:nickberckley-weight-context

git checkout nickberckley-weight-context

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Anim: Add falloff shape property to Weight Paint context menu #116163

Checkout