ghost/ndof: Support for USB ID changes for devices made by 3Dconnextion. #116393

ESASHIKA Kaoru · 2023-12-20T19:35:15+01:00

ESASHIKA Kaoru commented

2023-12-20 19:35:15 +01:00

Recently sold 3Dconnexion devices appear to have changed their USB ID.
This commit adds the ID of the Space Mouse Pro Wireless when connected
directly to the device and the ID of the dongle for wireless connection.

Recently sold 3Dconnexion devices appear to have changed their USB ID. This commit adds the ID of the Space Mouse Pro Wireless when connected directly to the device and the ID of the dongle for wireless connection.

Iliya Katushenock added this to the Platforms, Builds Tests & Devices project 2023-12-20 19:49:41 +01:00

ESASHIKA Kaoru referenced this pull request

2023-12-25 16:57:45 +01:00

ghost: ndof: New Connextion devices are not supported. #116535

Jesse Yurkovich referenced this pull request

2023-12-26 03:03:27 +01:00

ghost: ndof: New Connextion devices are not supported. #116535

Harley Acheson commented

2023-12-26 19:45:51 +01:00

In their docs I am seeing 0xC652 as their "Universal Receiver", but 0xC638 is listed as "SpaceMouse Pro Wireless Bluetooth', not plugged in.

Are you certain of the uses shown in the comments? Otherwise I'd be inclined to add the ones you are wanting to add, but do so with 3dconnexion's descriptions:

      switch (product_id) {
        case 0xC62E: /* SpaceMouse Wireless (cabled). */
        case 0xC62F: /* SpaceMouse Wireless Receiver. */
        case 0xC658: /* Wireless (3DConnexion Universal Wireless Receiver in WIN32), see #82412. */
        {
          device_type_ = NDOF_SpaceMouseWireless;
          hid_map_button_num_ = 2;
          hid_map_ = ndof_HID_map_Modern3Dx;
          break;
        }
        case 0xC631: /* SpaceMouse Pro Wireless (cabled). */
        case 0xC632: /* SpaceMouse Pro Wireless Receiver. */
        case 0xC638: /* SpaceMouse Pro Wireless Bluetooth. */
        case 0xC652: /* Universal Receiver. */
        {
          device_type_ = NDOF_SpaceMouseProWireless;

In [their docs](https://3dconnexion.com/fi/support/faq/how-can-i-check-if-my-usb-3d-mouse-is-recognized-by-windows/) I am seeing 0xC652 as their "Universal Receiver", but 0xC638 is listed as "SpaceMouse Pro Wireless Bluetooth', not plugged in. Are you certain of the uses shown in the comments? Otherwise I'd be inclined to add the ones you are wanting to add, but do so with 3dconnexion's descriptions: ```Cpp switch (product_id) { case 0xC62E: /* SpaceMouse Wireless (cabled). */ case 0xC62F: /* SpaceMouse Wireless Receiver. */ case 0xC658: /* Wireless (3DConnexion Universal Wireless Receiver in WIN32), see #82412. */ { device_type_ = NDOF_SpaceMouseWireless; hid_map_button_num_ = 2; hid_map_ = ndof_HID_map_Modern3Dx; break; } case 0xC631: /* SpaceMouse Pro Wireless (cabled). */ case 0xC632: /* SpaceMouse Pro Wireless Receiver. */ case 0xC638: /* SpaceMouse Pro Wireless Bluetooth. */ case 0xC652: /* Universal Receiver. */ { device_type_ = NDOF_SpaceMouseProWireless; ```

ESASHIKA Kaoru commented

2024-01-05 08:15:02 +01:00

Indeed, the display looks strange.
The c638 appears to be Bluetooth at first glance, but it is in fact a wired connection. Perhaps the product name is "SpaceMouse Pro Wireless BT".
If any information is required, I can provide it.

Indeed, the display looks strange. The c638 appears to be Bluetooth at first glance, but it is in fact a wired connection. Perhaps the product name is "SpaceMouse Pro Wireless BT". If any information is required, I can provide it.

Harley Acheson commented

2024-01-05 17:45:14 +01:00

Indeed, the display looks strange.
The c638 appears to be Bluetooth at first glance, but it is in fact a wired connection. Perhaps the product name is "SpaceMouse Pro Wireless BT".

It is okay that there might be confusion there, but I would just note that in the comments. So perhaps giving c638 a multi-line comment about how it is described as "SpaceMouse Pro Wireless Bluetooth" but is actually wired.

If any information is required, I can provide it.

No, my only concern here is that this section of hex value identifiers is getting a bit long and as we add more I'd like better comments to differentiate between them better. I would like to take advantage of your knowledge with this as we don't find many people familiar with these devices. Especially with c638 because otherwise someone could "correct" this later, unaware of your determination that it is wired.

If you do not want to add more comments, that would be fine too. I could probably merge this and then add comments afterward. But again, I'd rather you do so since you have more knowledge with these.

> Indeed, the display looks strange. > The c638 appears to be Bluetooth at first glance, but it is in fact a wired connection. Perhaps the product name is "SpaceMouse Pro Wireless BT". It is okay that there might be confusion there, but I would just note that in the comments. So perhaps giving c638 a multi-line comment about how it is described as "SpaceMouse Pro Wireless Bluetooth" but is actually wired. > If any information is required, I can provide it. No, my only concern here is that this section of hex value identifiers is getting a bit long and as we add more I'd like better comments to differentiate between them better. I would like to take advantage of your knowledge with this as we don't find many people familiar with these devices. Especially with c638 because otherwise someone could "correct" this later, unaware of your determination that it is wired. If you do not want to add more comments, that would be fine too. I could probably merge this and then add comments afterward. But again, I'd rather you do so since you have more knowledge with these.

ESASHIKA Kaoru commented

2024-01-18 10:18:27 +01:00

I added some comments and rebased. @Harley Would you please review this PR again?

Harley Acheson requested review from Harley Acheson 2024-01-18 17:27:22 +01:00

Harley Acheson commented

2024-01-18 17:28:08 +01:00

That is great. Thank you so much for working on this.

😆 1

Harley Acheson added 2 commits 2024-01-18 17:43:53 +01:00

e020af1f48 Merge branch 'main' of projects.blender.org:blender/blender into pr116393

f4692e8dbe Comment and format change.

Harley Acheson approved these changes 2024-01-18 17:44:24 +01:00