Video_Sequencer: Add render menu to Video Sequencer #116797

Gangneron · 2024-01-04T19:57:03+01:00

Gangneron commented

2024-01-04 19:57:03 +01:00

First-time contributor

Add render menu in Video sequencer editor.
The objective was to improve the UX and usability of the rendering function by adding a menu dedicated to this task.

Add render menu in Video sequencer editor. The objective was to improve the UX and usability of the rendering function by adding a menu dedicated to this task.

Gangneron added 1 commit 2024-01-04 19:57:13 +01:00

c01496fe3d Add render menu to Video Sequencer

Nika Kutsniashvili commented

2024-01-04 20:24:04 +01:00

Best to hold this before #116492 is merged to avoid conflicting files. That's what I was waiting for as well.

But I'm not sure this menu is necessary at the moment. 3D viewport "View" menu also has render options in View menu and its gonna create inconsistency between editors. I think those options should be where you expect them to be from 3D viewport.

Its also only two operators, way too few to warrant a new menu entry.

And third one you have there, which is toggle between Preview/VSE is wrong there. It has nothing to do with render its viewport property and should be there. Its also similar to Toggle Graph Editor toggle that is in animation editors and will create more incosistency as well.

Best to hold this before #116492 is merged to avoid conflicting files. That's what I was waiting for as well. But I'm not sure this menu is necessary at the moment. 3D viewport "View" menu also has render options in View menu and its gonna create inconsistency between editors. I think those options should be where you expect them to be from 3D viewport. Its also only two operators, way too few to warrant a new menu entry. And third one you have there, which is toggle between Preview/VSE is wrong there. It has nothing to do with render its viewport property and should be there. Its also similar to Toggle Graph Editor toggle that is in animation editors and will create more incosistency as well.

Gangneron commented

2024-01-04 20:46:35 +01:00

First-time contributor

I did this to start improving the UX of the video sequencer

Gangneron commented

2024-01-04 20:54:10 +01:00

First-time contributor

@iss

Richard Antalik requested changes 2024-01-05 19:42:55 +01:00

Richard Antalik left a comment

Thanks for patch, I think you haven't added this menu to any header, so it is not displayed anywhere.

In general, I am not against this change, but I would say, that it should be changed in 3D viewport as well, so all editors have similar interface. I am not sure though if there wouldn't be objections about having main render menu along with editor render menu. It could be called something like "quick render", but that is bit too long.

Also please use PR description as commit message and follow https://wiki.blender.org/wiki/Style_Guide/Commit_Messages

Thanks for patch, I think you haven't added this menu to any header, so it is not displayed anywhere. In general, I am not against this change, but I would say, that it should be changed in 3D viewport as well, so all editors have similar interface. I am not sure though if there wouldn't be objections about having main render menu along with editor render menu. It could be called something like "quick render", but that is bit too long. Also please use PR description as commit message and follow https://wiki.blender.org/wiki/Style_Guide/Commit_Messages

Gangneron commented

2024-01-05 19:51:41 +01:00

First-time contributor

Ok, so i update my description. I will ask someone from the user interface for advice regarding this change in 3D viewport

Gangneron changed title from ~~Add render menu to Video Sequencer~~ to WIP: Add render menu to Video Sequencer

2024-01-05 20:32:01 +01:00

Gangneron changed title from ~~WIP: Add render menu to Video Sequencer~~ to Add render menu to Video Sequencer

2024-01-05 20:32:17 +01:00

Gangneron changed title from ~~Add render menu to Video Sequencer~~ to Video_Sequencer: Add render menu to Video Sequencer

2024-01-05 20:32:37 +01:00

Gangneron commented

2024-01-05 20:40:08 +01:00

First-time contributor

@HooglyBoogly

Gangneron commented

2024-01-05 20:40:41 +01:00

First-time contributor

I would like to know what you think about adding a menu rendered in the 3d viewport

Gangneron commented

2024-01-08 12:09:16 +01:00

First-time contributor

@nathanvegdahl

Gangneron referenced this pull request

2024-01-08 12:25:45 +01:00

UI: Reorganize 'View' menus in animation and video editors to make them more consistent #116492

Richard Antalik commented

2024-01-08 17:25:24 +01:00

I will have to discuss this with @fsiddi, I don't feel like I should make decisions in this case. I should be able to give you update later this week.

Gangneron commented

2024-01-08 18:23:36 +01:00

First-time contributor

ok no problem. if you need my point of view or information do not hesitate to tag me

tintwotin commented

2024-01-09 22:04:15 +01:00

First-time contributor

I agree, having the render operators exposed inside a View menu doesn't make sense. And having no File Browser to type file name etc. when exporting is far from optimal, too. Or in other words, for new users are the I/O file operations very confusing.

Basically, the VSE should just have a File menu, but in the past there was a lot of resistance on this. The argument is that Blender should only have one file menu, and that's the one in the main menu. But the File menu only handles 3d related file operations and project file operations, which means that numerous editors have file operations locally. What is done in ex. the Text Editor is that the file operations are located in a menu called Text. Which would equal calling the Video Sequence Editor menu: Sequence. I have previously suggested this, without much success, and I even made an add-on for a Sequence menu which unifies all VSE Sequencer operations including Render options, and also added a unified import file browser, and an export File Browser. Both with all options in the sidebar:

https://github.com/tin2tin/VSE_File_Menu

I agree, having the render operators exposed inside a View menu doesn't make sense. And having no File Browser to type file name etc. when exporting is far from optimal, too. Or in other words, for new users are the I/O file operations very confusing. Basically, the VSE should just have a File menu, but in the past there was a lot of resistance on this. The argument is that Blender should only have one file menu, and that's the one in the main menu. But the File menu only handles 3d related file operations and project file operations, which means that numerous editors have file operations locally. What is done in ex. the Text Editor is that the file operations are located in a menu called Text. Which would equal calling the Video Sequence Editor menu: Sequence. I have previously suggested this, without much success, and I even made an add-on for a Sequence menu which unifies all VSE Sequencer operations including Render options, and also added a unified import file browser, and an export File Browser. Both with all options in the sidebar: ![image](/attachments/12033f64-ec78-4738-87e4-0219fb0ea7f4) https://github.com/tin2tin/VSE_File_Menu

image.png

15 KiB

Richard Antalik commented

2024-01-11 19:28:43 +01:00

@Gangneron I have talked about this topic, and the conlusion was, that the way current UI is set up is not great. This doesn't only apply to rendering, but also for other I/O actions like importing, saving stuff etc. Unfortunately, we aren't convinced, that making another menu for rendering would solve this issue. Also we can't currently give you any advice how to do this better, since this should be brainstormed in design task by UI team.

In any case, thank you for contribution, but unfortunately, we can not accept this change right now, so I will close this patch. Some issues can be tricky to address. In general, I would advise to consult proposed solutions with module members before submitting PRs, before you put in a lot of work.

@Gangneron I have talked about this topic, and the conlusion was, that the way current UI is set up is not great. This doesn't only apply to rendering, but also for other I/O actions like importing, saving stuff etc. Unfortunately, we aren't convinced, that making another menu for rendering would solve this issue. Also we can't currently give you any advice how to do this better, since this should be brainstormed in design task by UI team. In any case, thank you for contribution, but unfortunately, we can not accept this change right now, so I will close this patch. Some issues can be tricky to address. In general, I would advise to consult proposed solutions with module members before submitting PRs, before you put in a lot of work.

Richard Antalik closed this pull request

2024-01-11 19:28:45 +01:00

Gangneron commented

2024-01-11 20:21:03 +01:00

First-time contributor

ok thank you but I think the video editor interface should still be improved and the menus reorganized

tintwotin commented

2024-01-11 21:37:42 +01:00

First-time contributor

@Gangneron
The VSE chat is a good place to pitch the things you want to change: https://blender.chat/channel/vse

@Gangneron The VSE chat is a good place to pitch the things you want to change: https://blender.chat/channel/vse

Richard Antalik commented

2024-01-12 18:47:41 +01:00

ok thank you but I think the video editor interface should still be improved and the menus reorganized

I don't disagree, but there has to be consensus on how it should be improved. But unfortunately this topic was not discussed yet.

> ok thank you but I think the video editor interface should still be improved and the menus reorganized I don't disagree, but there has to be consensus on how it should be improved. But unfortunately this topic was not discussed yet.

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Video_Sequencer: Add render menu to Video Sequencer #116797

Pull request closed