UI: Improvements to Confirmation of Save Startup #117152

Harley Acheson · 2024-01-16T02:26:07+01:00

Harley Acheson commented

2024-01-16 02:26:07 +01:00

A more informative confirmation dialog to confirm that the user wishes
to save new default startup file.

Current

Proposed if using the regular "General" template

If you are using a different template then you get slightly different wording to make that clear:

A more informative confirmation dialog to confirm that the user wishes to save new default startup file. --- Current ![image](/attachments/f0b10cd2-6e25-4e8f-b6e5-84fa66e1209e) Proposed if using the regular "General" template ![image](/attachments/80fadc7a-b818-4948-9871-4e83e76e756f) If you are using a different template then you get slightly different wording to make that clear: ![image](/attachments/9f0f2eca-a4ae-4b82-bc78-14dbd542ce43)

18 KiB

17 KiB

22 KiB

30 KiB

10 KiB

image.png

7.8 KiB

61 KiB

18 KiB

17 KiB

22 KiB

image.png

19 KiB

image.png

21 KiB

👍 3

Harley Acheson added this to the User Interface project 2024-01-16 02:26:26 +01:00

Harley Acheson requested review from Pablo Vazquez 2024-01-16 02:26:32 +01:00

Jonas Holzman commented

2024-01-17 02:31:23 +01:00

In this dialog, we might want to highlight the fact that this operation will overwrite the previously saved Startup File.
This could be done by either making the dialog a question and inverting the sentence: "Overwrite the default .blend file with the current file?", and changing the "Save" button to "Overwrite".
Or by keeping the current elements, and adding a "WARNING" message inside the dialog, similarly to what you did in the second dialog of #117153, which could give something like "WARNING: This will overwrite the current Blender Startup File".

And on a separate note, we might want to follow the naming scheme set by the "Save Startup File" operator and refer to the target file in question as the default "Startup File" instead of ".blend file". Which would give us the title: "Make the current file the default Startup File", capitalizing "Startup File" following the precedent of the operator title and to highlight that we're referring to the one and only default Startup File, and keeping "current file" uncapitalized as to not put the accent on it.

In this dialog, we might want to highlight the fact that this operation will overwrite the previously saved Startup File. This could be done by either making the dialog a question and inverting the sentence: "Overwrite the default .blend file with the current file?", and changing the "Save" button to "Overwrite". Or by keeping the current elements, and adding a "WARNING" message inside the dialog, similarly to what you did in the second dialog of #117153, which could give something like "WARNING: This will overwrite the current Blender Startup File". And on a separate note, we might want to follow the naming scheme set by the "Save Startup File" operator and refer to the target file in question as the default "Startup File" instead of ".blend file". Which would give us the title: "Make the current file the default Startup File", capitalizing "Startup File" following the precedent of the operator title and to highlight that we're referring to the one and only default Startup File, and keeping "current file" uncapitalized as to not put the accent on it.

👍 1

Harley Acheson commented

2024-01-17 03:05:05 +01:00

@Brainzman

I made some changes, but kept if fairly simple. We can always circle back here.

@Brainzman I made some changes, but kept if fairly simple. We can always circle back here.

Jonas Holzman commented

2024-01-17 03:27:23 +01:00

Nice looks great! You were right to not capitalize "startup file" in the end, it does look more compact and balanced in a short message like that, especially with the added punctuation. I really like the clean, compact and straight to the point feel this dialog ends up giving out, especially with the fact that the word overwrite is not being repeated in the dialog message.

The only eventual inconsistency I can see, is that this makes invoking the "Save Startup File" operator show a dialog tilted "Overwrite Startup File", but this is probably acceptable considering that the title change act as a great way to remind the user of the destructive nature of the operation, without having to use more agressive "WARNING" like text.

Nice looks great! You were right to not capitalize "startup file" in the end, it does look more compact and balanced in a short message like that, especially with the added punctuation. I really like the clean, compact and straight to the point feel this dialog ends up giving out, especially with the fact that the word overwrite is not being repeated in the dialog message. The only *eventual* inconsistency I can see, is that this makes invoking the "**Save** Startup File" operator show a dialog tilted "**Overwrite** Startup File", but this is probably acceptable considering that the title change act as a great way to remind the user of the destructive nature of the operation, without having to use more agressive "WARNING" like text.

Harley Acheson referenced this pull request

2024-01-17 17:26:52 +01:00

UI: Cleanup Dialog to Manage Orphaned Data #117242

Bastien Montagne referenced this pull request

2024-01-18 22:29:19 +01:00

UI: Cleanup Dialog to Manage Orphaned Data #117242

Brecht Van Lommel commented

2024-01-30 21:38:28 +01:00

I would change the warning icon to question mark here, and don't cancel by default as discussed for popups in general.

I think it's ok to have a confirmation and better explanation of the consequences, but I don't see the main purpose of this dialog as warning users about something.

I would change the warning icon to question mark here, and don't cancel by default as discussed for popups in general. I think it's ok to have a confirmation and better explanation of the consequences, but I don't see the main purpose of this dialog as warning users about something.

Brecht Van Lommel approved these changes 2024-02-05 12:31:37 +01:00

Brecht Van Lommel commented

2024-02-05 12:32:39 +01:00

Fine with me, though for 4.1 we probably should either update all of these popups or none. So maybe best to leave it for 4.2?

Harley Acheson commented

2024-02-05 19:21:43 +01:00

@brecht - we probably should either update all of these popups or none. So maybe best to leave it for 4.2?

Yes, getting a bit late now. Will mark these for 4.2 and plan for something larger. Could include changes to the smaller ones. The larger ones could possibly get that horizontal rule I want. And maybe also allow some of them to be enabled/disabled in userprefs (we have about half a dozen that are currently configurable in the keymap but off by default).

Will make a design doc.

> @brecht - we probably should either update all of these popups or none. So maybe best to leave it for 4.2? Yes, getting a bit late now. Will mark these for 4.2 and plan for something larger. Could include changes to the smaller ones. The larger ones could possibly get that horizontal rule I want. And maybe also allow some of them to be enabled/disabled in userprefs (we have about half a dozen that are currently configurable in the keymap but off by default). Will make a design doc.

Harley Acheson added this to the 4.2 LTS milestone 2024-02-05 19:28:08 +01:00

Pablo Vazquez commented

2024-02-13 18:41:10 +01:00

Notes from the meeting:

If we are in a startup file other than General, mention it. (Save Sculpting Startup File)

Do we want a dot at the end of the sentence? To be defined in the guidelines.

Notes from the meeting: * If we are in a startup file other than `General`, mention it. (`Save Sculpting Startup File`) Do we want a dot at the end of the sentence? To be defined in the guidelines.

Harley Acheson changed title from ~~UI: Improvements to Confirmation of Save Startup~~ to WIP: UI: Improvements to Confirmation of Save Startup

2024-02-13 21:58:51 +01:00

Harley Acheson referenced this pull request

2024-02-15 19:14:49 +01:00

Dialog Improvements #118341

Harley Acheson changed title from ~~WIP: UI: Improvements to Confirmation of Save Startup~~ to UI: Improvements to Confirmation of Save Startup

2024-02-18 21:06:04 +01:00

Harley Acheson commented

2024-02-18 21:12:33 +01:00

@pablovazquez

This "Save Startup" - WM_OT_save_homefile - does not differ based on application template. It just always saves to startup.blend. The menu that it is in when you are in a template is misleading in that it shows the template name as a menu title, but I can't see any changes that this PR needs.

Probably makes sense to remove the app template title from the File / Defaults menu.

@pablovazquez This "Save Startup" - WM_OT_save_homefile - does not differ based on application template. It just always saves to startup.blend. The menu that it is in when you are in a template is misleading in that it shows the template name as a menu title, but I can't see any changes that this PR needs. Probably makes sense to remove the app template title from the File / Defaults menu.

Brecht Van Lommel commented

2024-02-19 15:38:29 +01:00

This "Save Startup" - WM_OT_save_homefile - does not differ based on application template. It just always saves to startup.blend. The menu that it is in when you are in a template is misleading in that it shows the template name as a menu title, but I can't see any changes that this PR needs.

Probably makes sense to remove the app template title from the File / Defaults menu.

Not sure what you mean by this, it does save to a different startup.blend for every template.

> This "Save Startup" - WM_OT_save_homefile - does not differ based on application template. It just always saves to startup.blend. The menu that it is in when you are in a template is misleading in that it shows the template name as a menu title, but I can't see any changes that this PR needs. > > Probably makes sense to remove the app template title from the File / Defaults menu. Not sure what you mean by this, it does save to a different `startup.blend` for every template.

Harley Acheson commented

2024-02-19 17:37:19 +01:00

Not sure what you mean by this, it does save to a different startup.blend for every template.

OMG, did not notice that this creates a subfolder in my config folder.

> Not sure what you mean by this, it does save to a different `startup.blend` for every template. OMG, did not notice that this creates a subfolder in my config folder.

Harley Acheson changed title from ~~UI: Improvements to Confirmation of Save Startup~~ to WIP: UI: Improvements to Confirmation of Save Startup

2024-02-19 17:37:35 +01:00

Harley Acheson changed title from ~~WIP: UI: Improvements to Confirmation of Save Startup~~ to UI: Improvements to Confirmation of Save Startup

2024-02-20 00:36:59 +01:00

Harley Acheson force-pushed ConfirmStartup from d1d59ff4e0 to 1eccd93067

2024-03-06 22:53:40 +01:00

Compare

Harley Acheson commented

2024-03-06 23:26:54 +01:00

@blender-bot build

Harley Acheson referenced this issue from a commit

2024-03-07 00:19:40 +01:00

UI: Improvements to Confirmation of Save Startup

Harley Acheson merged commit 6618755912 into main

2024-03-07 00:19:41 +01:00