UI: Improvements to Confirmation of Save Startup #117152

Merged
Harley Acheson merged 1 commits from Harley/blender:ConfirmStartup into main 2024-03-07 00:19:41 +01:00
Member

A more informative confirmation dialog to confirm that the user wishes
to save new default startup file.


Current

image

Proposed if using the regular "General" template

image

If you are using a different template then you get slightly different wording to make that clear:

image

A more informative confirmation dialog to confirm that the user wishes to save new default startup file. --- Current ![image](/attachments/f0b10cd2-6e25-4e8f-b6e5-84fa66e1209e) Proposed if using the regular "General" template ![image](/attachments/80fadc7a-b818-4948-9871-4e83e76e756f) If you are using a different template then you get slightly different wording to make that clear: ![image](/attachments/9f0f2eca-a4ae-4b82-bc78-14dbd542ce43)
Harley Acheson added this to the User Interface project 2024-01-16 02:26:26 +01:00
Harley Acheson requested review from Pablo Vazquez 2024-01-16 02:26:32 +01:00
Contributor

In this dialog, we might want to highlight the fact that this operation will overwrite the previously saved Startup File.
This could be done by either making the dialog a question and inverting the sentence: "Overwrite the default .blend file with the current file?", and changing the "Save" button to "Overwrite".
Or by keeping the current elements, and adding a "WARNING" message inside the dialog, similarly to what you did in the second dialog of #117153, which could give something like "WARNING: This will overwrite the current Blender Startup File".

And on a separate note, we might want to follow the naming scheme set by the "Save Startup File" operator and refer to the target file in question as the default "Startup File" instead of ".blend file". Which would give us the title: "Make the current file the default Startup File", capitalizing "Startup File" following the precedent of the operator title and to highlight that we're referring to the one and only default Startup File, and keeping "current file" uncapitalized as to not put the accent on it.

In this dialog, we might want to highlight the fact that this operation will overwrite the previously saved Startup File. This could be done by either making the dialog a question and inverting the sentence: "Overwrite the default .blend file with the current file?", and changing the "Save" button to "Overwrite". Or by keeping the current elements, and adding a "WARNING" message inside the dialog, similarly to what you did in the second dialog of #117153, which could give something like "WARNING: This will overwrite the current Blender Startup File". And on a separate note, we might want to follow the naming scheme set by the "Save Startup File" operator and refer to the target file in question as the default "Startup File" instead of ".blend file". Which would give us the title: "Make the current file the default Startup File", capitalizing "Startup File" following the precedent of the operator title and to highlight that we're referring to the one and only default Startup File, and keeping "current file" uncapitalized as to not put the accent on it.
Author
Member

@Brainzman

I made some changes, but kept if fairly simple. We can always circle back here.

@Brainzman I made some changes, but kept if fairly simple. We can always circle back here.
Contributor

Nice looks great! You were right to not capitalize "startup file" in the end, it does look more compact and balanced in a short message like that, especially with the added punctuation. I really like the clean, compact and straight to the point feel this dialog ends up giving out, especially with the fact that the word overwrite is not being repeated in the dialog message.

The only eventual inconsistency I can see, is that this makes invoking the "Save Startup File" operator show a dialog tilted "Overwrite Startup File", but this is probably acceptable considering that the title change act as a great way to remind the user of the destructive nature of the operation, without having to use more agressive "WARNING" like text.

Nice looks great! You were right to not capitalize "startup file" in the end, it does look more compact and balanced in a short message like that, especially with the added punctuation. I really like the clean, compact and straight to the point feel this dialog ends up giving out, especially with the fact that the word overwrite is not being repeated in the dialog message. The only *eventual* inconsistency I can see, is that this makes invoking the "**Save** Startup File" operator show a dialog tilted "**Overwrite** Startup File", but this is probably acceptable considering that the title change act as a great way to remind the user of the destructive nature of the operation, without having to use more agressive "WARNING" like text.

I would change the warning icon to question mark here, and don't cancel by default as discussed for popups in general.

I think it's ok to have a confirmation and better explanation of the consequences, but I don't see the main purpose of this dialog as warning users about something.

I would change the warning icon to question mark here, and don't cancel by default as discussed for popups in general. I think it's ok to have a confirmation and better explanation of the consequences, but I don't see the main purpose of this dialog as warning users about something.
Brecht Van Lommel approved these changes 2024-02-05 12:31:37 +01:00

Fine with me, though for 4.1 we probably should either update all of these popups or none. So maybe best to leave it for 4.2?

Fine with me, though for 4.1 we probably should either update all of these popups or none. So maybe best to leave it for 4.2?
Author
Member

@brecht - we probably should either update all of these popups or none. So maybe best to leave it for 4.2?

Yes, getting a bit late now. Will mark these for 4.2 and plan for something larger. Could include changes to the smaller ones. The larger ones could possibly get that horizontal rule I want. And maybe also allow some of them to be enabled/disabled in userprefs (we have about half a dozen that are currently configurable in the keymap but off by default).

Will make a design doc.

> @brecht - we probably should either update all of these popups or none. So maybe best to leave it for 4.2? Yes, getting a bit late now. Will mark these for 4.2 and plan for something larger. Could include changes to the smaller ones. The larger ones could possibly get that horizontal rule I want. And maybe also allow some of them to be enabled/disabled in userprefs (we have about half a dozen that are currently configurable in the keymap but off by default). Will make a design doc.
Harley Acheson added this to the 4.2 LTS milestone 2024-02-05 19:28:08 +01:00
Member

Notes from the meeting:

  • If we are in a startup file other than General, mention it. (Save Sculpting Startup File)

Do we want a dot at the end of the sentence? To be defined in the guidelines.

Notes from the meeting: * If we are in a startup file other than `General`, mention it. (`Save Sculpting Startup File`) Do we want a dot at the end of the sentence? To be defined in the guidelines.
Harley Acheson changed title from UI: Improvements to Confirmation of Save Startup to WIP: UI: Improvements to Confirmation of Save Startup 2024-02-13 21:58:51 +01:00
Harley Acheson changed title from WIP: UI: Improvements to Confirmation of Save Startup to UI: Improvements to Confirmation of Save Startup 2024-02-18 21:06:04 +01:00
Author
Member

@pablovazquez

This "Save Startup" - WM_OT_save_homefile - does not differ based on application template. It just always saves to startup.blend. The menu that it is in when you are in a template is misleading in that it shows the template name as a menu title, but I can't see any changes that this PR needs.

Probably makes sense to remove the app template title from the File / Defaults menu.

@pablovazquez This "Save Startup" - WM_OT_save_homefile - does not differ based on application template. It just always saves to startup.blend. The menu that it is in when you are in a template is misleading in that it shows the template name as a menu title, but I can't see any changes that this PR needs. Probably makes sense to remove the app template title from the File / Defaults menu.

This "Save Startup" - WM_OT_save_homefile - does not differ based on application template. It just always saves to startup.blend. The menu that it is in when you are in a template is misleading in that it shows the template name as a menu title, but I can't see any changes that this PR needs.

Probably makes sense to remove the app template title from the File / Defaults menu.

Not sure what you mean by this, it does save to a different startup.blend for every template.

> This "Save Startup" - WM_OT_save_homefile - does not differ based on application template. It just always saves to startup.blend. The menu that it is in when you are in a template is misleading in that it shows the template name as a menu title, but I can't see any changes that this PR needs. > > Probably makes sense to remove the app template title from the File / Defaults menu. Not sure what you mean by this, it does save to a different `startup.blend` for every template.
Author
Member

Not sure what you mean by this, it does save to a different startup.blend for every template.

OMG, did not notice that this creates a subfolder in my config folder.

> Not sure what you mean by this, it does save to a different `startup.blend` for every template. OMG, did not notice that this creates a subfolder in my config folder.
Harley Acheson changed title from UI: Improvements to Confirmation of Save Startup to WIP: UI: Improvements to Confirmation of Save Startup 2024-02-19 17:37:35 +01:00
Harley Acheson changed title from WIP: UI: Improvements to Confirmation of Save Startup to UI: Improvements to Confirmation of Save Startup 2024-02-20 00:36:59 +01:00
Harley Acheson force-pushed ConfirmStartup from d1d59ff4e0 to 1eccd93067 2024-03-06 22:53:40 +01:00 Compare
Author
Member

@blender-bot build

@blender-bot build
Harley Acheson merged commit 6618755912 into main 2024-03-07 00:19:41 +01:00
Harley Acheson deleted branch ConfirmStartup 2024-03-07 00:19:43 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#117152
No description provided.