Dialog Improvements #118341

New Issue

Harley Acheson · 2024-02-15T19:14:49+01:00

Harley Acheson commented

2024-02-15 19:14:49 +01:00

We are attempting to improve our various types of dialogs to make them more informative and also be more consistent with each other.

Some work has been done.

#117528 Changed Properties Dialogs to have a Confirm and Cancel buttons (rather than a single OK button), with configurable confirm button text and title. This way users have clearer instructions, an obvious way to back out, and the look is consistent with the later changes to confirmation dialogs.

#117564 allows to create custom operator confirmation dialogs. These can be made in two sizes, small versions for when there is just a single line of message text, and a larger one for when there is a title and a message body. So far we only have a small number of large confirmations using this new system. These use the same dialog as Properties Dialogs, just with different configuration.

#117310 added configurable layout separators which in this context allows adding horizontal lines in vertical layouts like dialogs. This allowed for #118051 to add a line between title and content for Properties dialogs.

The next steps, and the reason for this document, is to make changes to different dialogs so that they remain consistent and are as informative and useful as possible. The small confirmations especially should have a message that is likely neither the operator name or description, and the button title should be a short verb.

Confirmations Done

PREFERENCES_OT_extension_repo_remove
WM_OT_clear_recent_files

Confirmations In Review

Confirmations that cannot be turned off

The following might need extra care since they are deemed important enough to not allow disabling

OBJECT_OT_simulation_nodes_cache_bake (when existing bake data)
- "Overwrite existing bake data", "Bake", Warning
FILE_OT_delete
- "Delete selected files", "Delete", Warning
TEXT_OT_reload
- "Reload active text file", "Reload", Warning
TEXT_OT_unlink
- "Delete active text file", "Delete", Warning

Keymap Configurable Confirmations

The following are all configurable in the keymap. Most on by default, some turned off

MARKER_OT_delete
- "Delete selected markers", "Delete", Warning
ANIM_OT_keyframe_delete_v3d
- "Delete keyframes from selected objects", "Delete", Warning
ANIM_OT_keyframe_clear_v3d
- "Remove animation from selected objects", "Remove", Warning
ARMATURE_OT_delete
- "Delete selected bones", "Delete", Warning
ARMATURE_OT_separate
- "Move selected bones to a separate armature", "Separate", Warning
CURVE_OT_separate
- "Move selected points to a new object", "Separate", Warning
MASK_OT_delete
- "Delete selected control points and splines", "Delete", Warning
MBALL_OT_delete_metaelems
- "Delete selected metaball elements", "Delete"
OBJECT_OT_delete
- "Delete selected objects", "Delete", Warning
OBJECT_OT_vertex_parent_set
- "Parent selected objects to the selected vertices", "Parent", Warning
OBJECT_OT_parent_no_inverse_set
- "Make Parent without inverse correction", "Parent", Warning
ACTION_OT_delete
- "Delete selected keyframes", "Delete", Warning
CLIP_OT_graph_delete_curve
- "Delete track corresponding to the selected curve", "Delete", Warning
CLIP_OT_delete_track
- "Delete selected tracks", "Delete", Warning
CLIP_OT_delete_marker
- "Delete marker for current frame from selected tracks", "Delete", Warning
FILE_OT_directory_new
- "Create New Directory", "Create", Warning
GRAPH_OT_delete
- "Delete selected keyframes", "Delete", Warning
GRAPH_OT_keys_to_samples
- "Convert selected keys to samples", "Convert", Warning
NLA_OT_make_single_user
- "Make each action single-user in the selects strips", "Make Single", Warning

Properties Dialogs Done

IMAGE_OT_new
- "Create a New Image", "New Image"
OUTLINER_OT_orphans_purge
- "Purge Unused Data From This File", "Delete"
TEXT_OT_jump
- "Jump to Line Number", "Jump"
ARMATURE_OT_move_to_collection
- "Move to New Collection", "Move"
POSE_OT_paths_calculate
- "Calculate Paths for the Selected Bones", "Calculate"
WM_OT_stl_import
- "Import {} files" or filepath, "Import STL"
WM_OT_usd_import
- "Import {} files" or filepath, "Import USD"
WM_OT_ply_import
- "Import {} files" or filepath, "Import PLY"
WM_OT_obj_import
- "Import {} files" or filepath, "Import Wavefront OBJ"
WM_OT_gpencil_import_svg
- "Import {} files" or filepath, "Import STL", "Import SVG"
WM_OT_collada_import
- "Import {} files" or filepath, "Import COLLADA"
WM_OT_alembic_import
- "Import {} files" or filepath, "Import Alembic"
GEOMETRY_OT_attribute_convert
- "Convert Attribute Domain", "Convert"
GEOMETRY_OT_color_attribute_convert
- "Convert Color Attribute Domain", "Convert"
GPENCIL_OT_bake_grease_pencil_animation
- "Bake Object Transform to Grease Pencil", "Bake"
GPENCIL_OT_bake_mesh_animation
- "Bake Mesh Animation to Grease Pencil", "Bake"
ED_gpencil_new_layer_dialog
- "Add New Layer", "Add"
OBJECT_OT_paths_calculate
- "Calculate Object Motion Paths", "Calculate"
OBJECT_OT_move_to_collection (when new)
- "Move to New Collection", "Create"
PAINT_OT_add_texture_paint_slot
- "Add Paint Slot", "Add"
IMAGE_OT_resize
- "Scale Image to New Size", "Resize"
IMAGE_OT_tile_add
- "Add Tile to Image", "Add"
IMAGE_OT_tile_fill
- "Fill Tile With Generated Image", "Fill"
OUTLINER_OT_id_remap
- "Remap Data ID" "Remap"
SEQUENCER_OT_enable_proxies
- "Set Selected Strip Proxies", "Set"
WM_OT_debug_menu
- "Set Debug Value", "Set"
WM_OT_stereo3d_set
- "Set Stereo 3D", "Set"

WM_operator_props_popup

ANIM_OT_channels_group
CURVE_OT_spline_weight_set
CURVE_OT_radius_set
CURVES_OT_attribute_set
GEOMETRY_OT_geometry_randomization
MESH_OT_attribute_set
PARTICLE_OT_rekey
SEQUENCER_OT_retiming_segment_speed_set

WM_operator_props_popup_confirm

MARKER_OT_rename
GEOMETRY_OT_attribute_add
GEOMETRY_OT_color_attribute_add
GREASE_PENCIL_OT_clean_loose
grease_pencil_move_to_layer_exec
GREASE_PENCIL_OT_layer_add
MESH_OT_paint_mask_extract
OBJECT_OT_make_single_user
OBJECT_OT_quadriflow_remesh
SEQUENCER_OT_images_separate
PREFERENCES_OT_extension_repo_add
UV_OT_pack_islands
UV_OT_smart_project

Props Dialogs disabled to investigate

MESH_OT_blend_from_shape
- Comment: disable because search popup closes too easily
ACTION_OT_paste
- Comment: Better wait for action redo panel.
GRAPH_OT_paste
- Comment: Better wait for action redo panel.

Properties Dialogs Default Props

IMAGE_OT_new - "name"
TEXT_OT_jump - "line"
ARMATURE_OT_move_to_collection - "new_collection_name"
WM_OT_debug_menu - "debug_value"

We are attempting to improve our various types of dialogs to make them more informative and also be more consistent with each other. Some work has been done. #117528 Changed Properties Dialogs to have a Confirm and Cancel buttons (rather than a single OK button), with configurable confirm button text and title. This way users have clearer instructions, an obvious way to back out, and the look is consistent with the later changes to confirmation dialogs. #117564 allows to create custom operator confirmation dialogs. These can be made in two sizes, small versions for when there is just a single line of message text, and a larger one for when there is a title and a message body. So far we only have a small number of large confirmations using this new system. These use the same dialog as Properties Dialogs, just with different configuration. #117310 added configurable layout separators which in this context allows adding horizontal lines in vertical layouts like dialogs. This allowed for #118051 to add a line between title and content for Properties dialogs. The next steps, and the reason for this document, is to make changes to different dialogs so that they remain consistent and are as informative and useful as possible. The small confirmations especially should have a message that is likely neither the operator name or description, and the button title should be a short verb. ### Confirmations Done * PREFERENCES_OT_extension_repo_remove * WM_OT_clear_recent_files ### Confirmations In Review * [WM_OT_save_homefile](https://projects.blender.org/blender/blender/pulls/117152) * [WM_OT_read_factory_settings](https://projects.blender.org/blender/blender/pulls/117153) * [WM_OT_read_userpref](https://projects.blender.org/blender/blender/pulls/117151) * [OBJECT_OT_transform_apply](https://projects.blender.org/blender/blender/pulls/117157) * [OBJECT_OT_modifier_apply](https://projects.blender.org/blender/blender/pulls/117156) * [FILE_OT_pack_all](https://projects.blender.org/blender/blender/pulls/117155) * [FILE_OT_unpack_libraries](https://projects.blender.org/blender/blender/pulls/117154) ### Confirmations that cannot be turned off The following might need extra care since they are deemed important enough to not allow disabling * OBJECT_OT_simulation_nodes_cache_bake (when existing bake data) * "Overwrite existing bake data", "Bake", Warning * FILE_OT_delete * "Delete selected files", "Delete", Warning * TEXT_OT_reload * "Reload active text file", "Reload", Warning * TEXT_OT_unlink * "Delete active text file", "Delete", Warning ### Keymap Configurable Confirmations The following are all configurable in the keymap. Most on by default, some turned off * MARKER_OT_delete * "Delete selected markers", "Delete", Warning * ANIM_OT_keyframe_delete_v3d * "Delete keyframes from selected objects", "Delete", Warning * ANIM_OT_keyframe_clear_v3d * "Remove animation from selected objects", "Remove", Warning * ARMATURE_OT_delete * "Delete selected bones", "Delete", Warning * ARMATURE_OT_separate * "Move selected bones to a separate armature", "Separate", Warning * CURVE_OT_separate * "Move selected points to a new object", "Separate", Warning * MASK_OT_delete * "Delete selected control points and splines", "Delete", Warning * MBALL_OT_delete_metaelems * "Delete selected metaball elements", "Delete" * OBJECT_OT_delete * "Delete selected objects", "Delete", Warning * OBJECT_OT_vertex_parent_set * "Parent selected objects to the selected vertices", "Parent", Warning * OBJECT_OT_parent_no_inverse_set * "Make Parent without inverse correction", "Parent", Warning * ACTION_OT_delete * "Delete selected keyframes", "Delete", Warning * CLIP_OT_graph_delete_curve * "Delete track corresponding to the selected curve", "Delete", Warning * CLIP_OT_delete_track * "Delete selected tracks", "Delete", Warning * CLIP_OT_delete_marker * "Delete marker for current frame from selected tracks", "Delete", Warning * FILE_OT_directory_new * "Create New Directory", "Create", Warning * GRAPH_OT_delete * "Delete selected keyframes", "Delete", Warning * GRAPH_OT_keys_to_samples * "Convert selected keys to samples", "Convert", Warning * NLA_OT_make_single_user * "Make each action single-user in the selects strips", "Make Single", Warning ### Properties Dialogs Done * IMAGE_OT_new * "Create a New Image", "New Image" * OUTLINER_OT_orphans_purge * "Purge Unused Data From This File", "Delete" * TEXT_OT_jump * "Jump to Line Number", "Jump" * ARMATURE_OT_move_to_collection * "Move to New Collection", "Move" * POSE_OT_paths_calculate * "Calculate Paths for the Selected Bones", "Calculate" * WM_OT_stl_import * "Import {} files" or filepath, "Import STL" * WM_OT_usd_import * "Import {} files" or filepath, "Import USD" * WM_OT_ply_import * "Import {} files" or filepath, "Import PLY" * WM_OT_obj_import * "Import {} files" or filepath, "Import Wavefront OBJ" * WM_OT_gpencil_import_svg * "Import {} files" or filepath, "Import STL", "Import SVG" * WM_OT_collada_import * "Import {} files" or filepath, "Import COLLADA" * WM_OT_alembic_import * "Import {} files" or filepath, "Import Alembic" * GEOMETRY_OT_attribute_convert * "Convert Attribute Domain", "Convert" * GEOMETRY_OT_color_attribute_convert * "Convert Color Attribute Domain", "Convert" * GPENCIL_OT_bake_grease_pencil_animation * "Bake Object Transform to Grease Pencil", "Bake" * GPENCIL_OT_bake_mesh_animation * "Bake Mesh Animation to Grease Pencil", "Bake" * ED_gpencil_new_layer_dialog * "Add New Layer", "Add" * OBJECT_OT_paths_calculate * "Calculate Object Motion Paths", "Calculate" * OBJECT_OT_move_to_collection (when new) * "Move to New Collection", "Create" * PAINT_OT_add_texture_paint_slot * "Add Paint Slot", "Add" * IMAGE_OT_resize * "Scale Image to New Size", "Resize" * IMAGE_OT_tile_add * "Add Tile to Image", "Add" * IMAGE_OT_tile_fill * "Fill Tile With Generated Image", "Fill" * OUTLINER_OT_id_remap * "Remap Data ID" "Remap" * SEQUENCER_OT_enable_proxies * "Set Selected Strip Proxies", "Set" * WM_OT_debug_menu * "Set Debug Value", "Set" * WM_OT_stereo3d_set * "Set Stereo 3D", "Set" ### WM_operator_props_popup * ANIM_OT_channels_group * CURVE_OT_spline_weight_set * CURVE_OT_radius_set * CURVES_OT_attribute_set * GEOMETRY_OT_geometry_randomization * MESH_OT_attribute_set * PARTICLE_OT_rekey * SEQUENCER_OT_retiming_segment_speed_set ### WM_operator_props_popup_confirm * MARKER_OT_rename * GEOMETRY_OT_attribute_add * GEOMETRY_OT_color_attribute_add * GREASE_PENCIL_OT_clean_loose * grease_pencil_move_to_layer_exec * GREASE_PENCIL_OT_layer_add * MESH_OT_paint_mask_extract * OBJECT_OT_make_single_user * OBJECT_OT_quadriflow_remesh * SEQUENCER_OT_images_separate * PREFERENCES_OT_extension_repo_add * UV_OT_pack_islands * UV_OT_smart_project ### Props Dialogs disabled to investigate * MESH_OT_blend_from_shape * Comment: disable because search popup closes too easily * ACTION_OT_paste * Comment: Better wait for action redo panel. * GRAPH_OT_paste * Comment: Better wait for action redo panel. ### Properties Dialogs Default Props * IMAGE_OT_new - "name" * TEXT_OT_jump - "line" * ARMATURE_OT_move_to_collection - "new_collection_name" * WM_OT_debug_menu - "debug_value"

Harley Acheson added the

Type

To Do

label 2024-02-15 19:14:49 +01:00

Harley Acheson added this to the User Interface project 2024-02-15 19:14:53 +01:00

Harley Acheson referenced this issue

2024-02-15 21:35:24 +01:00

UI: Changes to Small Operator Confirmations #118346

Harley Acheson referenced this issue

2024-03-01 00:06:42 +01:00

Roadmap #118940

Sign in to join this conversation.