UI: Improvements to Confirmation of Apply Transforms #117157

Harley Acheson · 2024-01-16T03:18:57+01:00

Harley Acheson commented

2024-01-16 03:18:57 +01:00

A more informative confirmation dialog to confirm that the user wishes
to apply transforms to an object with multiple users.

Current

Proposed

A more informative confirmation dialog to confirm that the user wishes to apply transforms to an object with multiple users. --- Current ![image](/attachments/8dada088-8fe4-4ccd-a46d-69d9d461c392) Proposed ![image](/attachments/7b72e420-f288-45cf-bfe1-d71106c81452)

34 KiB

28 KiB

28 KiB

28 KiB

24 KiB

36 KiB

23 KiB

image.png

27 KiB

image.png

22 KiB

image.png

36 KiB

image.png

33 KiB

Harley Acheson added 1 commit 2024-01-16 03:19:01 +01:00

a76181c191 UI: Improvements to Confirmation of Apply Transforms

A more informative confirmation dialog to confirm that the user wishes
to apply transforms to an object with multiple users.

Harley Acheson added this to the User Interface project 2024-01-16 03:19:17 +01:00

Harley Acheson requested review from Pablo Vazquez 2024-01-16 03:19:38 +01:00

thorn-neverwake commented

2024-01-17 14:59:04 +01:00

First-time contributor

While this PR does not create the following problem, it does repeat an existing problem - the error message itself is rather misleading and confusing.

Specifically, "Create new object-data users..."

If I hit Cntl A, to apply Scale on a cube with several instanced copies - how exactly is this creating "new users"? New users implies "some additional new cubes are going to be created." This is obviously not what happens.

While this PR does not create the following problem, it does repeat an existing problem - the error message *itself* is rather misleading and confusing. Specifically, **"Create new object-data users..."** If I hit Cntl A, to apply Scale on a cube with several instanced copies - how exactly is this creating "new users"? New users implies "some additional new cubes are going to be created." This is obviously not what happens.

Harley Acheson referenced this pull request

2024-01-17 17:26:52 +01:00

UI: Cleanup Dialog to Manage Orphaned Data #117242

Brecht Van Lommel commented

2024-01-17 19:43:07 +01:00

It will duplicate mesh and curve datablocks, which is what "object-data users" is referring to.

Maybe more clear wording would be: "Duplicate geometry data-blocks and apply transformations"

It will duplicate mesh and curve datablocks, which is what "object-data users" is referring to. Maybe more clear wording would be: "Duplicate geometry data-blocks and apply transformations"

Harley Acheson added 2 commits 2024-01-17 20:10:22 +01:00

a5aedeca66 Merge branch 'main' of projects.blender.org:blender/blender into ConfirmApplyTransforms

4ab6acb626 Dialog content changes

Harley Acheson commented

2024-01-17 20:11:20 +01:00

I simplified the title slightly to "Apply Object Transformations" and the message to Brecht's suggested "Duplicate geometry data-blocks and apply transformations". Updated the captures in the first comment.

👍 1

Brecht Van Lommel commented

2024-01-17 20:15:44 +01:00

Sorry, looking at this again I think we could explain it a little better:
"Duplicate geometry data-blocks with multiple users and apply transformations"

Sorry, looking at this again I think we could explain it a little better: "Duplicate geometry data-blocks with multiple users and apply transformations"

Harley Acheson added 1 commit 2024-01-17 20:19:25 +01:00

476b5de0fb Dialog content changes

Harley Acheson commented

2024-01-17 20:19:54 +01:00

Updated message to "Duplicate geometry data-blocks with multiple users and apply transformations". Capture in first comment updated.

thorn-neverwake commented

2024-01-17 20:57:49 +01:00

First-time contributor

Perhaps something less... I don't know... rigidly code-speak?

"apply transformations to all objects sharing this data"

Perhaps something less... I don't know... rigidly code-speak? "apply transformations to all objects sharing this data"

Harley Acheson commented

2024-01-17 21:29:30 +01:00

Perhaps..."apply transformations to all objects sharing this data"

I do like the friendlier "sharing this data". But the "this" might be unclear, "all objects" could be misunderstood, and I think it misses the bit where shared data gets duplicated.

We could use two message lines:

"Warning: Multiple objects share the same data."
"Make single user and then apply transformations?"

> Perhaps..."apply transformations to all objects sharing this data" I do like the friendlier "sharing this data". But the "this" might be unclear, "all objects" could be misunderstood, and I think it misses the bit where shared data gets duplicated. We could use two message lines: "Warning: Multiple objects share the same data." "Make single user and then apply transformations?"

Brecht Van Lommel commented

2024-01-17 22:16:00 +01:00

I think the two lines help.

An alternative for the second line could be "Duplicate geometry data before applying transformations?"

But either works.

I think the two lines help. An alternative for the second line could be "Duplicate geometry data before applying transformations?" But either works.

thorn-neverwake commented

2024-01-17 23:26:51 +01:00

First-time contributor

We could use two message lines:

"Warning: Multiple objects share the same data."
"Make single user and then apply transformations?"

I like that, as it doesn't make the artist have to think about what a word means.

(Sometimes blender uses words in unique ways, that blur the intended comprehension)

> We could use two message lines: > > "Warning: Multiple objects share the same data." > "Make single user and then apply transformations?" > I like that, as it doesn't make the artist have to think about what a word means. (Sometimes blender uses words in unique ways, that blur the intended comprehension)

Harley Acheson commented

2024-01-18 00:33:00 +01:00

One thing I'm trying to avoid are questions that beg for a "yes" or "no" answer. This can cause some hesitation where you have to work out exactly what you are answering yes or no to, and this gets a bit harder for people using a language that is not their first. By putting verbs on the buttons, like "Delete" or "Apply", or "Save" it removes that possible confusion.

One thing I'm _trying_ to avoid are questions that beg for a "yes" or "no" answer. This can cause some hesitation where you have to work out exactly what you are answering yes or no to, and this gets a bit harder for people using a language that is not their first. By putting verbs on the buttons, like "Delete" or "Apply", or "Save" it removes that possible confusion.

👍 2

Harley Acheson added 1 commit 2024-01-18 00:38:30 +01:00

6b98000c9c Dialog content changes

Bastien Montagne referenced this pull request

2024-01-18 22:29:19 +01:00

UI: Cleanup Dialog to Manage Orphaned Data #117242

Harley Acheson added 2 commits 2024-01-25 20:46:26 +01:00

d01bb6244d Merge branch 'main' of projects.blender.org:blender/blender into ConfirmApplyTransforms

a160144a57 Updating after recent refactors.

Harley Acheson referenced this pull request

2024-01-27 03:58:02 +01:00

UI: Operator Confirm Dialog Changes #117564