UI: Changes to Small Operator Confirmations #118346

Harley Acheson · 2024-02-15T21:26:39+01:00

Harley Acheson commented

2024-02-15 21:26:39 +01:00

Small operator confirmations get separate confirm and cancel buttons,
better descriptions and configurable confirm button text. But still
popup at cursor location and can be cancelled with mouse movement.

I should preface this by stating some obvious things. Nobody likes excessive "are you sure?" confirmations. We will be working to remove some where we can, and possibly make others user configurable. But we still have some, and while we do this PR makes them work a bit better.

First it adds separate "Cancel" button and swaps things around slightly. The operation remains the same though. These pop up at your mouse cursor location with the confirm button under your mouse. You can execute them by clicking your mouse or hitting "Enter" on your keyboard. You can cancel by clicking the button, hitting "Escape", or by moving your mouse cursor out of the area.

So by default a generic operator, here using "Object Delete" as example, goes from the one illustrated above to shown below:

But then the PR goes further and adds custom message text and button text for ALL current confirmations. This means that "Object Delete" actually looks like this:

If you want to review exactly what text is used on each confirmation, they can be seen on one page here: #118341

Small operator confirmations get separate confirm and cancel buttons, better descriptions and configurable confirm button text. But still popup at cursor location and can be cancelled with mouse movement. --- I should preface this by stating some obvious things. Nobody likes excessive "are you sure?" confirmations. We will be working to remove some where we can, and possibly make others user configurable. But we still have some, and while we do this PR makes them work a bit better. First it adds separate "Cancel" button and swaps things around slightly. The operation remains the same though. These pop up at your mouse cursor location with the confirm button under your mouse. You can execute them by clicking your mouse or hitting "Enter" on your keyboard. You can cancel by clicking the button, hitting "Escape", or by moving your mouse cursor out of the area. So by default a generic operator, here using "Object Delete" as example, goes from the one illustrated above to shown below: ![image](/attachments/029a0129-c19b-4d81-b0fd-95389b478b32) But then the PR goes further and adds custom message text and button text for **ALL** current confirmations. This means that "Object Delete" actually looks like this: ![image](/attachments/3ee003c0-999a-47c4-bc49-c33a04bc6744) If you want to review exactly what text is used on each confirmation, they can be seen on one page here: #118341

image.png

8.9 KiB

image.png

13 KiB

9.4 KiB

15 KiB

14 KiB

15 KiB

9.9 KiB

👍 3

Hans Goudey commented

2024-02-15 21:36:47 +01:00

How about removing the ? from the default OK?. That's probably a bit more standard and reads more like a button that will do something.

How about removing the `?` from the default `OK?`. That's probably a bit more standard and reads more like a button that will do something.

Harley Acheson added this to the User Interface project 2024-02-15 21:36:52 +01:00

Harley Acheson commented

2024-02-16 00:02:12 +01:00

@HooglyBoogly - How about removing the ? from the default OK?...

Yes! I was trying to make as little change as possible, but this looks way less goofy. Thanks!

> @HooglyBoogly - How about removing the `?` from the default `OK?`... Yes! I was trying to make as little change as possible, but this looks way less goofy. Thanks!

Harley Acheson commented

2024-02-16 04:35:28 +01:00

@TheRedWaxPolice

I somehow managed to edit your comment instead of replying to it. Will try to recreate below and delete your comment above because it looks like you said something you did not. Sorry about that.

That's actually the most annoying feature of those "small" popups imo

I agree, but enough people like it as a very fast dismissal. This PR is about making them a bit more informative with as little disruption as possible.

If only we had a setting to disable that....

That is a possibility, but I don't think I want to tackle that quite yet.

@TheRedWaxPolice I somehow managed to edit your comment instead of replying to it. Will try to recreate below and delete your comment above because it looks like you said something you did not. Sorry about that. > That's actually the most annoying feature of those "small" popups imo I agree, but enough people like it as a very fast dismissal. This PR is about making them a bit more informative with as little disruption as possible. > If only we had a setting to disable that.... That is a possibility, but I don't think I want to tackle that quite yet.

TheRedWaxPolice commented

2024-02-16 11:03:19 +01:00

First-time contributor

enough people like it as a very fast dismissal

Wow, really? Now that's a surprise...

That is a possibility, but I don't think I want to tackle that quite yet.

No worries...
Cheers..

> enough people like it as a very fast dismissal Wow, really? Now that's a surprise... > That is a possibility, but I don't think I want to tackle that quite yet. No worries... Cheers..

Harley Acheson force-pushed SmallConfirmations from 9399cdcfef to ec2493fd57

2024-02-27 23:25:03 +01:00

Compare

Harley Acheson requested review from Pablo Vazquez 2024-03-01 19:36:38 +01:00

Harley Acheson added 1 commit 2024-03-12 20:50:31 +01:00

971ea2027b Merge branch 'main' of projects.blender.org:blender/blender into SmallConfirmations

Harley Acheson added 1 commit 2024-03-12 22:01:36 +01:00