UI: Improvements to Confirmation of Apply Modifier #117156

Harley Acheson · 2024-01-16T03:11:21+01:00

Harley Acheson commented

2024-01-16 03:11:21 +01:00

A more informative confirmation dialog to confirm that the user wishes
to apply modifier to an object with multiple users.

Current

Proposed

A more informative confirmation dialog to confirm that the user wishes to apply modifier to an object **with multiple users**. --- Current ![image](/attachments/a58f4934-f41b-455f-a40d-6f2a86e5ea9e) Proposed ![image](/attachments/c3a99aa8-f8dd-49e7-95a5-b78c250d5275)

image.png

18 KiB

image.png

26 KiB

image.png

23 KiB

image.png

18 KiB

image.png

16 KiB

image.png

36 KiB

image.png

19 KiB

Harley Acheson added 1 commit 2024-01-16 03:11:27 +01:00

6f9577bdfe UI: Improvements to Confirmation of Apply Modifier

A more informative confirmation dialog to confirm that the user wishes
to apply modifier to an object with multiple users.

Harley Acheson added this to the User Interface project 2024-01-16 03:11:53 +01:00

Harley Acheson requested review from Pablo Vazquez 2024-01-16 03:12:05 +01:00

Hadrien commented

2024-01-16 17:26:02 +01:00

First-time contributor

Just a quick note, right now these two statements (the dialog title, and the dialog message) contain 3 items, 1 of which ("Apply modifier") is common to both sentences, but in a reversed order. This muddies a bit the conveyed meaning and the order of operations (=1.data is made single-user, 2.modifier is applied, and 3.modifier is removed)

Since the modifier being removed is a consequence of applying it, I would change the tooltip in object.modifier_apply() to solely "Apply modifier". I assume the additional information was initially added there because the old dialog infrastructure didn't allow for extended descriptions, so perhaps move the mention of the modifier being removed inside this new description (the one from this commit) : "Make data single-user, apply modifier and remove it from the stack".

Finally, I would change "modifier stack" to "modifier list" because stack suggests a bottom-to-top order -like 2D layers-, whereas modifiers are evaluated top-to-bottom. I think there's a mixed usage in the interface, as I remember reading "modifier list" (not sure where exacty or how to search for it efficiently).

Just a quick note, right now these two statements (the dialog title, and the dialog message) contain 3 items, 1 of which ("Apply modifier") is common to both sentences, but in a reversed order. This muddies a bit the conveyed meaning and the order of operations (=1.data is made single-user, 2.modifier is applied, and 3.modifier is removed) Since the modifier being removed is a consequence of applying it, I would change the tooltip in object.modifier_apply() to solely "Apply modifier". I assume the additional information was initially added there because the old dialog infrastructure didn't allow for extended descriptions, so perhaps move the mention of the modifier being removed inside this new description (the one from this commit) : "Make data single-user, apply modifier and remove it from the stack". Finally, I would change "modifier stack" to "modifier list" because stack suggests a bottom-to-top order -like 2D layers-, whereas modifiers are evaluated top-to-bottom. I think there's a mixed usage in the interface, as I remember reading "modifier list" (not sure where exacty or how to search for it efficiently).

👍 1

Harley Acheson added 2 commits 2024-01-16 20:29:59 +01:00

efc1e4aa02 Merge branch 'main' of projects.blender.org:blender/blender into ConfirmApplyModifier

acfce9ed55 Changes to the text of the dialog

Harley Acheson commented

2024-01-16 20:30:54 +01:00

@HadrienBrissaud - I updated the PR and the screen captures in the first comment. Is this what you had in mind?

Jonas Holzman commented

2024-01-17 02:11:44 +01:00

As a small stylistic proposal, we could capitalize "Modifier" only in the dialog title to make it a bit more balanced, resulting in "Apply Modifier", making it closer in style to operator titles, as can be seen in the "Add Modifier" button.

👍 1

Hadrien commented

2024-01-17 02:17:39 +01:00

First-time contributor

@HadrienBrissaud - I updated the PR and the screen captures in the first comment. Is this what you had in mind?

Yes, pretty much. I think we're gaining in clarity by separating the action from its side-effects.

> @HadrienBrissaud - I updated the PR and the screen captures in the first comment. Is this what you had in mind? Yes, pretty much. I think we're gaining in clarity by separating the action from its side-effects.

Harley Acheson added 2 commits 2024-01-17 02:46:51 +01:00

a9435f3bc5 Merge branch 'main' of projects.blender.org:blender/blender into ConfirmApplyModifier

3e8b49cf99 Dialog contents changes

Harley Acheson referenced this pull request

2024-01-17 17:26:52 +01:00

UI: Cleanup Dialog to Manage Orphaned Data #117242

Bastien Montagne referenced this pull request

2024-01-18 22:29:19 +01:00

UI: Cleanup Dialog to Manage Orphaned Data #117242

Harley Acheson added 2 commits 2024-01-25 20:40:44 +01:00

9b4a21b55b Merge branch 'main' of projects.blender.org:blender/blender into ConfirmApplyModifier

2e3a832286 Updating after recent refactors