UI: Improvements to Confirmation of Load Factory #117153

Harley Acheson · 2024-01-16T02:36:41+01:00

Harley Acheson commented

2024-01-16 02:36:41 +01:00

A more informative confirmation dialog to confirm that the user wishes
to load factory startup and settings.

Current

Proposed, when not in a specific template, and there are currently no unsaved changes:

When there are unsaved changes:

When you are in a template, there is another option in the menu to load just that template's factory startup and preferences. If you do that and have no unsaved changes:

When there are unsaved changes:

A more informative confirmation dialog to confirm that the user wishes to load factory startup and settings. --- Current ![image](/attachments/d11c4f36-7932-435c-b234-8458f3494ecd) Proposed, when not in a specific template, and there are currently no unsaved changes: ![image](/attachments/e9ab60eb-95c2-47be-9fab-8238efaedf25) When there are unsaved changes: ![image](/attachments/a334731f-79fc-4b84-a18e-0d6e368fd98c) When you are in a template, there is another option in the menu to load just that template's factory startup and preferences. If you do that and have no unsaved changes: ![image](/attachments/67446a7b-6c8b-4bda-94a1-da8403f56283) When there are unsaved changes: ![image](/attachments/e16ceda6-3e5b-4559-9b10-c101c7d39ab1)

21 KiB

20 KiB

8.7 KiB

41 KiB

31 KiB

35 KiB

35 KiB

image.png

8.7 KiB

image.png

21 KiB

image.png

26 KiB

image.png

26 KiB

image.png

20 KiB

image.png

21 KiB

image.png

26 KiB

image.png

20 KiB

image.png

27 KiB

👍 1

Harley Acheson added this to the User Interface project 2024-01-16 02:37:53 +01:00

Harley Acheson requested review from Pablo Vazquez 2024-01-16 02:38:04 +01:00

Jonas Holzman commented

2024-01-17 01:53:58 +01:00

Regarding the note title, I think we might want to remove punctuation and capitalize words, following the precedent set by other Dialogs/Operators titles, this would than give us: "Load Factory Default Startup File and Preferences".

Following this, we might also want to capitalize "Preferences" in the dialog message, giving us: "To make changes to Preferences permanent, use "Save Preferences"", this is probably more debatable, but I think it helps highlight the fact that we're talking about the actual Blender Preferences panel here.

Finally, regarding the dialog buttons default state, I get the reasoning behind making "Cancel" the default when the operation is destructive, and "Load" the default otherwise, but since the second dialog is basically a variation on the first one, it might be more interesting to be consistent between them and always make "Cancel" the default. This has the aesthetical advantage of having the selected/highlighted button always be on the right side of the dialog.

Regarding the note title, I think we might want to remove punctuation and capitalize words, following the precedent set by other Dialogs/Operators titles, this would than give us: "Load Factory Default Startup File and Preferences". Following this, we might also want to capitalize "Preferences" in the dialog message, giving us: "To make changes to Preferences permanent, use "Save Preferences"", this is probably more debatable, but I think it helps highlight the fact that we're talking about the actual Blender Preferences panel here. Finally, regarding the dialog buttons default state, I get the reasoning behind making "Cancel" the default when the operation is destructive, and "Load" the default otherwise, but since the second dialog is basically a variation on the first one, it might be more interesting to be consistent between them and always make "Cancel" the default. This has the aesthetical advantage of having the selected/highlighted button always be on the right side of the dialog.

👍 2

Jonas Holzman referenced this pull request

2024-01-17 02:02:38 +01:00

UI: Improvements to Confirmation of Load Factory Preferences #117151

Jonas Holzman referenced this pull request

2024-01-17 02:31:23 +01:00

UI: Improvements to Confirmation of Save Startup #117152

Julien Kaspar commented

2024-01-17 17:18:12 +01:00

I totally agree that the blue highlight should not be on "Cancel".

From the recent module meeting I'd also like to reiterate on a point:
The message "To make changes permanent, use 'Save Preferences'." is easily leading to wrong conclusions.
We must not add another option to 'Save Preferences' in order to "save the user time", like it was mentioned in the meeting. That's not what this message is trying to say.

It's about reassuring the user that the preferences are only temporarily reverted. Only if they manually save their preferences after loading the factory prefereces, will this actually be a destructive action.
"Saving Preferences" is an undesireable action.

I totally agree that the blue highlight should not be on "Cancel". From the recent module meeting I'd also like to reiterate on a point: The message "To make changes permanent, use 'Save Preferences'." is easily leading to wrong conclusions. We must not add another option to 'Save Preferences' in order to "save the user time", like it was mentioned in the meeting. That's not what this message is trying to say. It's about reassuring the user that the preferences are only temporarily reverted. Only if they manually save their preferences after loading the factory prefereces, will this actually be a destructive action. "Saving Preferences" is an undesireable action.

👍 1

Harley Acheson referenced this pull request

2024-01-17 17:26:52 +01:00

UI: Cleanup Dialog to Manage Orphaned Data #117242

Bastien Montagne referenced this pull request

2024-01-18 22:29:19 +01:00

UI: Cleanup Dialog to Manage Orphaned Data #117242

Harley Acheson added this to the 4.2 LTS milestone 2024-02-05 19:28:01 +01:00

Harley Acheson changed title from ~~UI: Improvements to Confirmation of Load Factory~~ to WIP: UI: Improvements to Confirmation of Load Factory

2024-02-13 20:57:25 +01:00

Harley Acheson referenced this pull request

2024-02-15 19:14:49 +01:00

Dialog Improvements #118341

Harley Acheson changed title from ~~WIP: UI: Improvements to Confirmation of Load Factory~~ to UI: Improvements to Confirmation of Load Factory

2024-02-20 01:36:06 +01:00

Harley Acheson force-pushed ConfirmLoadFactory from acd37c4362 to 2638ecb462

2024-03-06 22:45:34 +01:00

Compare

Harley Acheson commented

2024-03-06 22:58:35 +01:00

@blender-bot build

Harley Acheson merged commit 00b4fdce2c into main

2024-03-06 23:26:00 +01:00

Harley Acheson referenced this issue from a commit

2024-03-06 23:26:00 +01:00

UI: Improvements to Confirmation of Load Factory