UI: Tree view, make expand-on-click optional #117402

Closed

Sybren A. Stüvel wants to merge 1 commits from dr.sybren:pr/tree-view-expand-on-click-optional into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Sybren A. Stüvel commented

2024-01-22 11:56:06 +01:00

Member

Make the 'expand-on-click' behavior of tree items optional. It can now
be determined per implementation.

Instead of calling tree_item.set_collapsed(false) directly, it is
replaced with a call to tree_item.on_click(). The base implementation
of that function still calls set_collapsed(false); since this is a
virtual function, it can be overridden by subclasses.

This was the least-intrusive change I could think of. I'm not a huge fan
of this approach, though, as it makes the overridden implementation
dependent on the exact implementation of the base function.

Personally I think having the base function empty would be better; in
that case any subclass that wants to retain the expand-on-click behavior
should call set_collapsed(false) in their override.

Alternatively we could have some flag that controls this behavior. That
flag can then be set on subclasses, or even controlled by a user
preference. Not sure if that's the way we want to go with this, though.

Make the 'expand-on-click' behavior of tree items optional. It can now be determined per implementation. Instead of calling `tree_item.set_collapsed(false)` directly, it is replaced with a call to `tree_item.on_click()`. The base implementation of that function still calls `set_collapsed(false)`; since this is a virtual function, it can be overridden by subclasses. --------------- This was the least-intrusive change I could think of. I'm not a huge fan of this approach, though, as it makes the overridden implementation dependent on the exact implementation of the base function. Personally I think having the base function empty would be better; in that case any subclass that wants to retain the expand-on-click behavior should call `set_collapsed(false)` in their override. Alternatively we could have some flag that controls this behavior. That flag can then be set on subclasses, or even controlled by a user preference. Not sure if that's the way we want to go with this, though.

Sybren A. Stüvel added this to the 4.1 milestone 2024-01-22 11:56:06 +01:00

Sybren A. Stüvel added the

Animation & Rigging

labels 2024-01-22 11:56:06 +01:00

Sybren A. Stüvel added 1 commit 2024-01-22 11:56:14 +01:00

123deb9017 UI: Tree view, make expand-on-click optional

Make the 'expand-on-click' behavior of tree items optional. It can now
be determined per implementation.

Instead of calling `tree_item.set_collapsed(false)` directly, it is
replaced with a call to `tree_item.on_click()`. The base implementation
of that function still calls `set_collapsed(false)`; since this is a
virtual function, it can be overridden by subclasses.

---------------

This was the least-intrusive change I could think of. I'm not a huge fan
of this approach, though, as it makes the overridden implementation
dependent on the exact implementation of the base function.

Personally I think having the base function empty would be better; in
that case any subclass that wants to retain the expand-on-click behavior
should call `set_collapsed(false)` in their override.

Alternatively we could have some flag that controls this behavior. That
flag can then be set on subclasses, or even controlled by a user
preference. Not sure if that's the way we want to go with this, though.

Sybren A. Stüvel referenced this pull request

2024-01-22 11:56:51 +01:00

Nested Bone Collections 4.1 Notes #116795

Sybren A. Stüvel requested review from Julian Eisel 2024-01-22 17:22:35 +01:00

Sybren A. Stüvel commented

2024-01-30 15:54:23 +01:00

Author

Member

Abandoning this PR after a few small face-to-face discussions with @filedescriptor , @LukasTonne , @Sergey , and @JulianEisel . All felt either that the 'auto-expand on click' was undesirable, or that it didn't matter much and that consistency between tree views was the most important.

In the end @JulianEisel and I agreed to just commit a one-liner change that removes the set_collapsed(false); call.

Abandoning this PR after a few small face-to-face discussions with @filedescriptor , @LukasTonne , @Sergey , and @JulianEisel . All felt either that the 'auto-expand on click' was undesirable, or that it didn't matter much and that consistency between tree views was the most important. In the end @JulianEisel and I agreed to just commit a one-liner change that removes the `set_collapsed(false);` call.

Sybren A. Stüvel closed this pull request

2024-01-30 15:54:26 +01:00

Sybren A. Stüvel deleted branch pr/tree-view-expand-on-click-optional

2024-01-30 15:54:37 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#117402

No description provided.