Fixes setting object bound dimensions using Multiple Value Edition from UI. #117731

Open
Jaume Bellet wants to merge 1 commits from JaumeBellet/blender:pr-0019-object-dimensions-set-fix into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.
First-time contributor

Setting object bound dimensions using Multiple Value Edition from UI. Was failing, according to message set on RNA info due to cached values.

This patch solves it resetting the cached bounds, and updating the local object_to_world matrix.

It does not recompute the min-max values based on geometry as this stored on another cache and is not necessary because current implementations works changing the scale vector of the object. The matrix must be set to match the scale, as the value is recovered just after set.

It also adds the values on Object Panel.

Setting object bound dimensions using Multiple Value Edition from UI. Was failing, according to message set on RNA info due to cached values. This patch solves it resetting the cached bounds, and updating the local object_to_world matrix. It does not recompute the min-max values based on geometry as this stored on another cache and is not necessary because current implementations works changing the scale vector of the object. The matrix must be set to match the scale, as the value is recovered just after set. It also adds the values on Object Panel.
Jaume Bellet added 1 commit 2024-02-01 19:24:35 +01:00
37c4f67821 Fixes setting object bound dimensions using Multiple Value Edition from UI.
Was failing, according to message set on RNA info due to cached values.

Solves it resetting the cached bounds, and updating the local
object_to_world matrix.

It does not recompute the min-max values based on geometry as this
stored on another cache and is not necessary because current
implementations works changing the scale vector of the object. The
matrix must be set to match the scale, as the value is recovered just
after set.

It also adds the values on Object Panel.
Author
First-time contributor

Also, the Object Dimensions fields on View Properties are not drawn using the RNA, they are drawn directly from C/C++. I see it's using transform, maybe as a workaround. If this patch is applied, could be replaced ?

Also, the Object Dimensions fields on View Properties are not drawn using the RNA, they are drawn directly from C/C++. I see it's using transform, maybe as a workaround. If this patch is applied, could be replaced ?
Iliya Katushenock added the
Module
User Interface
Interest
Python API
labels 2024-02-01 19:31:42 +01:00
Iliya Katushenock added this to the Modeling project 2024-02-01 19:31:58 +01:00
Jaume Bellet changed title from WIP: Fixes setting object bound dimensions using Multiple Value Edition from UI. to Fixes setting object bound dimensions using Multiple Value Edition from UI. 2024-02-01 19:34:33 +01:00
Merge conflict checking is in progress. Try again in few moments.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u pr-0019-object-dimensions-set-fix:JaumeBellet-pr-0019-object-dimensions-set-fix
git checkout JaumeBellet-pr-0019-object-dimensions-set-fix
Sign in to join this conversation.
No reviewers
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#117731
No description provided.