VSE: tweak look of Vectorscope to match upcoming Image vectorscope #117738

Aras Pranckevicius · 2024-02-01T20:26:30+01:00

2024-02-01 20:26:30 +01:00

Image vectorscope is getting some visual updates (#116974), here make the Sequencer vectorscope match the look fairly closely:

Use same scaling factor for both U & V, instead of trying to use all the texture space.
Instead of drawing hexagonal area between color primary "pure" and "75% saturation safe" points, draw a circle with colored background and five inner rings.
Indicate "75% saturation primaries" as wire rectangles with a text label.

Here's how the scope looks now (left: image, right: sequencer). The image scope is as it is on main right now, i.e. without #116974 improvement:

Here's how it looks before this PR (i.e. on main right now):

And for comparison, here's how sequencer scope used to look in Blender 4.0 (i.e. before #116798).

Image vectorscope is getting some visual updates (#116974), here make the Sequencer vectorscope match the look fairly closely: - Use same scaling factor for both U & V, instead of trying to use all the texture space. - Instead of drawing hexagonal area between color primary "pure" and "75% saturation safe" points, draw a circle with colored background and five inner rings. - Indicate "75% saturation primaries" as wire rectangles with a text label. Here's how the scope looks now (left: image, right: sequencer). The image scope is as it is on main right now, i.e. without #116974 improvement: ![vse_scopes_41now.png](/attachments/db45bb62-d7e7-440d-a713-8b1d693ddd0e) Here's how it looks before this PR (i.e. on main right now): ![vse_scopes_41before.png](/attachments/36c44443-8892-4ce6-9e96-057ff9184878) And for comparison, here's how sequencer scope used to look in Blender 4.0 (i.e. before #116798). ![vse_scopes_40.png](/attachments/f8073a69-7c93-46ab-872b-f92354e46642)

vse_scopes_41before.png

293 KiB

vse_scopes_41now.png

326 KiB

vse_scopes_40.png

239 KiB

👍 2 ❤️ 6 🚀 7

Aras Pranckevicius added 1 commit 2024-02-01 20:26:40 +01:00

buildbot/vexp-code-patch-lint Build done. Details

buildbot/vexp-code-patch-linux-x86_64 Build done. Details

buildbot/vexp-code-patch-darwin-x86_64 Build done. Details

buildbot/vexp-code-patch-windows-amd64 Build done. Details

buildbot/vexp-code-patch-darwin-arm64 Build done. Details

buildbot/vexp-code-patch-coordinator Build done. Details

f60038e50a VSE: tweak look of Vectorscope to match upcoming Image vectorscope

Image vectorscope is getting some visual updates (#116974), here
make the Sequencer vectorscope match the look fairly closely:

- Use same scaling factor for both U & V, instead of trying to use
  all the texture space.
- Instead of drawing hexagonal area between color primary "pure"
  and "75% saturation safe" points, draw a circle with colored
  background and five inner rings.
- Indicate "75% saturation primaries" as wire rectangles with a
  text label.

Aras Pranckevicius referenced this pull request

2024-02-01 20:28:16 +01:00

Image Editor Vectorscope Improvement #116974

Aras Pranckevicius commented

2024-02-01 20:28:32 +01:00

@blender-bot build

Aras Pranckevicius added this to the Video Sequencer project 2024-02-01 20:42:08 +01:00

Aras Pranckevicius requested review from Richard Antalik 2024-02-01 20:44:23 +01:00

Richard Antalik commented

2024-02-02 19:21:48 +01:00

I think I applied patch on some random commit after bisecting yesterday, so it failed to build.

Now checking with random video, and I thing there may be some discrepancy - cyan and green values seem to be off the scale, which IMO shouldn't happen with 8-bit image. So I would expect this to be incorrect, but I am not really sure. Perhaps I read the scope incorrectly?
Attaching sample video, that is giving different values.

Also this makes the scope effectively smaller, which may be good for HDR footage, but I would probably want to conserve the same hexagon size if possible. Not sure if you can zoom out in panel scopes.

I think I applied patch on some random commit after bisecting yesterday, so it failed to build. Now checking with random video, and I thing there may be some discrepancy - cyan and green values seem to be off the scale, which IMO shouldn't happen with 8-bit image. So I would expect this to be incorrect, but I am not really sure. Perhaps I read the scope incorrectly? Attaching sample video, that is giving different values. ![Screenshot_2024-02-02_19-19-21.png](/attachments/7c30d442-3378-4f08-8e6a-d7718bfa4ad7) Also this makes the scope effectively smaller, which may be good for HDR footage, but I would probably want to conserve the same hexagon size if possible. Not sure if you can zoom out in panel scopes.

2024-01-07 21-30-38.mkv

1.6 MiB

Screenshot_2024-02-02_19-19-21.png

146 KiB

Richard Antalik commented

2024-02-02 19:51:50 +01:00

Sorry, now looking at panel scope with the same image, it seems, that I just read the new scope incorrectly. So I take my comment back apart from that it could be bit larger.

Richard Antalik approved these changes 2024-02-02 19:52:14 +01:00

Aras Pranckevicius commented

2024-02-02 20:55:38 +01:00

Yeah, the "outer polygon" (full saturation) of the previous scope is not explicitly displayed in the new one. This matches the image scope, which also does not do it. From what I've seen, various other applications with vector scopes also don't do that; they indicate the "75% saturation" color places beyond which is generally "not advisable to go", and they don't bother indicating where the "full saturation" would happen since it's assumed that "well made media" will never go there anyway.

I would probably want to conserve the same hexagon size if possible. Not sure if you can zoom out in panel scopes.

The actual pixels that are displayed are still exact same zoom ratio, just the "reticule" (background - hexagon previously, circle now) has both changed shape and how much of screen area it takes up.

Yeah, the "outer polygon" (full saturation) of the previous scope is not explicitly displayed in the new one. This matches the image scope, which also does not do it. From what I've seen, various other applications with vector scopes also don't do that; they indicate the "75% saturation" color places beyond which is generally "not advisable to go", and they don't bother indicating where the "full saturation" would happen since it's assumed that "well made media" will never go there anyway. > I would probably want to conserve the same hexagon size if possible. Not sure if you can zoom out in panel scopes. The actual pixels that are displayed are still exact same zoom ratio, just the "reticule" (background - hexagon previously, circle now) has both changed shape and how much of screen area it takes up.

Aras Pranckevicius merged commit 5ff0feee52 into main

2024-02-02 20:59:12 +01:00

Aras Pranckevicius referenced this issue from a commit

2024-02-02 20:59:13 +01:00

VSE: tweak look of Vectorscope to match upcoming Image vectorscope

Aras Pranckevicius deleted branch vse-scopes

2024-02-02 20:59:14 +01:00

YimingWu referenced this issue from a commit

2024-02-05 10:56:06 +01:00

VSE: tweak look of Vectorscope to match upcoming Image vectorscope

Jonas Dichelle referenced this issue from a commit

2024-02-08 17:29:08 +01:00