Geometry Nodes: Sample by ID node #118092

Open
Iliya Katushenock wants to merge 16 commits from mod_moder/blender:sample_by_id into main

When changing the target branch, be careful to rebase the branch in your fork to match. See documentation.

Sample by ID is node to find index of ID in some geometry. It is useful for associative mapping, so index attribute can be used even if geometry was changes and indices are out of date. Result of node is index of element in selected domain. If there is no such ID of domain element then 0 index will be retrieved (and Is Valid output also indicate this). If multiple elements have the same ID, only first is considered. Index of element can be used next to sample attribute, for index math and etc.
image

See: #114278.

Sample by ID is node to find index of ID in some geometry. It is useful for associative mapping, so index attribute can be used even if geometry was changes and indices are out of date. Result of node is index of element in selected domain. If there is no such ID of domain element then 0 index will be retrieved (and `Is Valid` output also indicate this). If multiple elements have the same ID, only first is considered. Index of element can be used next to sample attribute, for index math and etc. ![image](/attachments/6474d3ed-ec3a-47a2-be2f-1a1b7ef4526a) See: #114278.
Iliya Katushenock added the
Interest
Geometry Nodes
label 2024-02-10 21:56:01 +01:00
Iliya Katushenock added 2 commits 2024-02-10 21:56:11 +01:00
Iliya Katushenock added 1 commit 2024-02-10 23:14:40 +01:00
Iliya Katushenock added this to the Nodes & Physics project 2024-02-10 23:30:06 +01:00
First-time contributor

why are we going through so many implementations lol 😆. we have the Index Map the Sample by Group ID and now Sample by ID 🤔.

for the record I still like the first Implementation the best (with the multi sockets) 👌.

I wish you success.

why are we going through so many implementations lol 😆. we have the `Index Map` the `Sample by Group ID` and now `Sample by ID` 🤔. for the record I still like the first Implementation the best (with the multi sockets) 👌. I wish you success.
Hans Goudey requested review from Jacques Lucke 2024-02-14 16:49:57 +01:00
Hans Goudey requested review from Simon Thommes 2024-02-14 16:49:57 +01:00
Hans Goudey requested review from Hans Goudey 2024-02-14 16:49:58 +01:00
Iliya Katushenock added 2 commits 2024-02-14 23:10:05 +01:00
Iliya Katushenock added 1 commit 2024-02-14 23:51:54 +01:00
Iliya Katushenock added 1 commit 2024-02-14 23:53:16 +01:00
Simon Thommes reviewed 2024-02-19 11:50:53 +01:00
Simon Thommes left a comment
Member

Just want to mention that I give it an initial test and it seems to be working great!

I do want to stress test it a bit more though later this week.

Just want to mention that I give it an initial test and it seems to be working great! I do want to stress test it a bit more though later this week.
Iliya Katushenock added 2 commits 2024-02-20 21:13:57 +01:00
Iliya Katushenock added 2 commits 2024-02-24 17:32:04 +01:00
Author
Member

Image of node is added.

Image of node is added.
Iliya Katushenock added 2 commits 2024-02-27 21:57:49 +01:00
Iliya Katushenock added 1 commit 2024-02-29 19:12:32 +01:00
First-time contributor

Is there anything that could be done to help make this node a part of the 4.2 release?

Is there anything that could be done to help make this node a part of the 4.2 release?
First-time contributor

I second that.

what is holding this node back. is it just that no one got around to it, or are there concerns about the node?

I second that. what is holding this node back. is it just that no one got around to it, or are there concerns about the node?
Iliya Katushenock added 2 commits 2024-05-14 15:10:35 +02:00
This pull request has changes conflicting with the target branch.
  • source/blender/blenkernel/BKE_node.hh

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u sample_by_id:mod_moder-sample_by_id
git checkout mod_moder-sample_by_id
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser Project Overview
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#118092
No description provided.